Raised This Month: $51 Target: $400
 12% 

Lightning Hook


Post New Thread Reply   
 
Thread Tools Display Modes
Plugin Info:     Modification:   Counter-Strike        Category:   Fun Stuff       
king999
Member
Join Date: Feb 2015
Location: Mars
Old 03-01-2015 , 20:29   Lightning Hook
Reply With Quote #1

,,,,,,,,,,,,,,,,,,,

Last edited by king999; 03-02-2015 at 12:36.
king999 is offline
Send a message via Skype™ to king999
Spirit_12
Veteran Member
Join Date: Dec 2012
Location: Toronto, CA
Old 03-01-2015 , 20:56   Re: Lightning Hook
Reply With Quote #2

Don't think you need this.

PHP Code:
get_pcvar_num(hook_enabled_cvar)==1
Simply use

PHP Code:
get_pcvar_num(hook_enabled_cvar
Also, you are using a switch with just 1 case and then you used if/else inside of that case. To me you could have used switch or if/else statement, but there is no need to use both.

PHP Code:
public Pressedhook(id,key)
{
    switch(
key)
    {
        case 
0:
        {
            if(
get_pcvar_num(hook_enabled_cvar)==0)
            {
                
set_pcvar_num(hook_enabled_cvar,1)
                
client_print(0,print_chat,"[AMXX] Admin has enabled Hook for all clients. Use: bind key +hook")
            }
            else
            {
                
set_pcvar_num(hook_enabled_cvar,0)
                
client_print(0,print_chat,"[AMXX] Admin has disabled Hook for all non-admins.")
            }
            
show_hook(id)
        }
    }

Did not go through your whole code, but there is lot of room for optimization.
Spirit_12 is offline
king999
Member
Join Date: Feb 2015
Location: Mars
Old 03-01-2015 , 21:26   Re: Lightning Hook
Reply With Quote #3

thanks for telling

Last edited by king999; 03-01-2015 at 21:33.
king999 is offline
Send a message via Skype™ to king999
Jhob94
AMX Mod X Donor
Join Date: Jul 2012
Old 03-02-2015 , 09:10   Re: Lightning Hook
Reply With Quote #4

Quote:
Originally Posted by king999 View Post
please donate for this plugin
Why should i donate you money for something that you didn't made?
Don't claim a plugin just because you did a small edit of an existing one.
__________________
Jhob94 is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 03-02-2015 , 09:17   Re: Lightning Hook
Reply With Quote #5

I think that the discussion about what should we use, fakemeta or engine is ended and everyone understood that it DOESN'T MATTER, use whatever you want. I won't start it again by saying what engine can do better than fm or fm than engine.

PHP Code:
#define ADMIN_LEVEL_Q    ADMIN_LEVEL_C 
Why you redefine ADMIN_LEVEL_C and name it ADMIN_LEVEL_Q. It can cause confusions.

You should use formatex and not format, use static variables only when needed, name your vars correctly so we can understand for what they are.
Don't hardcode string-arrays size and use charsmax to get it.

This is what I saw at a first look, but probably there are more issues that need fixing.
__________________

Last edited by HamletEagle; 03-02-2015 at 09:17.
HamletEagle is offline
king999
Member
Join Date: Feb 2015
Location: Mars
Old 03-02-2015 , 12:33   Re: Lightning Hook
Reply With Quote #6

Jhob94
its your choice
king999 is offline
Send a message via Skype™ to king999
Jhob94
AMX Mod X Donor
Join Date: Jul 2012
Old 03-02-2015 , 12:51   Re: Lightning Hook
Reply With Quote #7

Quote:
Originally Posted by king999 View Post
Jhob94
its your choice

Quote:
Originally Posted by Rules
If you did not write the plugin, put the name of the author in the topic and in the post.
(...)
The code should be yours, or if not, with proper given credit.
You should read rules before post a plugin. Respect the authors of plugins. I just got a bit sad seeing you asking money for something that you didn't made.
__________________

Last edited by Jhob94; 03-02-2015 at 12:51.
Jhob94 is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 03-02-2015 , 13:34   Re: Lightning Hook
Reply With Quote #8

Don't blank your post please.
__________________
HamletEagle is offline
king999
Member
Join Date: Feb 2015
Location: Mars
Old 03-02-2015 , 14:55   Re: Lightning Hook
Reply With Quote #9

Hamlet i have no other choice jhob is acting like +2 i didn't ask for money its my sign Jhob NOOB
i know i am new here
and i want to share my own plugins but
people like you jhob Make your confidence worse mate please next time dont comment on my Plugins ok Mind your own business

Last edited by king999; 03-02-2015 at 15:03.
king999 is offline
Send a message via Skype™ to king999
Jhob94
AMX Mod X Donor
Join Date: Jul 2012
Old 03-02-2015 , 15:14   Re: Lightning Hook
Reply With Quote #10

Well, my bad, didn't saw it was your signature.
Yet, the plugin wasn't made by you, wich still against rules release someone else plugin changing author name or not giving the proper credits.
I don't break anyone's confidence. You didn't read the rules, i told you to read it.
Stop taking it as personal attacks, i didn't disrespected you for you attack me like that. If bugsy is a brother to you as you have at your signature, ask him what he thinks about this thread and then tell me what he thinks.

Edit:
"i know i am new here
and i want to share my own plugins"
Yes, you are new here and i am trying to help you. Telling you to read the rules.
This isn't a code depository, don't post a plugin just because you want to share it. (Once again, read the rules and you will understand)
__________________

Last edited by Jhob94; 03-02-2015 at 15:24.
Jhob94 is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 17:06.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode