[Clauu]

It depends on how big that file it will be but if you're planning to use big amount of data then use sql it's better than any saving method, otherwise use nvault or keep your file and

Originally Posted by Arkshine Then using Trie is not what you want. Just use an Array, loop and use contain().

[Desikac]

PHP Code:

#include <amxmodx>
#include <sqlvault>

new SQLVault:banlist;
new const banfile[] = "addons/amxmodx/configs/bans.cfg";

public plugin_init() {
    register_plugin("sqlvault test", "1", "Desikac");
    loadbans()
    
    register_clcmd("listbans", "listbans");
    register_clcmd("addban", "addban");
    register_clcmd("removeban", "remove");
}

public loadbans() {
    
    if(!file_exists(banfile))
        return
    
    banlist = sqlv_open_local("banlist");
    sqlv_connect(banlist);
        
    new sadrzaj[100];
    new f = fopen( banfile , "rt" );
    
    while( !feof( f ) )
    {
        fgets( f , sadrzaj , charsmax( sadrzaj ) );
        trim( sadrzaj );
        if(!sadrzaj[0])
            continue;
            
        sqlv_set_data(banlist, sadrzaj, "/");
    }
    fclose( f );
    sqlv_disconnect(banlist);
}
    
public listbans(id) {
    sqlv_connect(banlist);
    
    new size = sqlv_size(banlist);
    new key[64];
    
    for(new i = 0; i <size; i++)
    {
        sqlv_read(banlist, i, key, charsmax(key)); //prints only the first line and then gives errors
        console_print(id, key);
    }
    
    sqlv_disconnect(banlist);
    
    console_print(id, "Success.");
}

public addban(id) {
    new arg[100]
    read_args(arg, 99)
    sqlv_connect(banlist);
    
    sqlv_set_data(banlist, arg, "/");
    write_file(banfile, arg);
    
    sqlv_disconnect(banlist);
    
    console_print(id, "Success.");
}

public remove(id) {
    new arg[100]
    read_args(arg, 99)
    sqlv_connect(banlist);
    
    new size = sqlv_size(banlist);
    new key[64], data[64];
    
    for(new i = 0; i <size; i++)
    {
        sqlv_read(banlist, i, key, charsmax(key), data, charsmax(data));
        if(contain(key, arg)) {
            sqlv_remove(banlist, key);
//            remove_ban(arg) - Deletes from file
            console_print(id, "Success.");
        }
    }
    
    sqlv_disconnect(banlist);
    
}

public plugin_end() {
    sqlv_clear(banlist);
    sqlv_close(banlist);
} 


When I use "listbans" it prints the first line and gives a blank string and the error Error in sqlv_read(): unrecognized token: "" for every other line.

[fysiks]

Anything related to a ban list will never be called 1000 times during a map. Since you are recreating the wheel, go look at all the other wheels for how they do it.

[Sylwester]

Don't use SQLVault. Use SQL and do it with threaded queries (SQL_ThreadQuery()).

[Desikac]

Originally Posted by fysiks Anything related to a ban list will never be called 1000 times during a map. Since you are recreating the wheel, go look at all the other wheels for how they do it.

Well 1000 is probably the worst case scenario. Imagine a very popular server which gets about 300 connects per map. The ban list is checked twice per player connect plus every X seconds when the server checks if a ban has expired and another X times when admins add or remove bans. So it can get to 1000 but usually its 200-400 per map on an average server.

Why is sql better that just saving all the data in an array? The list can get huge but in 90% cases it won't because the maximum duration of bans is 1 month.

I tried again using an array and it works:

PHP Code:

#include <amxmodx>

new Array:banlist
new const banfile[] = "addons/amxmodx/configs/bans.cfg";

public plugin_init() {
    register_plugin("array test", "1", "Desikac");
    loadbans()
    
    register_clcmd("listbans", "listbans");
    register_clcmd("addban", "addban");
    register_clcmd("removeban", "remove");
}

public loadbans() {
    
    if(!file_exists(banfile))
        return
    
    banlist = ArrayCreate(50);

    new sadrzaj[100];
    new f = fopen( banfile , "rt" );
    
    while( !feof( f ) )
    {
        fgets( f , sadrzaj , charsmax( sadrzaj ) );
        trim( sadrzaj );
        if(!sadrzaj[0])
            continue;
            
        ArrayPushString(banlist, sadrzaj);
        console_print(0, "Line added: %s", sadrzaj);
    }
    fclose( f );
}
    
public listbans(id) {
    new key[64];
    new size = ArraySize(banlist);
    for(new i = 0; i < size; i++)
    {
        ArrayGetString(banlist, i, key, charsmax(key));
        console_print(id, key);
    }
    
    console_print(id, "Success.");
    return PLUGIN_HANDLED
}

public addban(id) {
    new arg[100]
    read_args(arg, 99)

    ArrayPushString(banlist, arg);
    write_file(banfile, arg);
    
    console_print(id, "Success.");
    return PLUGIN_HANDLED
}

public remove(id) {
    new arg[100];
    read_args(arg, 99);
    
    new key[64], pos[22];
    new timesfound = -1
    new size = ArraySize(banlist);
    
    for(new i = 0; i <size; i++)
    {
        ArrayGetString(banlist, i, key, charsmax(key));
        if(containi(key, arg) != -1) {
            timesfound++;
            pos[timesfound] = i;
        }
    }
    
    for(new j = 0; j <= timesfound; j++)
        ArrayDeleteItem(banlist, pos[j] - j)
    
    console_print(id, "Deleted %s lines.", timesfound);
        
    return PLUGIN_HANDLED
    
} 


[Sylwester]

Originally Posted by Desikac Why is sql better that just saving all the data in an array?

Assuming that your plugin is designed properly:
- you can have the same banlist on multiple servers
- operations on banlist do not interrupt gameplay
- player connect, add ban, remove ban, search bans require only 1 operation and you don't need any loops
- you don't need to remove expired bans

Originally Posted by Desikac The list can get huge but in 90% cases it won't because the maximum duration of bans is 1 month.

You don't ban cheaters permanently?

[Desikac]

Originally Posted by Sylwester - you can have the same banlist on multiple servers

I have a different method for that. Don't need it atm. That is probably the only advantage SQL has over other saving methods.

Originally Posted by Sylwester - operations on banlist do not interrupt gameplay

How does any other method interrupt gameplay?

Originally Posted by Sylwester - player connect, add ban, remove ban, search bans require only 1 operation and you don't need any loops

You don't need to use loops with other methods either. I am using them because some options in my plugin require them. I would still have to use them with SQL.

Originally Posted by Sylwester - you don't need to remove expired bans

How come?

Originally Posted by Sylwester You don't ban cheaters permanently?

What are the chances of the same cheater coming back to the same server after one month? Even if he does, just ban him again. Better than to have 300 more bans per month in the banlist. Anyway, there is an option to ban permanently by putting -1 in the time parameter.

[Sylwester]

Originally Posted by Desikac How does any other method interrupt gameplay?

If you loop through all entries on your ban list (and those tend to get large), at some point it may start causing lags. Although it will not happen if you keep your ban list small.

Originally Posted by Desikac You don't need to use loops with other methods either. I am using them because some options in my plugin require them. I would still have to use them with SQL.

How can you remove bans from an array or search for (partially) matching ids without looping through all entries? Where would you have to do that with SQL?

Originally Posted by Desikac How come?

You can simply exclude expired bans when checking connecting players, or you can delete those bans at that time. There is no need to check ban list every X seconds.

Originally Posted by Desikac What are the chances of the same cheater coming back to the same server after one month? Even if he does, just ban him again.

Well, if you have active admins that can take care of it then temp ban is fine too.

[Clauu]

So much trouble for a ban list, read it once save into memory and then just check your saved data inserting/writing new data when is necessary.

[Backstabnoob]

If you have access to a SQL server then use SQL. It was DESIGNED to be fast and efficient, both with large and small amount of data plus it has a bunch more tools than other saving methods.

When a player connects, you can either check if they have a record in the database directly (which can cause high load) or just check the first time they connect to the map, then save the key to a trie with its value being the timestamp when the ban gets lifted.