[Blizzard_87]

Originally Posted by Arkshine Just to be sure, you did some test right?

I tested the blood decals and they were working as expected. I've only got cs1.6 to test on sadly I can't test on other games.

The melee check I took on faith from your advice should work as you described. I'll do a full test after work and update if any problems.

[Arkshine]

Let's dig more

• This OFFSET_WEAPONOWNER, For consistency reason, please use the original CBasePlayer member name which is m_pPlayer.
• There is really no point to cache value in plugin_cfg, plus such value can be changed in the middle of game, and that's not something which is called often.
• I would cache get_user_team( index ) and get_user_team( iAttacker ) before.
• In CBasePlayer_TakeDamage_P, you should call get_kr_flags where it's actually used, inside second check.
• new szFlags[ 24 ]; well you can reduce buffer, since you can have only 7 flags.
• I think I would use MSG_PVS for TE_BLOODSTREAM because that's something rather fast to happen, so no point to send message to others players who doesn't see this player. Less flood, the better.
• Supporting plugin pause/unpause would be welcomed.

[Blizzard_87]

Originally Posted by Arkshine Let's dig more This OFFSET_WEAPONOWNER, For consistency reason, please use the original CBasePlayer member name which is m_pPlayer. There is really no point to cache value in plugin_cfg, plus such value can be changed in the middle of game, and that's not something which is called often. I would cache get_user_team( index ) and get_user_team( iAttacker ) before. In CBasePlayer_TakeDamage_P, you should call get_kr_flags where it's actually used, inside second check. new szFlags[ 24 ]; well you can reduce buffer, since you can have only 7 flags. I think I would use MSG_PVS for TE_BLOODSTREAM because that's something rather fast to happen, so no point to send message to others players who doesn't see this player. Less flood, the better. Supporting plugin pause/unpause would be welcomed.

Thanks for suggestions.

Will implement them when next on desktop.

[Blizzard_87]

Originally Posted by Arkshine Let's dig more This OFFSET_WEAPONOWNER, For consistency reason, please use the original CBasePlayer member name which is m_pPlayer. Done. There is really no point to cache value in plugin_cfg, plus such value can be changed in the middle of game, and that's not something which is called often. Done I would cache get_user_team( index ) and get_user_team( iAttacker ) before. Done In CBasePlayer_TakeDamage_P, you should call get_kr_flags where it's actually used, inside second check. Done new szFlags[ 24 ]; well you can reduce buffer, since you can have only 7 flags. Done I think I would use MSG_PVS for TE_BLOODSTREAM because that's something rather fast to happen, so no point to send message to others players who doesn't see this player. Less flood, the better. Done Supporting plugin pause/unpause would be welcomed. Done

Updated Plugin

- v0.0.6 -

[ CHANGED ]

OFFSET_WEAPONOWNER to suggested m_pPlayer
Cached get_user_team in TakeDamage
now call get_kr_flags in correct check
changed TE_BLOODSTREAM broadcast to MSG_PVS
Removed plugin_cfg forward
Added Support For Pause/Unpause
edited szFlags buffer down from 24 to 7

Tested and all edits seem to be functional.

[Arkshine]

For now, this is good enough.

Approved.

[Blizzard_87]

Originally Posted by Arkshine For now, this is good enough. Approved.

thanks @Arkshine

[zmd94]

Congratulations, Blizzard_87. ;)

[Krtola]

Can you make version for ZP - when zombie attack humans-humans bleeding?

[Blizzard_87]

Originally Posted by Krtola Can you make version for ZP - when zombie attack humans-humans bleeding?

Sorry don't currently do plugins for ZP.