[striker07]

I'm using a datatimer but something is done wrong, can you see it?

Where the timer gets callend:

PHP Code:

new Handle:hJoinTeamInfo;
 Timer_ClientJoinedTeam[client] = CreateDataTimer(1.0, OnClientChangedTeam, hJoinTeamInfo);
 WritePackCell(hJoinTeamInfo, client);
 WritePackCell(hJoinTeamInfo, iTeam);
 WritePackCell(hJoinTeamInfo, iFirstTeamJoin);
 WritePackCell(hJoinTeamInfo, GetClientTeam(client));
  
 return Plugin_Continue; 


In the callback:

PHP Code:

public Action:OnClientChangedTeam(Handle:timer, Handle:hDatapack)
{
 ResetPack(hDatapack);
 new client = ReadPackCell(hDatapack);
 new iTeam = ReadPackCell(hDatapack);
 new iFirstTeamJoin = ReadPackCell(hDatapack);
 new prevteam = ReadPackCell(hDatapack);
 CloseHandle(hDatapack);
...
...
} 


This gives me a strange error, i think it was a memery error not sure.


Second question: How can i add in the any parameter in my native so that the string is formatable in the native itself.
(fe; i have this now and i want to add in the :any parameter for formatting rules, how can i do this?)

PHP Code:

// native Mmorpg_PrintToChat(client, const String:szMessage[]="");
public Native_Mmorpg_PrintToChat(Handle:plugin, NumParams)
{
 new client = GetNativeCell(1);
 new String:szMessage[255];
 GetNativeString(2, szMessage, sizeof(szMessage));
 
 if(strlen(szMessage) > 0)
 {
  if(_IsValidClient(client))
  {
   CPrintToChat(client, "%s {default}%s", CPrefix, szMessage);
  }
 }
} 


[bl4nk]

1) Try removing the CloseHandle line inside of the timer callback. If that's not it, post the error you're getting.
2) Use the VFormat function.

[striker07]

Ok thanks, that was my first idea aswell but i still need to test it to be 100% sure

I'll get back to you here incase i need further assistance.

[MasterOfTheXP]

PHP Code:

Timer_ClientJoinedTeam[client] = CreateDataTimer(1.0, OnClientChangedTeam, hJoinTeamInfo);
WritePackCell(hJoinTeamInfo, client); 


nuuuuu

You should use client serials/user ids in timers instead of client indexes. Even if you're keeping track using a global array like Timer_ClientJoinedTeam (which I didn't see, heh) it's still not a very good habit.

[Bacardi]

Yep. Like @Master... said.

Do you really need global Handle array for store timers ??
And you don't need CloseHhandle datataimer datapack, it will do itself.

anyway...

Timer_ClientJoinedTeam[MAXPLAYERS+1];

Daa(client)
{

	if(Timer_ClientJoinedTeam[client] != INVALID_HANDLE)
	{
		KillTimer(Timer_ClientJoinedTeam[client]);
		Timer_ClientJoinedTeam[client] = INVALID_HANDLE;
	}

	new Handle:hJoinTeamInfo;
	Timer_ClientJoinedTeam[client] = CreateDataTimer(1.0, OnClientChangedTeam, hJoinTeamInfo);
	WritePackCell(hJoinTeamInfo, client);
	WritePackCell(hJoinTeamInfo, GetClientUserId(client));
	...
	...
	...
	...
	ResetPack(hDatapack);

}

public Action:OnClientChangedTeam(Handle:timer, Handle:hDatapack)
{
	new array_index = ReadPackCell(hDatapack);
	Timer_ClientJoinedTeam[array_index] = INVALID_HANDLE; // Clear handle when timer make (last) action.

	new client = GetClientOfUserId(ReadPackCell(hDatapack));

	if(client == 0)
	{
		return Plugin_Stop;
	}
	...
	...
	...
	...


	return Plugin_Continue;
}

[striker07]

Originally Posted by MasterOfTheXP PHP Code: Timer_ClientJoinedTeam[client] = CreateDataTimer(1.0, OnClientChangedTeam, hJoinTeamInfo);  WritePackCell(hJoinTeamInfo, client);  nuuuuu You should use client serials/user ids in timers instead of client indexes. Even if you're keeping track using a global array like Timer_ClientJoinedTeam (which I didn't see, heh) it's still not a very good habit.

omg you are right, i oversee this quite a lot :s.

Originally Posted by Bacardi Yep. Like @Master... said. Do you really need global Handle array for store timers ?? And you don't need CloseHhandle datataimer datapack, it will do itself.

- i do need a global handle for this because when you join a team it can fail, for example because team is full, i need to catch this event and stop the datatimer callback from executing its actions.
- yeah i edited this and the memory error was gone

Originally Posted by Bacardi Spoiler Timer_ClientJoinedTeam[MAXPLAYERS+1]; Daa(client) { if(Timer_ClientJoinedTeam[client] != INVALID_HANDLE) { KillTimer(Timer_ClientJoinedTeam[client]); Timer_ClientJoinedTeam[client] = INVALID_HANDLE; } new Handle:hJoinTeamInfo; Timer_ClientJoinedTeam[client] = CreateDataTimer(1.0, OnClientChangedTeam, hJoinTeamInfo); WritePackCell(hJoinTeamInfo, client); WritePackCell(hJoinTeamInfo, GetClientUserId(client)); ... ... ... ... ResetPack(hDatapack); } public Action:OnClientChangedTeam(Handle:timer, Handle:hDatapack) { new array_index = ReadPackCell(hDatapack); Timer_ClientJoinedTeam[array_index] = INVALID_HANDLE; // Clear handle when timer make (last) action. new client = GetClientOfUserId(ReadPackCell(hDatapack)); if(client == 0) { return Plugin_Stop; } ... ... ... ... return Plugin_Continue; }

I know its not nescesary to close the handle in the datatimer callback but i am using return plugin_stop instead of plugin_continue and before this i already set the global timerhandle to invalid and this works without errors. does it matter here what i return at the end of the datatimer callback?

How I have it now:

PHP Code:

public Action:OnClientJoinTeam(client, const String:command[], argc)
{
    if(!argc || !_IsValidClient(client))
        return Plugin_Continue;
    .....
    .....
 
    if( Timer_ClientJoinedTeam[client] != INVALID_HANDLE )
    {
         CloseHandle(Timer_ClientJoinedTeam[client]);
         Timer_ClientJoinedTeam[client] = INVALID_HANDLE;
     }
 
    new Handle:hJoinTeamInfo;
    Timer_ClientJoinedTeam[client] = CreateDataTimer(1.0, OnClientChangedTeam, hJoinTeamInfo);
    WritePackCell(hJoinTeamInfo, client);
    WritePackCell(hJoinTeamInfo, GetClientUserId(client));
    WritePackCell(hJoinTeamInfo, iTeam);
    WritePackCell(hJoinTeamInfo, iFirstTeamJoin);
    WritePackCell(hJoinTeamInfo, GetClientTeam(client));
    ResetPack(hJoinTeamInfo); 
 
    return Plugin_Continue;
}
 
public Action:OnClientChangedTeam(Handle:timer, Handle:hDatapack)
{
    new handle_index = ReadPackCell(hDatapack);
    new client = GetClientOfUserId(ReadPackCell(hDatapack));
    new iTeam = ReadPackCell(hDatapack);
    new iFirstTeamJoin = ReadPackCell(hDatapack);
    new prevteam = ReadPackCell(hDatapack);
 
    Timer_ClientJoinedTeam[handle_index] = INVALID_HANDLE;
 
    if( client == 0 )
    {
         return Plugin_Stop;
    }
    .....
    .....
    .....
    return Plugin_Stop;
} 


[striker07]

Originally Posted by bl4nk 1) 2) Use the VFormat function.

is this correct?:

PHP Code:

public Native_Mmorpg_PrintToChat(Handle:plugin, NumParams)
{
    new client = GetNativeCell(1);
    new String:szMessage[256];
    GetNativeString(2, szMessage, sizeof(szMessage));
    VFormat(szMessage, 256, szMessage, 3);
 
    if(strlen(szMessage) > 0)
    {
         if(_IsValidClient(client))
        {
             CPrintToChat(client, "%s {default}%s", CPrefix, szMessage);
        }
    }
} 


edit.
tested this but it does not work, the the %.. are not formatted and displayed as %.

[friagram]

Your mechanism of action is bad. Just add command listener for jointeam, or just use getclientteam. Try storing their previous team in an array?

[striker07]

Originally Posted by friagram Your mechanism of action is bad. Just add command listener for jointeam, or just use getclientteam. Try storing their previous team in an array?

that is how its done

HookEvent("jointeam_failed", Event_JoinTeamFailed, EventHookMode_Pre); // here i simply close timerhandle before it fires and set handle to invalid if not invalid
AddCommandListener(OnClientJoinTeam, "jointeam");


it works perfectly, no problems with that anymore

[striker07]

For the vformat issue, i am getting this in my server console:
L 03/29/2014 - 156:48: [SM] Plugin encountered error 4: Invalid parameter or parameter type
L 03/29/2014 - 156:48: [SM] Native "VFormat" reported: String formatted incorrectly - parameter 3 (total 2)

using this native:

PHP Code:

public Native_Mmorpg_PrintToChat(Handle:plugin, NumParams)
{
    new client = GetNativeCell(1);
    new String:szMessage[256];
    GetNativeString(2, szMessage, sizeof(szMessage));
    new String:szFinalMsg[256];
    VFormat(szFinalMsg, 256, szMessage, 3);
 
    if(strlen(szMessage) > 0)
    {
         if(_IsValidClient(client))
         {
              CPrintToChat(client, "%s {default}%s", CPrefix, szFinalMsg);
         }
    }
} 


The problem is that Vformat does not see the third parameter in this native(also not retrieving the any:... parameter, how can i fix this/return the any parameter?

I was thinking getnativecellref but this does not seem logical.
Can vformat even be used in natives?