Module: GeoIP+ (v1.3) - Page 18

.:cs.stambeto:. · 02-06-2015 , 10:25 Re: Module: GeoIP+ (v1.1)

Why not do it when you can not recognize the city to write so [error] or N/A , as it was in previous versions. For now displayed in chat [] and at least hud visible N/A.

**Arkshine** · 02-07-2015 , 10:45 Re: Module: GeoIP+ (v1.1)

That's coder's job to define how they want to show on failed lookup. That a plugin doesn't deal with the possibility geoip could return no data, is a tip plugin is poorly coded.
That's said to keep compatibility, "error" should be set for "geoip_country'. Will be fixed soon for this one.

.:cs.stambeto:. · 02-07-2015 , 18:46 Re: Module: GeoIP+ (v1.1)

Quote:

Originally Posted by Arkshine

That's coder's job to define how they want to show on failed lookup. That a plugin doesn't deal with the possibility geoip could return no data, is a tip plugin is poorly coded.
That's said to keep compatibility, "error" should be set for "geoip_country'. Will be fixed soon for this one.

I tried last update countries when it can not recognize them write N/A on hud if can fix and for city. Also the previous version when you can not recognize any city or state in writing chat [error] if can fix him.

bLacK-bLooD · 02-18-2015 , 06:15 Re: Module: GeoIP+ (v1.1)

I am using the last update, but it is really inaccurate. This is one output example:

Code:

m.p. has conected from [Denmark][Holstebro]
GiAnNhS has conected from [Greece][Holstebro]
luca knudsen has conected from [Denmark][Holstebro]
crackeN has conected from [Germany][Holstebro]
Renicilin has conected from [Hungary][Budapest]
Muva ^ has conected from [Serbia][Backo Gradiste]
silujem has conected from [Bosnia and Herzegovina][Backo Gradiste]

PHP Code:


			
new szCountry[32], szCity[32];

public plugin_init()
{
    register_plugin("Country/City Connect", "0.1", "black-blood");
}

public client_putinserver(id)
{
    new szName[32], szIP[32];
    
    get_user_name(id, szName, charsmax(szName))
    get_user_ip(id, szIP, charsmax(szIP), 1)

    geoip_country(szIP, szCountry, charsmax (szCountry))
    geoip_city(szIP, szCity, charsmax(szCity))

    client_print(0, print_chat, "%s has conected from [%s][%s]", szName, szCountry, szCity);

**Arkshine** · 02-18-2015 , 07:00 Re: Module: GeoIP+ (v1.1)

I'm not sure how I'm supposed to see how it's inaccurate from your example, but I can do nothing on it anyway. Database is provided as it is. It's the lite and free version. It's probably a good idea to update it often, as it seems to be updated each week and since it's a new database format, it's likely it will have more and more data.

bLacK-bLooD · 02-18-2015 , 07:05 Re: Module: GeoIP+ (v1.1)

Well the examples shows how one city is displayed to more countries. How can Hostelbro be in Denmark, Greece and Germany at the same time?

**Arkshine** · 02-18-2015 , 08:27 Re: Module: GeoIP+ (v1.1)

This sounds like a bug. Not sure if from lib API or module. Well it won't hurt to check things.

Actually, this would help if you could test if issue is not from database. Get the ip where city seems wrong, and use the server command: geoip dump <ip> ; it will dump all datas for this IP, and check the "city" entry, if you see the same city name, it's likely a bug with the database, if you see the right name, it means there is some issue with API or module code.

bLacK-bLooD · 02-18-2015 , 09:15 Re: Module: GeoIP+ (v1.1)

Okay I think I got something.

I tried dumping on a player that had it's location accurate, and I got this JSON output:

Code:

{
    "city": 
      {
        "geoname_id": 
          785482 <uint32>
        "names": 
          {
            "de": 
              "Štip" <utf8_string>
            "en": 
              "Shtip" <utf8_string>
          }
      }
    "continent": 
      {
        "code": 
          "EU" <utf8_string>
        "geoname_id": 
          6255148 <uint32>
        "names": 
          {
            "de": 
              "Europa" <utf8_string>
            "en": 
              "Europe" <utf8_string>
            "es": 
              "Europa" <utf8_string>
            "fr": 
              "Europe" <utf8_string>
            "ja": 
              "ヨーロッパ" <utf8_string>
            "pt-BR": 
              "Europa" <utf8_string>
            "ru": 
              "Европа" <utf8_string>
            "zh-CN": 
              "欧洲" <utf8_string>
          }
      }
    "country": 
      {
        "geoname_id": 
          718075 <uint32>
        "iso_code": 
          "MK" <utf8_string>
        "names": 
          {
            "de": 
              "Ehemalige jugoslawische Republik Mazedonien" <utf8_string>
            "en": 
              "Macedonia" <utf8_string>
            "es": 
              "Macedonia" <utf8_string>
            "fr": 
              "Macédoine" <utf8_string>
            "ja": 
              "マケドニア旧ユーゴスラビア共和国" <utf8_string>
            "pt-BR": 
              "Macedônia" <utf8_string>
            "ru": 
              "Македония" <utf8_string>
            "zh-CN": 
              "前南斯拉夫马其顿共和国" <utf8_string>
          }
      }
    "location": 
      {
        "latitude": 
          41.742300 <double>
        "longitude": 
          22.197900 <double>
        "time_zone": 
          "Europe/Skopje" <utf8_string>
      }
    "registered_country": 
      {
        "geoname_id": 
          718075 <uint32>
        "iso_code": 
          "MK" <utf8_string>
        "names": 
          {
            "de": 
              "Ehemalige jugoslawische Republik Mazedonien" <utf8_string>
            "en": 
              "Macedonia" <utf8_string>
            "es": 
              "Macedonia" <utf8_string>
            "fr": 
              "Macédoine" <utf8_string>
            "ja": 
              "マケドニア旧ユーゴスラビア共和国" <utf8_string>
            "pt-BR": 
              "Macedônia" <utf8_string>
            "ru": 
              "Македония" <utf8_string>
            "zh-CN": 
              "前南斯拉夫马其顿共和国" <utf8_string>
          }
      }
    "subdivisions": 
      [
        {
          "geoname_id": 
            863900 <uint32>
          "iso_code": 
            "70" <utf8_string>
          "names": 
            {
              "en": 
                "Opstina Stip" <utf8_string>
            }
        }
      ]
  }

However when I tried dumping on a player that had a wrong location, this was the JSON output:

Code:

  {
    "continent": 
      {
        "code": 
          "EU" <utf8_string>
        "geoname_id": 
          6255148 <uint32>
        "names": 
          {
            "de": 
              "Europa" <utf8_string>
            "en": 
              "Europe" <utf8_string>
            "es": 
              "Europa" <utf8_string>
            "fr": 
              "Europe" <utf8_string>
            "ja": 
              "ヨーロッパ" <utf8_string>
            "pt-BR": 
              "Europa" <utf8_string>
            "ru": 
              "Европа" <utf8_string>
            "zh-CN": 
              "欧洲" <utf8_string>
          }
      }
    "country": 
      {
        "geoname_id": 
          390903 <uint32>
        "iso_code": 
          "GR" <utf8_string>
        "names": 
          {
            "de": 
              "Griechenland" <utf8_string>
            "en": 
              "Greece" <utf8_string>
            "es": 
              "Grecia" <utf8_string>
            "fr": 
              "Grèce" <utf8_string>
            "ja": 
              "ギリシャ共和国" <utf8_string>
            "pt-BR": 
              "Grécia" <utf8_string>
            "ru": 
              "Греция" <utf8_string>
            "zh-CN": 
              "希腊" <utf8_string>
          }
      }
    "location": 
      {
        "latitude": 
          37.966700 <double>
        "longitude": 
          23.716700 <double>
        "time_zone": 
          "Europe/Athens" <utf8_string>
      }
    "registered_country": 
      {
        "geoname_id": 
          390903 <uint32>
        "iso_code": 
          "GR" <utf8_string>
        "names": 
          {
            "de": 
              "Griechenland" <utf8_string>
            "en": 
              "Greece" <utf8_string>
            "es": 
              "Grecia" <utf8_string>
            "fr": 
              "Grèce" <utf8_string>
            "ja": 
              "ギリシャ共和国" <utf8_string>
            "pt-BR": 
              "Grécia" <utf8_string>
            "ru": 
              "Греция" <utf8_string>
            "zh-CN": 
              "希腊" <utf8_string>
          }
      }
  }

What I can see is that when the city is wrong/unknown, it doesn't output the city key/value pair, so basically there's no data about that city. The strange thing is that the module somehow figures out something is missing and replaces the missing city with a random one.'

Here is another wrong one:

Code:

  {
    "continent": 
      {
        "code": 
          "EU" <utf8_string>
        "geoname_id": 
          6255148 <uint32>
        "names": 
          {
            "de": 
              "Europa" <utf8_string>
            "en": 
              "Europe" <utf8_string>
            "es": 
              "Europa" <utf8_string>
            "fr": 
              "Europe" <utf8_string>
            "ja": 
              "ヨーロッパ" <utf8_string>
            "pt-BR": 
              "Europa" <utf8_string>
            "ru": 
              "Европа" <utf8_string>
            "zh-CN": 
              "欧洲" <utf8_string>
          }
      }
    "country": 
      {
        "geoname_id": 
          3194884 <uint32>
        "iso_code": 
          "ME" <utf8_string>
        "names": 
          {
            "de": 
              "Montenegro" <utf8_string>
            "en": 
              "Montenegro" <utf8_string>
            "es": 
              "Montenegro" <utf8_string>
            "fr": 
              "Monténégro" <utf8_string>
            "ja": 
              "モンテネグロ" <utf8_string>
            "pt-BR": 
              "Montenegro" <utf8_string>
            "ru": 
              "Черногория" <utf8_string>
            "zh-CN": 
              "黑山共和国" <utf8_string>
          }
      }
    "location": 
      {
        "latitude": 
          42.000000 <double>
        "longitude": 
          19.000000 <double>
        "time_zone": 
          "Europe/Podgorica" <utf8_string>
      }
    "registered_country": 
      {
        "geoname_id": 
          3194884 <uint32>
        "iso_code": 
          "ME" <utf8_string>
        "names": 
          {
            "de": 
              "Montenegro" <utf8_string>
            "en": 
              "Montenegro" <utf8_string>
            "es": 
              "Montenegro" <utf8_string>
            "fr": 
              "Monténégro" <utf8_string>
            "ja": 
              "モンテネグロ" <utf8_string>
            "pt-BR": 
              "Montenegro" <utf8_string>
            "ru": 
              "Черногория" <utf8_string>
            "zh-CN": 
              "黑山共和国" <utf8_string>
          }
      }
  }

**Arkshine** · 02-18-2015 , 09:53 Re: Module: GeoIP+ (v1.1)

Ah. I think know why and has been already fixed some days ago on amxx repo. Issue is module doesn't set a length to 0 when it should, so what you get is a previous value from buffer.

I have to sync changes from upstream for this module. Wait for an update.

**Arkshine** · 02-19-2015 , 16:01 Re: Module: GeoIP+ (v1.2)

Updated to 1.2 from upstream.

Essentially, it fixes a buffer issue with natives, and fix some various compatibility issues.
Check https://forums.alliedmods.net/showth...7215#Changelog for more informations.