Help to modify PrintToChatAll

PepeZukas · **Author**

I want to change, with your help a plugin, so that the messages appear only to me, even properly configured in sourcemod.cfg, everyone can see them;

Code:

// Default: 13 (1+4+8)
sm_show_activity 12

Here is the part of the code where the messages are:

Code:

if (StrContains(mapname, "c1m3_mall", false) != -1)
	{
		// Dead Center 03 - emergency door or windows
		// name door_hallway_lower4a, class prop_door_rotating, Input "Open"
		// they do the rest veeery slowly, but by themselves
		
		new door = FindEntityByName("door_hallway_lower4a", -1);
		
		decl Float:pos1[3];
		if (door > 0)
		{
			GetEntityAbsOrigin(door, pos1);
			if (CheckforBots(pos1, 200.0) && !MapTrigger)
			{
				//PrintToChatAll("\x04[AutoTrigger] \x01Bot found close to the Emergency Door, open sesame...");
				//PrintToChatAll("\x04[AutoTrigger] \x01Warping them all ahead in 30 seconds.");
				PrintToChatAll("\x04[AutoTrigger] \x01Start c1m3 trigger.");

				AcceptEntityInput(door, "Open");

				new Handle:posxdata = CreateDataPack();
				WritePackFloat(posxdata, 1207.4);
				WritePackFloat(posxdata, -3180.1);
				WritePackFloat(posxdata, 598.0);
				CreateTimer(30.0, WarpAllBots, posxdata);
				MapTrigger = true;
			}
		}
		
		new glass = FindEntityByName("breakble_glass_minifinale", -1); //Valve typing error, lol
		if (glass > 0)
		{
			GetEntityAbsOrigin(glass, pos1);
			if (CheckforBots(pos1, 200.0) && !MapTrigger)
			{
				//PrintToChatAll("\x04[AutoTrigger] \x01Bot found close to the Alarmed Windows, open sesame...");
				//PrintToChatAll("\x04[AutoTrigger] \x01Warping them all ahead in 30 seconds.");
				PrintToChatAll("\x04[AutoTrigger] \x01Start c1m3 trigger.");

				new Handle:posxdata = CreateDataPack();
				WritePackFloat(posxdata, 1207.4);
				WritePackFloat(posxdata, -3180.1);
				WritePackFloat(posxdata, 598.0);
				CreateTimer(30.0, WarpAllBots, posxdata);
				MapTrigger = true;
			}
		}
	}

(There are several of them)

I thought about modifying the "PrintToChatAll" to "PrintToAdmins" or something like, but I do not know if this will only work, if it has to modify something else...

If necessary the complete code, here it is: [L4D2] Survivor Bots Auto Trigger

I am very grateful if anyone can help me.

Mitchell · 03-16-2017 , 09:30 Re: Help to modify PrintToChatAll

ShowActivity convar only affects the ShowActivity natives. ie: https://sm.alliedmods.net/new-api/console/ShowActivity

midnight9 · *Last edited by midnight9; 03-16-2017 at 13:04.*

Quote:

Originally Posted by PepeZukas

I want to change, with your help a plugin, so that the messages appear only to me, even properly configured in sourcemod.cfg, everyone can see them;

Code:

// Default: 13 (1+4+8)
 sm_show_activity 12

Here is the part of the code where the messages are:

Code:

if (StrContains(mapname, "c1m3_mall", false) != -1)
     {
         // Dead Center 03 - emergency door or windows
         // name door_hallway_lower4a, class prop_door_rotating, Input "Open"
         // they do the rest veeery slowly, but by themselves
         
         new door = FindEntityByName("door_hallway_lower4a", -1);
         
         decl Float:pos1[3];
         if (door > 0)
         {
             GetEntityAbsOrigin(door, pos1);
             if (CheckforBots(pos1, 200.0) && !MapTrigger)
             {
                 //PrintToChatAll("\x04[AutoTrigger] \x01Bot found close to the Emergency Door, open sesame...");
                 //PrintToChatAll("\x04[AutoTrigger] \x01Warping them all ahead in 30 seconds.");
                 PrintToChatAll("\x04[AutoTrigger] \x01Start c1m3 trigger.");
 
                 AcceptEntityInput(door, "Open");
 
                 new Handle:posxdata = CreateDataPack();
                 WritePackFloat(posxdata, 1207.4);
                 WritePackFloat(posxdata, -3180.1);
                 WritePackFloat(posxdata, 598.0);
                 CreateTimer(30.0, WarpAllBots, posxdata);
                 MapTrigger = true;
             }
         }
         
         new glass = FindEntityByName("breakble_glass_minifinale", -1); //Valve typing error, lol
         if (glass > 0)
         {
             GetEntityAbsOrigin(glass, pos1);
             if (CheckforBots(pos1, 200.0) && !MapTrigger)
             {
                 //PrintToChatAll("\x04[AutoTrigger] \x01Bot found close to the Alarmed Windows, open sesame...");
                 //PrintToChatAll("\x04[AutoTrigger] \x01Warping them all ahead in 30 seconds.");
                 PrintToChatAll("\x04[AutoTrigger] \x01Start c1m3 trigger.");
 
                 new Handle:posxdata = CreateDataPack();
                 WritePackFloat(posxdata, 1207.4);
                 WritePackFloat(posxdata, -3180.1);
                 WritePackFloat(posxdata, 598.0);
                 CreateTimer(30.0, WarpAllBots, posxdata);
                 MapTrigger = true;
             }
         }
     }

(There are several of them)

I thought about modifying the "PrintToChatAll" to "PrintToAdmins" or something like, but I do not know if this will only work, if it has to modify something else...

If necessary the complete code, here it is: [L4D2] Survivor Bots Auto Trigger

I am very grateful if anyone can help me.

I think something like this should work:

PHP Code:


			
for (new i = 1; i <= GetMaxClients(); i++)
{
      if (IsClientInGame(i) && !IsFakeClient(i) && CheckCommandAccess(i, "sm_ban", ADMFLAG_BAN))
      {
            //PrintToChat (i, "\x04[AutoTrigger] \x01Bot found close to the Emergency Door, open sesame...");
            //PrintToChat (i, "\x04[AutoTrigger] \x01Warping them all ahead in 30 seconds.");
            PrintToChat (i, "\x04[AutoTrigger] \x01Start c1m3 trigger.");
      }
}

Timocop · 03-16-2017 , 14:20 Re: Help to modify PrintToChatAll

To avoid unnecessary calls and slowdowns dont call methods everytime if you know the result will always be the same or doesnt change.

PHP Code:


			
for (new i = 1; i <= MaxClients; i++) //Best

PHP Code:


			
new iMaxClients = GetMaxClients();
for (new i = 1; i <= iMaxClients; i++) //Ok

for (new i = GetMaxClients(); i > 0; i--) //Ok

PHP Code:


			
for (new i = 1; i <= GetMaxClients(); i++) //Bad

xines · 03-16-2017 , 14:27 Re: Help to modify PrintToChatAll

Quote:

Originally Posted by Timocop

To avoid unnecessary calls and slowdowns dont call methods everytime if you know the result will always be the same or doesnt change.

PHP Code:


			
for (new i = 1; i <= MaxClients; i++) //Best

PHP Code:


			
new iMaxClients = GetMaxClients();

for (new i = 1; i <= iMaxClients; i++) //Ok



for (new i = GetMaxClients(); i > 0; i--) //Ok

PHP Code:


			
for (new i = 1; i <= GetMaxClients(); i++) //Bad

Since the function is set to be deprecated, we should only focus on using the MaxClients dynamic variable.

PepeZukas · 03-16-2017 , 20:52 Re: Help to modify PrintToChatAll

Quote:

Originally Posted by Timocop

To avoid unnecessary calls and slowdowns dont call methods everytime if you know the result will always be the same or doesnt change.

PHP Code:


			
for (new i = 1; i <= MaxClients; i++) //Best

PHP Code:


			
new iMaxClients = GetMaxClients();

for (new i = 1; i <= iMaxClients; i++) //Ok



for (new i = GetMaxClients(); i > 0; i--) //Ok

PHP Code:


			
for (new i = 1; i <= GetMaxClients(); i++) //Bad

I'm bad at writing these codes, how could I include these lines in the plugin?

I thank you all for all the tips.

midnight9 · 03-17-2017 , 02:38 Re: Help to modify PrintToChatAll

Quote:

Originally Posted by Timocop

To avoid unnecessary calls and slowdowns dont call methods everytime if you know the result will always be the same or doesnt change.

PHP Code:


			
for (new i = 1; i <= MaxClients; i++) //Best

PHP Code:


			
 new iMaxClients = GetMaxClients();
 for (new i = 1; i <= iMaxClients; i++) //Ok
 
 for (new i = GetMaxClients(); i > 0; i--) //Ok

PHP Code:


			
for (new i = 1; i <= GetMaxClients(); i++) //Bad

Ahh yes, my bad.

midnight9 · *Last edited by midnight9; 03-17-2017 at 12:19.*

Quote:

Originally Posted by PepeZukas

I'm bad at writing these codes, how could I include these lines in the plugin?

I thank you all for all the tips.

Code:

 if (StrContains(mapname, "c1m3_mall", false) != -1)
 {
  // Dead Center 03 - emergency door or windows
  // name door_hallway_lower4a, class prop_door_rotating, Input "Open"
  // they do the rest veeery slowly, but by themselves
  
  new door = FindEntityByName("door_hallway_lower4a", -1);
  
  decl Float:pos1[3];
  if (door > 0)
  {
   GetEntityAbsOrigin(door, pos1);
   if (CheckforBots(pos1, 200.0) && !MapTrigger)
   {
         for (new i = 1; i <= MaxClients; i++)
         {
              if (IsClientInGame(i) && !IsFakeClient(i) && CheckCommandAccess(i, "sm_ban", ADMFLAG_BAN))
              {
                    //PrintToChat (i, "\x04[AutoTrigger] \x01Bot found close to the Emergency Door, open sesame...");
                    //PrintToChal (i, "\x04[AutoTrigger] \x01Warping them all ahead in 30 seconds.");
                    PrintToChat (i, "\x04[AutoTrigger] \x01Start c1m3 trigger.");
              }
         } 
     
         AcceptEntityInput(door, "Open");
    
         new Handle:posxdata = CreateDataPack();
         WritePackFloat(posxdata, 1207.4);
         WritePackFloat(posxdata, -3180.1);
         WritePackFloat(posxdata, 598.0);
         CreateTimer(30.0, WarpAllBots, posxdata);
         MapTrigger = true;
   }
  }

Fortis · *Last edited by Fortis; 03-18-2017 at 01:19.*

PrintToChatAll prints a message to everyone in the chat.
PrintToChat prints a message to the client.

Example:
PrintToChatAll("Hello"); - This prints a chat to everyone saying hello.
PrintToChat(client, "Hello"); - This prints a chat to you saying hello.

Client can be replaced with i, depending on how it is being used.

PepeZukas · 03-18-2017 , 10:34 Re: Help to modify PrintToChatAll

Thank you all for the help.