[Rushy]

Hi,

Wondering what is the correct method to get a clients userid?

I want to get a clients userid and combine it with the sm_freeze command, I was using a clients name however it seems to not like clients with a space in their nickname

[Impact123]

You can use GetClientUserId to get a client's user id. If you want to use a name with spaces you probably need to use use quotation marks around it. Looking at how sm_freeze is implemented might be of interesting too.

[OSWO]

What do you mean? Most functions in sourcemod use the Client's Index which can be gotten from the userid through the function: GetClientOfUserId

Most "targeting" functions return a client index rather then the userid, which is then used for other shit.

FindTarget(0, nametocheckagainst);

FindTarget returns a client index if it finds someone, otherwise it returns -1.

[Rushy]

Originally Posted by Impact123 You can use GetClientUserId to get a client's user id. If you want to use a name with spaces you probably need to use use quotation marks around it. Looking at how sm_freeze is implemented might be of interesting too.

Thanks.

I have tried the quotation marks in the console and it works. What would be the correct way in code

ServerCommand("sm_freeze "%N" 15", client);

That way fails to compile with the quotes around %N

[Impact123]

You need to escape the character(s) like this

PHP Code:

ServerCommand("sm_freeze \"%N\" 15", client); 


[Rushy]

Originally Posted by Impact123 You need to escape the character(s) like this PHP Code: ServerCommand("sm_freeze \"%N\" 15", client);

Many Thanks

[WildCard65]

Never ever EVER pass a client's name to ServerCommand, doing so runs the risk of your server getting remote command exeuction, example:

1. Client's Name: "\"; quit; \""
2. ServerCommand (when formatted) becomes: "sm_freeze \"\"; quit; \"\""
3. Server executes sm_freeze with 1 string arg reading ""
4. Server executes the quit command with 0 args
5. Server shuts down because of "quit" command.

Always pass a userid to ServerCommand, example:

PHP Code:

ServerCommand("sm_freeze #%d 15", GetClientUserId(client)); 


[Bacardi]

Indeed!

Originally Posted by WildCard65 Never ever EVER pass a client's name to ServerCommand, doing so runs the risk of your server getting remote command exeuction ... Always pass a userid to ServerCommand ...

ServerCommand Exploits

[Rushy]

Cheers for that WildCard. You have indeed saved me, I am now using userid's