[Nutu_]

L 04/19/2020 - 14:46:56: [AMXX] Displaying debug trace (plugin "survminigun.amxx")
L 04/19/2020 - 14:46:56: [AMXX] Run time error 4: index out of bounds
L 04/19/2020 - 14:46:56: [AMXX] [0] cominigun.sma::event_start (line 234)

PHP Code:

public event_start(){
    static iPlayers[32], iPlayersNum, i 
    get_players(iPlayers, iPlayersNum, "a")
    for (i = 0; i <= iPlayersNum; ++i)
        canfire[iPlayers[i]] = true
} 


[fysiks]

iPlayersNum is the number of players, not the largest index of the array because arrays are zero-indexed. So, the last index that you use will be iPlayersNum - 1 so in your for loop, you use:

i < iPlayersNum

[Nutu_]

like

PHP Code:

for (i = 0; i < iPlayersNum; ++i) 


or just

PHP Code:

i < iPlayersNum 


[Fuck For Fun]

Originally Posted by Nutu_ like PHP Code: for (i = 0; i < iPlayersNum; ++i)

[OciXCrom]

public event_start(){
    arrayset(canfire, false, sizeof(canfire))
}

[Nutu_]

Originally Posted by OciXCrom public event_start(){     arrayset(canfire, false, sizeof(canfire)) }

seems to work, thank you!

[Napoleon_be]

Originally Posted by Nutu_ seems to work, thank you!

Basicly, it's the same thing, just less typing.

[fysiks]

Originally Posted by Napoleon_be Basicly, it's the same thing, just less typing.

Actually, it's not the same. It likely depends on how the array is being used but using arrayset() is most likely to be the correct solution.

[Bugsy]

I think what he was getting at is you end up with the same result, which is true...and it is less typing/code.

Not only is it less code, but arrayset() is avoiding the need to call get_players() and then a subsequent for-loop. arrayset() cannot be used for all situations, which is what fysiks was getting at, but in this case it can be used.

[fysiks]

If it's a situation where canfire is being used as a "once per event" flag, it's possible that someone joins after the "event" occurs and uses a slot that wasn't properly reset with the get_players() method. Then, the new player could be deprived of their one use of that function. In this specific scenario, arrayset() is the only correct solution (between the two options listed here).