[maxolahird]

I'm trying to add a command in this plugin to make players able to toggle "show bullet damage".

At least for me it seems everything is correct but still it wont toggle properly/make damage not show up.

What's wrong?

PHP Code:

#include <amxmodx>
#include <engine>

new g_hudmsg1, g_hudmsg2,g_type, g_enabled;
new bool:gOnOff[33] = { true, ... };

public plugin_init() {
    register_plugin("Bullet Damage with Spec", "1.3", "Sn!ff3r, modded by mforce")
    register_event("Damage", "on_damage", "b", "2!0", "3=0", "4!0")    
    
    register_clcmd("amx_dmg", "toggleDmg", 0, "");  
    register_clcmd("amx_showdmg", "toggleDmg", 0, ""); 
    
    g_type = register_cvar("amx_bulletdamage","1")
    
    g_hudmsg1 = CreateHudSyncObj()
    g_hudmsg2 = CreateHudSyncObj()
}

public toggleDmg(id)
{
    if( gOnOff[id] )
    {
        client_print_color(id, id, "OFF");
        gOnOff[id] = false;
    }
    else
    {
        client_print_color(id, id, "ON");
        gOnOff[id] = true;
    }
}

public on_damage(id) {    
    static attacker; attacker = get_user_attacker(id)
    if(is_user_connected(attacker)) {
        static damage; damage = read_data(2)
        g_enabled = get_pcvar_num(g_type)    
        
        if(g_enabled && gOnOff[id] == true)
        {    

            set_hudmessage(255, 0, 0, 0.45, 0.50, 2, 0.1, 4.0, 0.1, 0.1, -1)
            ShowSyncHudMsg(id, g_hudmsg2, "%i^n", damage)
            
            set_hudmessage(0, 100, 200, -1.0, 0.55, 2, 0.1, 4.0, 0.02, 0.02, -1)
            ShowSyncHudMsg(attacker, g_hudmsg1, "%i^n", damage)
            

            static iPlayers[32], iNum;
            get_players(iPlayers, iNum, "bch")

            for(new i = 0, Spectator = iPlayers[0]; i < iNum; Spectator = iPlayers[i++]) {
                if(entity_get_int(Spectator, EV_INT_iuser2) == attacker) {
                    set_hudmessage(0, 100, 200, -1.0, 0.55, 2, 0.1, 4.0, 0.02, 0.02, -1)
                    ShowSyncHudMsg(Spectator, g_hudmsg1, "%i^n", damage)
                }
                if(entity_get_int(Spectator, EV_INT_iuser2) == id) {
                    set_hudmessage(255, 0, 0, 0.45, 0.50, 2, 0.1, 4.0, 0.1, 0.1, -1)
                    ShowSyncHudMsg(Spectator, g_hudmsg2, "%i^n", damage)
                }
            }
        }
    }
}  

public client_connect(id)
{
    gOnOff[id] = true;
}

public client_disconnect(id)
{
    gOnOff[id] = true;
} 


[OciXCrom]

Why are you checking "id" in the damage event? You should check both id and attacker when displaying the message to either one of them.

[Craxor]

public toggleDmg(id) 
{ 
    gOnOff[ id ] = !gOnOff[ id ];
    client_print( id , print_chat, gOnOff[ id ] ? "OFF" : "ON" );
    return PLUGIN_HANDLED;
}

[maxolahird]

Originally Posted by OciXCrom Why are you checking "id" in the damage event? You should check both id and attacker when displaying the message to either one of them.

Hey, I'm not sure, I didn't write that code, Sn!ff3r did. I just added (or tried) toggle stuff.
https://forums.alliedmods.net/showthread.php?t=88577

Originally Posted by Craxor public toggleDmg(id) {     gOnOff[ id ] = !gOnOff[ id ];     client_print( id , print_chat, gOnOff[ id ] ? "OFF" : "ON" );     return PLUGIN_HANDLED; }

Hey, That and the original code for some reason only disables damage received HUD, not damage dealt.. really weird

It's just not checking the toggle command properly.

I tought anything inside if(g_enabled && gOnOff[id] == true), should not show up if gOnOff[id] = false.. I probably did something wrong

[maxolahird]

Guys how can I make it enable/disable properly according to cvar or chat command?