[Marcus101RR]

The Code Below says the damage and the new damage, but does not take affect...

PHP Code:

public OnClientPutInServer(client)
{
    SDKHook(client, SDKHook_OnTakeDamage, OnTakeDamage);
}

public Action:OnTakeDamage(victim, &attacker, &inflictor, &Float:damage, &damagetype)
{
    decl String:z_difficulty[16];
    GetConVarString(FindConVar("z_difficulty"), z_difficulty, sizeof(z_difficulty));

    if(StrEqual(z_difficulty, "Impossible", false) && GetClientTeam(victim) == 2)
    {
        PrintToChat(victim, "Damage: %f, New: %f", damage, damage*0.5);
        damage = damage * 0.5;
        return Plugin_Changed;
    }
    return Plugin_Changed;
} 


[mcpan313]

Have you reload it after map start?

PHP Code:

new bool:g_bLateload;
public APLRes:AskPluginLoad2(Handle:myself, bool:late, String:error[], err_max)
{
    g_bLateload = late;
    return APLRes_Success;
}

public OnPluginStart()
{
    if (g_bLateload)
    {
        for (new client = 1; client <= MaxClients; client++)
        {
            if (IsClientInGame(client))
            {
                OnClientPutInServer(client);
            }
        }
    }
}

... 


[Chaosxk]

Might need to validate the attacker, try this.

Edit:Actually NVM, you never used attacker...

Try to do a full map refresh, and do what mcpan says about late loading the plugin.

[Marcus101RR]

Tried it all, does not work, I read somewhere that this SDKHook does not work in L4D(2) games? true?

[thetwistedpanda]

Have you checked if it's firing at all?

[Silvers]

Works fine... view any of my plugins for examples.

Edit: Maybe update, SM/MM I heard some people had issues (in L4D2) where SDKHooks would not fire certain functions at all, until they updated.

[Marcus101RR]

Originally Posted by thetwistedpanda Have you checked if it's firing at all?

It is firing, but 0 damage.

Originally Posted by Silvers Works fine... view any of my plugins for examples. Edit: Maybe update, SM/MM I heard some people had issues (in L4D2) where SDKHooks would not fire certain functions at all, until they updated.

I checked, I am using 1.5 stable. I get 0 damage, but its suppose damage half.

[Skyy]

It works in L4D(2). I used it extensively in the skyrpg series, as well as in damage reflect plugins! If it didn't, setting damage to 0 and returning Plugin_Changed would have done nothing =)

[Marcus101RR]

Originally Posted by Skyy It works in L4D(2). I used it extensively in the skyrpg series, as well as in damage reflect plugins! If it didn't, setting damage to 0 and returning Plugin_Changed would have done nothing =)

I didn't set it to 0, I set it to half damage. As you can see below, there are no mistakes, yet in game, I am in godmode.

PHP Code:

public OnClientPutInServer(client) 
{ 
    SDKHook(client, SDKHook_OnTakeDamage, OnTakeDamage); 
} 

public Action:OnTakeDamage(victim, &attacker, &inflictor, &Float:damage, &damagetype) 
{ 
    decl String:z_difficulty[16]; 
    GetConVarString(FindConVar("z_difficulty"), z_difficulty, sizeof(z_difficulty)); 

    if(StrEqual(z_difficulty, "Impossible", false) && GetClientTeam(victim) == 2) 
    { 
        PrintToChat(victim, "Damage: %f, New: %f", damage, damage*0.5); 
        damage = damage * 0.5; 
        return Plugin_Changed; 
    } 
    return Plugin_Changed; 
} 


[thetwistedpanda]

First off, you should really cache the value of z_difficulty and hook it for changes and use the result within the call; forcing it to find the convar then get the value every time damage is taken is bad. Second, you're returning Plugin_Changed even if no changes are made; should consider changing that to Plugin_Continue. SDKHooks also has an updated prototype for OnTakeDamage depending on what version you're using, so may want to grab the latest (although it likely wouldn't resolve the issue). I assume the PrintToChat is firing?