[AllMassive]

the amxmodx-package contains includes for compiling under the /scripting-folder.
Latest reapi-*.inc's of 'cssdk/hlsdk_const.inc' differ from the recent amxx 1.9.x-inc's.
Inside these 'amxx inc's' was a comment saying: copied parts from reapi.
so i copied the lastest 5229 inc's after copying latest reapi.
but afterwards 'reapi-amxx-plugin' didnt work as designed and i needed to replace 'cssdk/hlsdk_const.inc' with from the reapi-version to let it work again.

[JusTGo]

AFAIK there is no difference between reapi hlsdk_const.inc and amxmodx hlsdk_const.inc

[Arkshine]

Before it was the same file (originally they tried to change few things, but they reverted to the original file), after AMXX build 5223, new constants have been added, but no changes for the existing constants.

@AllMassive what do you mean by "'reapi-amxx-plugin' didn't work as designed"? Are you saying it doesn't compile?

[AllMassive]

It did compile, but didnt work correctly afterwards.
The plugin was

[ReAPI] AdminFreeLook", "1.0"

After compiling with the mentioned newest amxx-inc's the admins were not able to watch both teams when 'mp_forcecamera 2' is enabled. Switching back to the ones from reapi and recompiling it worked again.

[Arkshine]

I'm not sure how it's possible. It seems totally unrelated. The amxx file contains only new constants: https://github.com/alliedmodders/amx...17df655059a338

Can you post this plugin?

[AllMassive]

here it is:

#include <amxmodx>
#include <reapi>

const ACCESS_FLAG = ADMIN_BAN;

public plugin_init()
{
	register_plugin("[ReAPI] AdminFreeLook", "1.0", "ReHLDS Team");

	if(!is_regamedll()) {
		set_fail_state("ReGameDLL is not available");
		return;
	}

	RegisterHookChain(RG_GetForceCamera, "GetForceCamera");
	RegisterHookChain(RG_CBasePlayer_Observer_IsValidTarget, "Observer_IsValidTarget");
}

public GetForceCamera(const index)
{
	if (!shouldRunCode())
		return HC_CONTINUE;
	
	if (canFreeLook(index)) {
		SetHookChainReturn(ATYPE_INTEGER, 0);
		return HC_SUPERCEDE;
	}

	return HC_CONTINUE;
}

public Observer_IsValidTarget(const this, const iPlayerIndex, bool:bSameTeam)
{
	if (shouldRunCode())
		return HC_CONTINUE;

	if (!is_user_connected(iPlayerIndex))
		return HC_CONTINUE;

	if (iPlayerIndex == this || get_entvar(iPlayerIndex, var_iuser1) > 0 || (get_entvar(iPlayerIndex, var_effects) & EF_NODRAW) || get_member(iPlayerIndex, m_iTeam) == TEAM_UNASSIGNED)
		return HC_CONTINUE;

	// Don't spec observers or players who haven't picked a class yet
	if (bSameTeam && get_member(iPlayerIndex, m_iTeam) != get_member(this, m_iTeam))
		return HC_CONTINUE;

	if (canFreeLook(iPlayerIndex)) {
		SetHookChainReturn(ATYPE_INTEGER, iPlayerIndex);
		return HC_SUPERCEDE;
	}

	return HC_CONTINUE;
}

stock bool:canFreeLook(const index) {
	return bool:(get_user_flags(index) & ACCESS_FLAG);
}

stock bool:shouldRunCode()
{
	return bool:(Float:get_member_game(m_flFadeToBlackValue) <= 0.0
		&& Float:get_member_game(m_flForceCameraValue) > 0.0
		&& Float:get_member_game(m_flForceChaseCamValue) > 0.0);
}

[Arkshine]

As you can see yourself in the link, not a single new constants are used in the plugin, nor existing constants are modified.

The only existing you"re using is EF_NODRAW, and you can see the value is the same.

Unless I'm missing something, this can't be the reason.

[AllMassive]

Strange - so it didnt update the *.inc before :/

sry....