[Bladesmc]

So I'm trying to open a file in sourcepawn, it's just a txt file, and I'm going to store some IDs and values next to them, but for some reason the file returns an error when I try to open it. I think something is wrong with when I try to define the handle? Everything compiles fine, no warnings or errors, but when I try to actually call the code it suicides...

The troublesome code:

PHP Code:

public bool StoreElo(int client, int value) {
    int ClientSteamID = GetSteamAccountID(client, true);
    char id[64];
    char line[64];
    char data[64];
    char elo[64];
    Handle datafile;
    
    if(ClientSteamID == 0) {
        return false;
    }
    
    IntToString(ClientSteamID, id, sizeof(id));
    
    BuildPath(Path_SM, filepath, sizeof(filepath), "data\elo.txt");
    datafile = OpenFile(filepath, "r+");
    while(!IsEndOfFile(datafile) && ReadFileLine(datafile, line, sizeof(line))) {
        if(StrContains(line, id, false)) {
            //Do stuff
            
            CloseHandle(datafile);
            return true;
        }
    }
} 


The error msg:

L 02/07/2018 - 16:38:09: [SM] Exception reported: invalid handle 0 (error: 4)
L 02/07/2018 - 16:38:09: [SM] Blaming: basic-elo.smx
L 02/07/2018 - 16:38:09: [SM] Call stack trace:
L 02/07/2018 - 16:38:09: [SM]   [0] IsEndOfFile

[xerox8521]

Are you running on Windows ? then you might need to escape \ aka data\\elo.txt. Not sure if /data/elo.txt works on windows.
Also you should always verify that the handle you receive is not null or INVALID_HANDLE.

[cravenge]

Your code is closing the handle while reading each line of the file. Hence why it throws that error.

I suggest moving "CloseHandle(datafile);" at the bottom and add a bool to help you confirm if the "StrContains" part returns either -1 or something else.

[hmmmmm]

Originally Posted by cravenge Your code is closing the handle while reading each line of the file. Hence why it throws that error. I suggest moving "CloseHandle(datafile);" at the bottom and add a bool to help you confirm if the "StrContains" part returns either -1 or something else.

Doubt that's why, he returns out of the function as soon as the handle is closed.
My guess would be that the file/path you're trying to open isn't valid.

I'm not sure if this could cause it but you should try escaping the escape character:
"data\elo.txt" -> "data\\elo.txt"

Basically what xerox said

[cravenge]

Use backslashes, not forward ones.

[CrazyHackGUT]

This code should work properly on Windows, Linux and MacOS.

PHP Code:

public bool StoreElo(int client, int value) {
    int ClientSteamID = GetSteamAccountID(client, true);
    char id[64];
    char line[64];
    char data[64];
    char elo[64];
    Handle datafile;
    
    if(ClientSteamID == 0) {
        return false;
    }
    
    IntToString(ClientSteamID, id, sizeof(id));
    
    BuildPath(Path_SM, filepath, sizeof(filepath), "data/elo.txt");
    datafile = OpenFile(filepath, "r+");
    if (!datafile) {
        return false;
    }

    while(!IsEndOfFile(datafile) && ReadFileLine(datafile, line, sizeof(line))) {
        if(StrContains(line, id, false)) {
            //Do stuff
            
            CloseHandle(datafile);
            return true;
        }
    }

    CloseHandle(datafile);
    return false;
}