[Arkshine]

That's the purpose of AddToPlayer, it's called when an item is added to the player's inventory, whatever where it comes.

[Nextra]

When I tried something similar I ended up using Ham_Item_AttachToPlayer. You may want to experiment with both of them, I'm not sure if there was an issue with AddToPlayer that made me use AttachToPlayer.

To detect when something was removed from the players Inventory I used Ham_RemovePlayerItem and Ham_Use for the player_weaponstrip entity.

[Arkshine]

AttachToPlayer is just called after but there is no reason AddToPlayer would not work.

When you look at the code, you have generally such code :

PHP Code:

    if (pOther->AddPlayerItem( this ))
    {
        AttachToPlayer( pPlayer );
        //
    } 


And AddPlayerItem :

PHP Code:

BOOL CBasePlayer::AddPlayerItem( CBasePlayerItem *pItem )
{
    CBasePlayerItem *pInsert;

    pInsert = m_rgpPlayerItems[ pItem->iItemSlot() ];

    while( pInsert )
    {
        if( FClassnameIs( pInsert->pev, STRING( pItem->pev->classname ) ) )
        {
            if( pItem->AddDuplicate( pInsert ) )
            {
                g_pGameRules->PlayerGotWeapon( this, pItem );
                pItem->CheckRespawn();

                // ugly hack to update clip w/o an update clip message
                pInsert->UpdateItemInfo( );

                if( m_pActiveItem )
                    m_pActiveItem->UpdateItemInfo();

                pItem->Kill( );
            }
            else if( gEvilImpulse101 )
            {
                // FIXME: remove anyway for deathmatch testing
                pItem->Kill();
            }
            return FALSE;
        }

        pInsert = pInsert->m_pNext;
    }

    if( pItem->AddToPlayer( this ) )
    {
        g_pGameRules->PlayerGotWeapon( this, pItem );

        if( pItem->iItemSlot() == ItemSlot_Primary )
        {
            m_fHasPrimaryWeapon = TRUE;
        }

        pItem->CheckRespawn();

        pItem->m_pNext = m_rgpPlayerItems[ pItem->iItemSlot() ];
        m_rgpPlayerItems [pItem->iItemSlot() ] = pItem;

        if( HasShield() )
        {
            pev->gamestate = 0;
        }

        // should we switch to this item?
        if( g_pGameRules->FShouldSwitchWeapon( this, pItem ) && !IsProtectedByShield() )
        {
            SwitchWeapon( pItem );
        }

        return TRUE;
    }
    else if( gEvilImpulse101 )
    {
        // FIXME: remove anyway for deathmatch testing
        pItem->Kill();
    }
    return FALSE;
} 


So, hooking AddToPlayer as post, is the same level as PlayerGotWeapon, and it would hard to think there is some issue at this time.
About grenade removed, it's a good point, I thought later ; it's true some plugin could remove silently a grenade and these forwards are appropriate.

[Nextra]

Ah yes I see. Maybe I didn't register AddToPlayer as post and ran into issues then, but I dont really know anymore. AttachToPlayer will probably work both as pre and post hook.

[Exolent[jNr]]

Nice to see this worked on again. Very nice work, Ava.

[XxAvalanchexX]

Originally Posted by Arkshine That's the purpose of AddToPlayer, it's called when an item is added to the player's inventory, whatever where it comes.

I agree. I'm thinking AddToPlayer will probably be called whether you pick up a grenade from armoury_entity or you buy one. But that has to do with whether or not I have a frost grenade, as opposed to whether or not I have it selected.

To detect whether or not it's selected, you recommended I use Deploy and Holster. So, the issue is that Deploy isn't called when you switch to a grenade via cl_autowepswitch after picking it up from an armoury_entity (at least, it wasn't in my testing). So, that means a player could switch to a frost grenade without it being detected by Deploy. Does that make sense?

So I'm thinking the workaround would be to also check whether or not the frost grenade is selected in AddToPlayer or AttachToPlayer, assuming that the player's new weapon is updated at that point? UPDATE: See this post about Deploy and cl_autowepswitch.

Thanks,

Ava

[Nextra]

Oh wow, buying a second flashbang really called the AddDuplicate forward? I must have overlooked that forward. When I wrote my plugin I used Ham_Item_UpdateItemInfo to detect when a second flashbang was bought.

[XxAvalanchexX]

Sorry about what I said earlier--it looks like Deploy actually _is_ called when switching to a new weapon via cl_autowepswitch. However, the pev->owner field is not updated at that point in that case, even as a post hook, so I'm not sure how to detect which player is deploying the weapon (is there some pdata field in the weapon which might be updated?).

Originally Posted by Nextra Oh wow, buying a second flashbang really called the AddDuplicate forward? I must have overlooked that forward. When I wrote my plugin I used Ham_Item_UpdateItemInfo to detect when a second flashbang was bought.

Yes, but it looks like the pev->owner field is not updated at that point, even as a post hook. However, one of the arguments is the entity index of the weapon of that type which the player already owns, so you can check that entity's owner. (UPDATE: It looks like AddDuplicate is also called when picking up a 2nd flashbang via armoury_entity, although the pev->owner field still isn't set.)

I also found that if a player already has a flashbang, giving them another with give_item does not call AddToPlayer, AttachToPlayer, AddDuplicate, UpdateItemInfo, AddWeapon, or GiveAmmo, which is troubling, ha. (Whereas actually buying one seems to call AddDuplicate and UpdateItemInfo.) UPDATE: I may've actually been calling cs_set_user_bpammo instead of give_item in this case, which would explain this.

Ava

[Arkshine]

Sorry about what I said earlier--it looks like Deploy actually _is_ called when switching to a new weapon via cl_autowepswitch. However, the pev->owner field is not updated at that point in that case, even as a post hook, so I'm not sure how to detect which player is deploying the weapon (is there some pdata field in the weapon which might be updated?).

Yes, pev_owner is not updated yet only in the situation where the weapon is switched to the new weapon. pev_owner is set in AttachToPlayer. You have to use m_pPlayer which is set in AddToPlayer
To understand more easily :

AddPlayerItem -> AddToPlayer (m_pPlayer) -> [ FShouldSwitchWeapon ? -> SwitchWeapon -> Deploy ] -> AttachToPlayer (pev_owner).

When you get a new weapon and you switch to this one, pev_owner will be updated after.
Therefore, simply use the weapon offset m_pPlayer ( 41, get_pdata_cbase( weaponIndex, m_pPlayer, 4 ) ).

EDIT: Wait lol, AddToPlayer, the player's index is already passed in the header, no need to use m_pPayer.

I also found that if a player already has a flashbang, giving them another with give_item does not call AddToPlayer, AttachToPlayer, AddDuplicate, UpdateItemInfo, AddWeapon, or GiveAmmo, which is troubling, ha. (Whereas actually buying one seems to call AddDuplicate and UpdateItemInfo.)

Test again ? ; that's not possible that at least one of these are not called. Anyway, you don't need that for your plugin.

[kramesa]

omfg, some updated