Raised This Month: $32 Target: $400
 8% 

CSS BRush


  
 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
RedSword
SourceMod Plugin Approver
Join Date: Mar 2006
Location: Quebec, Canada
Old 01-05-2013 , 01:15   Re: CSS BRush
Reply With Quote #11

Hi there,

Some things should be changed for approval :
  • You shouldn't duplicate your code. You're killing timers in two different ways (code consistency; L562 versus stock in L1516)
  • Only one of your timer that is using a client Id is safe. The rest is unsafe way (i.e. DisplayMenu to a client not in game ).

Beside that, you should remove FCVAR_REPLICATED from version ConVar, as well as FCVAR_NOTIFY from NON-version convar. A post from Peace-Maker explaining why.

Code:
CloseHandle(hRandom);
CloseHandle on ConVar's handle is useless and fails silently (asherkin @ irc).

Code:
MenuTime = (3 + FreezeTime) / 2; //L1610
MenuTime = (4 + FreezeTime) / 2; //L253
Is this really wanted ?

Code:
// KyleS HATES Handles
Good thing ;).

Otherwise, seems alright.
__________________
My plugins :
Red Maze
Afk Bomb
RAWR (per player/rounds Awp Restrict.)
Kill Assist
Be Medic

You can also Donate if you appreciate my work

Last edited by RedSword; 01-05-2013 at 19:35.
RedSword is offline
 


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 17:17.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode