[Powerlord]

CTFReviveMarker has some interesting functions on it... if you had signatures for them, you could call them; none of the class-specific functions are in the vtable so offsets don't apply.

Interesting ones being CTFReviveMarker::Create(CTFPlayer *) (likely a static function) and CTFReviveMarker::IsReviveInProgress(void) to name two (the first would simplify the setup of the marker, the second could check if the player was being revived.)

[lyric]

im not sure if this is intended but all classes can see the Revive icon thingy that is for Medics only, i dont know the name of it but with so many killings going on for everyone to see the icon thingy makes for messy. is there a way to restrict those callouts for reviving only for Medics?

[Wolvan]

Originally Posted by lyric im not sure if this is intended but all classes can see the Revive icon thingy that is for Medics only, i dont know the name of it but with so many killings going on for everyone to see the icon thingy makes for messy. is there a way to restrict those callouts for reviving only for Medics?

I will look into that, not sure if I'll be able to fix it though. I'll try my best either way!

[Mitchell]

why aren't you using the revive marker's skin, but instead setting the render color?
and what the heck is this "dummyFunction" that takes in the version convar, and does nothing with it?
Theres also that bulky if statement, what I would do is something like this:

PHP Code:

SetEntProp(reviveMarker, Prop_Send, "m_nBody", (class == TFClass_Scout) ? CLASS_SCOUT : class-1); 


Since TFClassType matches nearly what your defines are then you could just do some simple math, instead of doing a bunch of branches, and just have one little in-line check to see if it is a scout, and return a different number.

Also, you seem to use GetClientTeam 3 times, why not just set a variable then?

By all means these are just suggestions i'm not trying to insult you by anyway, it was just a very short plugin and it looked interesting.

[Wolvan]

Originally Posted by Mitchell why aren't you using the revive marker's skin, but instead setting the render color?

Because I was not aware of the fact that the Revive Marker has multiple skins, I tried setting m_nSkin to different values but it it was always a red marker

[Mitchell]

Originally Posted by Wolvan Because I was not aware of the fact that the Revive Marker has multiple skins, I tried setting m_nSkin to different values but it it was always a red marker

Maybe im wrong on this, since it was for MvM they probably didn't bother setting it.

[Wolvan]

Originally Posted by Mitchell Maybe im wrong on this, since it was for MvM they probably didn't bother setting it.

That's exactly the reason why I used the render color as a way around it. It just has to be clear which team the marker belongs to in my opinion

Originally Posted by pheadxdll I've had the reanimators in Stop that Tank for awhile now and in the war & love update Valve removed a check so medics can heal them without being in MvM and they did the same for the cancel hud for anyone wondering. You don't have to use a detour to stop the player from respawning, just use this code whenever you create the entity_revive_marker: SetEntDataEnt2(client, FindSendPropInfo("CTFPlayer", "m_nForcedSkin")+4, iMarker); There are more problems with the shields like the marker bubble showing for everyone on the server and an instant revive bug Valve hasn't fixed. When I release it someone can use my fixes it if it'll help.

Thank you a lot! It worked perfectly, the respawn time is now being overriden when you get healed. Lots of thank you!

[Mitchell]

Wolvan, i added a few more points to this post above: https://forums.alliedmods.net/showpo...8&postcount=14

[pheadxdll]

SetEntProp(iMarker, Prop_Send, "m_nBody", _:TF2_GetPlayerClass(client)-1);

cheers!

[Wolvan]

Originally Posted by Mitchell why aren't you using the revive marker's skin, but instead setting the render color? and what the heck is this "dummyFunction" that takes in the version convar, and does nothing with it? Theres also that bulky if statement, what I would do is something like this: PHP Code: SetEntProp(reviveMarker, Prop_Send, "m_nBody", (class == TFClass_Scout) ? CLASS_SCOUT : class-1);  Since TFClassType matches nearly what your defines are then you could just do some simple math, instead of doing a bunch of branches, and just have one little in-line check to see if it is a scout, and return a different number. Also, you seem to use GetClientTeam 3 times, why not just set a variable then? By all means these are just suggestions i'm not trying to insult you by anyway, it was just a very short plugin and it looked interesting.

I honestly don't mind suggestions, quite the opposite! I am happy people take their time to help me get better at SourceModding! This is my first plugin after all.

The dummy function is just there so that the compiler won't throw the warning that the ConVar is never used.
I did GetClientTeam that often because I honestly, wrote the plugin on the fly and didn't think about that, will change it though!
About the Bulky if-Statement.... that is because the m_nBody Values are, at least in my opinion, arranged super weird, you can check the values out at the top where I define all these CLASS_ variables. I might change it to an array that contains the right integer based on the class ID