[Powerlord]

Originally Posted by clutchh This has been causing a lot of crashes on our servers, which sucks since this is such a great plugin. The crashes always happen after the vote is completed. No error logs and the only dump that gave any good info pointed to builtinvotes.ext.2.ep2v.dll I believe. I'm hoping you can figure out the issue, as we want to keep running it. Thanks!

Is it immediately after the vote completes, or is something else going on in between?

Originally Posted by cool_myll Yeah i reported crashes to on the UMC plugin. I think it has to do with the extension.

More details would be helpful. To be honest, we should probably be having this conversation on the extension thread, but...

[clutchh]

From what I heard, it happens right after the vote completes.

[Powerlord]

I uploaded BuiltinVotes 0.5.1, but I haven't had a chance to test it.

I made some changes that should fix some memory leaks [and hopefully crashing issues] related to the revote action and the extension being unloaded.

[Powerlord]

BuiltinVotes version 0.5.4 has been released. This release should fix bugs with changing levels during a vote crashing the server (0.5.2) as well as incorrectly blocking votes if the map was changed during a vote (0.5.3) and informing the plugin that the vote was canceled and ended if the map was changed during a vote, allowing the calling plugin to properly clean up its vote handles (0.5.4).

It also fixes a minor issue where disconnecting players were still been counted for purposes of ending the vote. In layman's terms, if someone disconnects during a vote, the vote should now properly end when everyone else has voted.

[Powerlord]

BuiltinVotes has had some additional issues we're working on resolving. If you're still using 0.5.1, you may want to hold off on updating until we get them sorted... although so far, it looks like 0.5.6 has fixed some of the crashing issues, at the expense of not allowing a second vote if the first was canceled. (0.5.7 was just released, but is untested. It's supposed to fix this and some revote issues).

[MON@H Rasta]

Added this plugin + MapChooser Extended, but the voting don't start at all. Could you, plz, help me to understand why?

[SM] Listing 21 plugins:
  01 "Admin File Reader" (1.4.6) by AlliedModders LLC
  02 "Admin Help" (1.4.6) by AlliedModders LLC
  03 "Admin Menu" (1.4.6) by AlliedModders LLC
  04 "Anti-Flood" (1.4.6) by AlliedModders LLC
  05 "Basic Ban Commands" (1.4.6) by AlliedModders LLC
  06 "Basic Chat" (1.4.6) by AlliedModders LLC
  07 "Basic Comm Control" (1.4.6) by AlliedModders LLC
  08 "Basic Commands" (1.4.6) by AlliedModders LLC
  09 "Basic Info Triggers" (1.4.6) by AlliedModders LLC
  10 "Basic Votes" (1.4.6) by AlliedModders LLC
  11 "BuiltinVotes MapChooser" (1.4.0.1) by AlliedModders LLC, Powerlord
  12 "BuiltinVotes Revote" (1.0) by Powerlord
  13 "Client Preferences" (1.4.6) by AlliedModders LLC
  14 "Fun Votes" (1.4.6) by AlliedModders LLC
  15 "HLstatsX CE Ingame Plugin" (1.6.18) by psychonic
  16 "Nextmap" (1.4.6) by AlliedModders LLC
  17 "Map Nominations" (1.4.6) by AlliedModders LLC
  18 "Player Commands" (1.4.6) by AlliedModders LLC
  19 "Reserved Slots" (1.4.6) by AlliedModders LLC
  20 "Sound Commands" (1.4.6) by AlliedModders LLC
  21 "SuperLogs: TF2" (2.0.32) by Thomas "CmptrWz" Berezansky & psychonic

UPD. Sorry. Everything works great. Thanks! ^)

[KyleS]

Hi Powerlord,

It appears that you haven't set FCVAR_NOTIFY on your version convar (the only required flag ). What's the max length for a map? It looks like you're mixing 32, 33, 64, etc for your map buffer :s

Besides some scary things

PHP Code:

                    while (strcmp(map, VOTE_EXTEND, false) == 0)
                    {
                        item = GetRandomInt(0, count - 1);
                        GetBuiltinVoteItem(menu, item, map, sizeof(map));
                    } 


Looks good!

[Powerlord]

Originally Posted by KyleS Hi Powerlord, It appears that you haven't set FCVAR_NOTIFY on your version convar (the only required flag ).

Whoops, I probably forgot about it.

Originally Posted by KyleS What's the max length for a map? It looks like you're mixing 32, 33, 64, etc for your map buffer :s

95% of the code from this plugin is from SourceMod's MapChooser, version 1.4.0 as I recall. Not surprisingly, it has all the quirks of MapChooser, such as map strings being different sizes in different spots in the code. In 1.4.6, the sizes are:
32 on lines 248, 573, 686, 813, and 875,
33 on lines 108. 267, 932, 962, 999, 1043, 1101, and 1120.
64 on lines 287 and 797.

Originally Posted by KyleS Besides some scary things PHP Code:                     while (strcmp(map, VOTE_EXTEND, false) == 0)                     {                         item = GetRandomInt(0, count - 1);                         GetBuiltinVoteItem(menu, item, map, sizeof(map));                     }  Looks good!

This block is lifted directly from mapchooser.sp, lines 822-826 in 1.4.6's copy:

PHP Code:

                while (strcmp(map, VOTE_EXTEND, false) == 0)
                {
                    item = GetRandomInt(0, count - 1);
                    GetMenuItem(menu, item, map, sizeof(map));
                } 


The only thing that changed was the function it was calling.

[AeroAcrobat]

edit2: everything working again, thank you very much!
edit: I see: https://forums.alliedmods.net/showth...162164&page=24
server are crashing also for me :c
Linux, TF2.
I was running xxx42 SM dev. an no prob.

updated today to latest dev. of SM
getting error:

Spoiler

L 01/29/2013 - 09:11:00: [SM] Displaying call stack trace for plugin "builtinvotes_mapchooser.smx":
L 01/29/2013 - 09:11:00: [SM]   [0]  Line 287, D:\tf2server\sourcemod-1.4.0-windows\addons\sourcemod\scripting\include\halflife.inc::PrintToChatAll()
L 01/29/2013 - 09:11:00: [SM]   [1]  Line 684, D:\tf2server\plugins\builtinvotes_mapchooser\builtinvotes_mapchooser.sp::InitiateVote()
L 01/29/2013 - 09:11:00: [SM]   [2]  Line 367, D:\tf2server\plugins\builtinvotes_mapchooser\builtinvotes_mapchooser.sp::Timer_StartMapVote()

"BuiltinVotes MapChooser" (1.4.0.1) by AlliedModders LLC, Powerlord

Builtin Votes (0.5.7)

sm version
10:13:51  SourceMod Version Information:
             SourceMod Version: 1.5.0-dev+3761
             SourcePawn Engine: SourcePawn 1.1, jit-x86 (build 1.5.0-dev+3761)
             SourcePawn API: v1 = 4, v2 = 4
             Compiled on: Jan 28 2013 15:33:10
             Build ID: 3761:7381f15e5d53
             http://www.sourcemod.net/

meta version
10:20:54 Metamod:Source version 1.9.2-dev
         Build ID: 807:6fcbd5454095-dev
         Loaded As: Valve Server Plugin
         Compiled on: Dec 23 2012
         Plugin interface version: 15:14
         SourceHook version: 5:5
         http://www.metamodsource.net/