[Dragokas]

Hi,

Ho to make this without errors/warnings ?

(for better formatting purposes), like:

if (!foo(0, a))
if (!foo(1, a))
if (!foo(2, a))
{};

instead of:

if (!foo(0, a))
if (!foo(1, a))
foo(2, a);

[ddhoward]

Not really sure what your question is. Neither of those snippets really make any sense?

[Dragokas]

Sorry, I mean, 1-st snippet cannot be compiled, because:

1.sp(7) : error 036: empty statement

because empty {} is not permitted.

The question is just about convenient code formatting.

Maybe just use dummy:

public OnPluginStart()
{
	int a;

	if (!foo(0, a))
	if (!foo(1, a))
	if (!foo(2, a))
		dummy();
}

bool foo(int p1, int p2)
{
	return (p1 == p2);
}

void dummy() {}

So, maybe language provides simplier walkaround instead of "dummy"?

Well, don't pay attention. Stupid question.

[Neuro Toxin]

public void OnPluginStart()
{
	int a = 0;

	if (!foo(0, a) && !foo(1, a) && !foo(2, a))
		dummy();
}

bool foo(int p1, int p2)
{
	return (p1 == p2);
}

stock void dummy()
{
	// code
}

[klippy]

You don't even need the if statements.

public void OnPluginStart()
{
    int a = 0;
    !foo(0, a) &&
    !foo(1, a) &&
    !foo(2, a);
}

[MasterMind420]

U can have empty if statements...i use them when needed...im betting the semicolon at the end is causing your error...like if this statement true...dont do anything...but if its giving u issues. Just put a return in the empty statement?

[Mitchell]

Empty statements is just bad design. Pretty much any language that has a findbugs type plugin will see it as a bad conventions.

[MasterMind420]

Originally Posted by Mitchell Empty statements is just bad design. Pretty much any language that has a findbugs type plugin will see it as a bad conventions.

Empty statements have there uses...not sure why everyone is using && either...

if(!foo(0, a) || !foo(1, a) || !foo(2, a))
{

}

this should compile fine...

[Powerlord]

Originally Posted by MasterMind420 Empty statements have there uses...

They really don't, after all, they're empty.

There's a difference between empty statements and statements intentionally designed to take up processor cycles without doing anything... and even those are indicative of bad design.

[MasterMind420]

Originally Posted by Powerlord They really don't, after all, they're empty. There's a difference between empty statements and statements intentionally designed to take up processor cycles without doing anything... and even those are indicative of bad design.

All i see it affecting is readability...thats it...wether u do it one way or the other effects absolutely nothing else. I'm not arguing its not better to avoid empty if statements. I'm just saying they work the same regardless...if there's an else after...just an if statement is pointless and wont do anything. i'm not even really sure what this guys trying to do.