[Solved] Ban players if disconnect - Page 3

**Bugsy** · 07-08-2015 , 07:44 Re: Ban if no return in 5 minutes.

Yes, disconnect reason can detect if user was kicked and yes to FLAG A immunity.

**Bugsy** · 07-08-2015 , 18:27 Re: Ban if no return in 5 minutes.

Updated code to obey immunity and added disconnect reason check so it will only react when the client manually disconnected.

4ever16 · *Last edited by 4ever16; 07-09-2015 at 06:12.*

Good that i saved the last code u posted.
I really dont want to many plugins on the server and specielly those with alot of messages.

So i solved my problem here: https://forums.alliedmods.net/showthread.php?t=265946

But still i would like flag a immunity in the last code u wrote.
This one.

Code:

#include <amxmodx>
#include <engine>
#include <celltravtrie>

new const Version[] = "0.1";

const Float:EntityTimerInterval = 10.0; 
const MAX_PLAYERS = 32;

enum _:PlayerData
{
    AuthID[ 34 ],
    DisconnectTime
}

new TravTrie:ttTrie , g_pdData[ MAX_PLAYERS + 1 ][ PlayerData ];
new g_Entity , g_pBanLeavers , g_pReconnectMinutes , g_pBanMinutes;

public plugin_init() 
{
    register_plugin( "Ban If No Return" , Version , "bugsy" );
    
    g_pBanLeavers = register_cvar( "binr_enabled" , "1" );
    g_pReconnectMinutes = register_cvar( "binr_reconnectmin" , "10" );
    g_pBanMinutes = register_cvar( "binr_banmins" , "1200" );
    
    g_Entity = create_entity( "info_target" );
    entity_set_string( g_Entity , EV_SZ_classname , "binr_entity" );
    register_think( "binr_entity" , "EntityThink" );
    entity_set_float( g_Entity , EV_FL_nextthink , ( get_gametime() + EntityTimerInterval ) );
    
    ttTrie = TravTrieCreate();
}

public plugin_end()
{
    call_think( g_Entity );
    TravTrieDestroy( ttTrie );
}

public client_authorized( id )
{
    new pdData[ PlayerData ] , iTrieKey , szKickMessage[ 60 ] , iReconnectMinutes;

    get_user_authid( id , g_pdData[ id ][ AuthID ] , charsmax( g_pdData[][ AuthID ] ) );

    iTrieKey = str_to_num( g_pdData[ id ][ AuthID ][ 10 ] );
    
    if ( TravTrieGetArrayEx( ttTrie , iTrieKey , pdData , sizeof( pdData ) ) && pdData[ DisconnectTime ] )
    {
        iReconnectMinutes = get_pcvar_num( g_pReconnectMinutes );
        
        if ( get_pcvar_num( g_pBanLeavers ) && ( ( get_systime() - pdData[ DisconnectTime ] ) > ( iReconnectMinutes * 60 ) ) )
        {
            formatex( szKickMessage , charsmax( szKickMessage ) , "^nYou have been banned for %d minutes for not re-joining within %d minutes" , get_pcvar_num( g_pBanMinutes ) , iReconnectMinutes );     
            message_begin( MSG_ONE , 2 , {0,0,0} , id );     
            write_string( szKickMessage );     
            message_end();    
    
            BanPlayer( pdData[ AuthID ] );
            
            TravTrieDeleteKeyEx( ttTrie , iTrieKey );
        }
        else
        {
            pdData[ DisconnectTime ] = 0;
            TravTrieSetArrayEx( ttTrie , iTrieKey , pdData , sizeof( pdData ) );
        }
    }
}

public client_disconnect( id )
{
    new szName[ 33 ];
    get_user_name( id , szName , charsmax( szName ) );
    client_print( 0 , print_chat , "* %s left - he has 10 minutes to return or banned gets for 20 hours." , szName , get_pcvar_num( g_pReconnectMinutes ) , get_pcvar_num( g_pBanMinutes ) );
    
    g_pdData[ id ][ DisconnectTime ] = get_systime();
    TravTrieSetArrayEx( ttTrie , str_to_num( g_pdData[ id ][ AuthID ][ 10 ] ) , g_pdData[ id ] , sizeof( g_pdData[] ) );
}

public EntityThink( iEntity )
{
    if( ( iEntity == g_Entity ) && get_pcvar_num( g_pBanLeavers ) ) 
    {
        new travTrieIter:ttIterator , pdData[ PlayerData ] , iTimeLeft , iReconnectMinutes , iSysTime;
        
        ttIterator = GetTravTrieIterator( ttTrie );
        iTimeLeft = get_timeleft();
        iSysTime = get_systime();
        iReconnectMinutes = get_pcvar_num( g_pReconnectMinutes );
        
        while ( MoreTravTrie( ttIterator ) )
        {
            ReadTravTrieArray( ttIterator , pdData , sizeof( pdData ) );
            
            if ( ( iTimeLeft < 30 ) || ( iSysTime - pdData[ DisconnectTime ] ) > ( iReconnectMinutes * 60 ) )
            {
                BanPlayer( pdData[ AuthID ] );
                TravTrieDeleteKeyEx( ttTrie , str_to_num( pdData[ AuthID ][ 10 ] ) );
            }
        }
        
        DestroyTravTrieIterator( ttIterator );
        
        entity_set_float( g_Entity , EV_FL_nextthink , ( get_gametime() + EntityTimerInterval ) );
    }
}
 
public BanPlayer( const szAuthID[] )
{
     server_cmd( "banid %d %s" , get_pcvar_num( g_pBanMinutes ) , szAuthID );
}

4ever16 · *Last edited by 4ever16; 07-09-2015 at 21:29.*

Im wondering how this plugin works.

So we say that plugin is enabled. When i disconnect the plugin counts we say 3 minutes. After 3 minutes it adds a ban on the disconnected steam id right?
But if a map was changed for example and that map doesnt have the plugin enabled the plugin just couldnt count up ti 3 minutes so it didnt ban the player right?

And if plugin was enabled and banned one player.
Mapchange, plugin disabled the player can join again because the plugin is checking all leavers?

And where are the bans stored cause it isnt in banned.cfg

So i ran some tests.
I enabled plugin, disconnected, tried to join again in 4 minutes. Yes i couldnt join cause of the ban.
Change removed the plugin, changed the map thru rcon, tried to join. Yes i couldnt join so everything seems to work.
But still, if i leave the server like 2 minutes before the plugin is disabled (reconnect time is 3 minutes) and tried to join it again i could, cause the plugin didnt count to 3 minutes and banned me yet? Right?

In your code is it importet to change these lines and what those those lines mean?

Quote:

if ( ( iTimeLeft < 30 ) || ( iSysTime - pdData[ DisconnectTime ] ) > ( iReconnectMinutes * 60 ) )

**Bugsy** · 07-09-2015 , 22:42 Re: Ban if no return in 5 minutes.

When the plugin is disabled, it will not do anything. I thought this was common knowledge. Or am I misinterpreting your questions.

Quote:

Originally Posted by 4ever16

And where are the bans stored cause it isnt in banned.cfg

It stores them wherever HLDS stores bans.

Quote:

Originally Posted by 4ever16

In your code is it importet to change these lines and what those those lines mean?

This is to make bans happen if a map change is approaching.
( iTimeLeft < 30 )

This is if the user did not reconnect within the set time.
( iSysTime - pdData[ DisconnectTime ] ) > ( iReconnectMinutes * 60 ) )

4ever16 · *Last edited by 4ever16; 07-10-2015 at 01:42.*

To get it right i need to change like this. I want a ban of 20 hours thats 1200 minutes.
So what values do i need to change if i want no return in 3 minutes and ban 1200 minutes?

**Bugsy** · *Last edited by Bugsy; 07-10-2015 at 06:57.*

binr_reconnectmin 3
binr_banmins 1200

And I'm not sure why bans are not showing in the cfg, I noticed this as well during testing. Maybe search the net for this issue.

**HamletEagle** · 07-10-2015 , 07:00 Re: Ban if no return in 5 minutes.

Quote:

Originally Posted by Bugsy

binr_reconnectmin 3
binr_banmins 1200

And I'm not sure why bans are not showing in the cfg, I noticed this as well during testing. Maybe search the net for this issue.

AFAIK it doesn't show until you close and restart the server. Maybe because the file is open and never closed during run time ?

Mordekay · 07-10-2015 , 09:15 Re: Ban if no return in 5 minutes.

Tempbans are only stored in memory iirc, so they will never be shown anywhere if not stored by amxbans or similar plugins.

**Bugsy** · 07-10-2015 , 09:22 Re: Ban if no return in 5 minutes.

Is banid command considered a tempban? Or are you referring to the duration (time value specified vs permanent)?