[hleV]

Originally Posted by Powerlord It's... not like min or max are difficult functions to write...

Exactly, imagine my surprise when I found out SourceMod doesn't have those. Not necessarily SMLib's fault, I just don't get why wouldn't Math_Min()/Math_Max() work the way I expected them to.

Originally Posted by Powerlord PHP Code: new min = a < b ? a : b; new max = a > b ? a : b;

I don't think writing up such functions in your plugins (or making an .inc) should be something you need to do. Using inline conditionals instead of functions isn't an option neither because a and b may be something that uses functions for calculation, etc. and thus need to be cached (due to being referenced twice in the line), effectively increasing the amount of lines required to perform a simple min()/max() check.

[berni]

I also agree that having functions with good names increases the readability allot, even if it just replaces a 1 line inline-condition.

[friagram]

The ternary operators are way faster than a function call like using math min or whatever the hell you are trying to do..

You don't even make a new var, you use the operator inline, unless you need to use that value later. A and b is a generic expression. You don't assign crap to them.

myhats > yourhats ? myhats : yourhats

And no, having well named functions to replace simple statements is foolish. It just makes code harder to read for experienced coders, because they have to see what your superfluous function is doing (and they need your library). Also, it's slower.

If you want have to use it a ton, and you don't want to keep duplicating code, use the preproccessor, that's what it's for. It's by far better to do a minmax type deal with the preproccessor than a function call.

I could see an exception here, where you have some storage limitation on like a 32k rom or some other tiny solid state device with small memory space or something, where you would need to save every kb. In that case, duplicating code would be bad. Don't see anything like that ever being a problem here. You wouldn't be using a language like this anyway.

[zeroibis]

Yea, I have had to translate 1 line renames a few times and it was always annoying b/c I was just like well you just changed the name of the function and now I got 2 functions with different names that do the same thing.

Readability is about reducing the number of lines of code by creating methods for common operations not by creating a dictionary for the production of Shakespeare.

[rhelgeby]

Avoid doing micro-optimizations if not really necessary. Code readability is important, and it doesn't matter if you're an experienced developer or not.

If you need to check the function's code to understand what it's doing, it's badly named or not doing one thing. Readability is optimal if you can almost read the code as a book. This doesn't mean you should make functions for every "word", but for every logical operation.

The Math_Min and Math_Max should be renamed to have the word "clamp" in them.

[hleV]

Originally Posted by friagram You don't even make a new var, you use the operator inline, unless you need to use that value later. A and b is a generic expression. You don't assign crap to them. If you want have to use it a ton, and you don't want to keep duplicating code, use the preproccessor, that's what it's for. It's by far better to do a minmax type deal with the preproccessor than a function call.

PHP Code:

#define MIN(%1,%2) ((%1) < (%2) ? (%1) : (%2))

min(new x, new y)
{
    return x < y ? x : y;
}

new a = GetX() < GetY() ? GetX() : GetY();
new b = MIN(GetX(), GetY());
new c = min(GetX(), GetY());

GetX()
{
    // Some huge calculation.
}

GetY()
{
    // Some huge calculation.
} 


GetX() or GetY() will need to be called twice when both manually using ternary operator or a macro, but not when using a function, so either I don't understand you or you're wrong.

[friagram]

No

Also, do you think a function call just magically happens?
The subroutine gets called each time, and likely other things happen too in sm
http://en.m.wikipedia.org/wiki/X86_calling_conventions

[hleV]

Using the function, GetX() and GetY() will only be called once and stored to x and y variables respectively.

[berni]

Things I agree on:

• Really basic things like getting the lower value of two vars don't necessarily need a function - yeah
• The functions Math_Min and Math_Max should be renamed - yes, those are not good function names. Function names should always be self-explaining.

Things I don't agree on:

• Not creating functions because they are slower - The advantage of readability (by far!) outreaches the disadvantage of being slower. As long as you don't do calls to native functions, you should never break your head on things like this. I consider myself a performance-nerd, but what's the sense of having super-optimized code, when nobody can read it? Or even the author himself doesn't know anymore after 1 year.
• Functions make code harder to read - No, they don't! They only do if you create bad names for them, like "IsPlayerValid" (and doing checks like IsPlayerAlive() inside). A function for 1 line of code is perfectly valid. In theory, a program where every line of code is inside a function is the easiest to read. In practice nobody likes to create that many functions because it's time consuming.
  

In 10 years of professional programming experience I have learned one thing: Code readability is one of the most important things. Encapsulate your code in functions as much as possible. Write good self-explaining symbol names in camel case. Comment your code.

[rhelgeby]

Wise words.

There is too much focus on performance. If it really is an issue, we can optimize just that code.