[chickez]

Hey.

I'm beginner in scripting.
I want to create cvar, which will change the light.

Example: server_light "b"
Then set_lights is set to "b".

But doesn't work.

PHP Code:

#include <amxmodx>
#include <engine>

#define PLUGIN "serverLight"
#define VERSION "0.1"
#define AUTHOR "chicken"

new lights[2]

public plugin_init() {
    register_plugin(PLUGIN, VERSION, AUTHOR)
    
    register_cvar("server_light", lights)
}

public setServerLights() {
    set_lights(lights)
} 


Any help? Thank you!

[fysiks]

You need to read the cvar at some point and use it when you call set_lights(). When do you want this action to occur?

[supertrio17]

I believe that this is what you want:

PHP Code:

#include <amxmodx>
#include <engine>

#define PLUGIN "serverLight"
#define VERSION "0.2"
#define AUTHOR "chicken"

new g_lights

public plugin_init() {
    register_plugin(PLUGIN, VERSION, AUTHOR)
    
    g_lights = register_cvar( "amxx_lights", "a" ); //default value would be a
    register_event("HLTV", "setServerLights", "a", "1=0", "2=0") //every new round cvar gets updated
}

public setServerLights() 
{
    new lights[2];
    get_pcvar_string(g_lights, lights, 2);
    set_lights(lights);
} 


[chickez]

Yes, that is, what i want.

PHP Code:

new lights[2];
get_pcvar_string(g_lights, lights, 2); 


So, get_pcvar_string works like this ye? I understood this command otherwise.


Thank you for help!

[supertrio17]

Well because it was a letter it needs to have a string, everything you want to know is here.

[HamletEagle]

Originally Posted by chickez Yes, that is, what i want. PHP Code: new lights[2]; get_pcvar_string(g_lights, lights, 2);  So, get_pcvar_string works like this ye? I understood this command otherwise. Thank you for help!

This looks like a potential buffer overflow. Use charsmax to ensure the proper size is passed and to avoid hardcoding.

[fysiks]

Originally Posted by supertrio17 I believe that this is what you want: PHP Code: #include <amxmodx> #include <engine> #define PLUGIN "serverLight" #define VERSION "0.2" #define AUTHOR "chicken" new g_lights public plugin_init() {     register_plugin(PLUGIN, VERSION, AUTHOR)          g_lights = register_cvar( "amxx_lights", "a" ); //default value would be a     register_event("HLTV", "setServerLights", "a", "1=0", "2=0") //every new round cvar gets updated } public setServerLights()  {     new lights[2];     get_pcvar_string(g_lights, lights, 2);     set_lights(lights); }

You'll need to learn how strings work in Pawn.

[Natsheh]

Which amxx version are you using ?

If you're using amxx version 183 or latter which most recommended vers is the latest you can hook cvar change and change the lights instantly rather than waiting for round HLTV event to be called.

[HamletEagle]

Originally Posted by Natsheh Which amxx version are you using ? If you're using amxx version 183 or latter which most recommended vers is the latest you can hook cvar change and change the lights instantly rather than waiting for round HLTV event to be called.

The latest version is 1.8.2

[chickez]

Ye, it's 1.8.2, the latest.

Originally Posted by HamletEagle This looks like a potential buffer overflow. Use charsmax to ensure the proper size is passed and to avoid hardcoding.

Charsmax inside the get_pcvar_string()?

PHP Code:

public setServerLights() 
{
    new lights[];
    get_pcvar_string(g_lights, lights, charsmax(2));
    set_lights(lights);
} 


Can I write it like this?