Hey there. Thanks for taking a look at the code and offering some fixes. I do appreciate that. However, I am leaving the SR project, and someone should be taking over coding up the plugin in the near future. Hopefully they add some of these fixes in. I will try to explain just a couple that had a specific reasoning.
Quote:
Originally Posted by Dr. McKay
- StartsWithScammer is unnecessary, just check if StrContains(str, "[SCAMMER]") == 0.
- ServerCommand("sm_ban . . .
- Lines 163, 168, and 169
- ServerCommand is evil and should be avoided whenever possible. SourceBans has a native that can be used.
|
StartsWithScammer was added because of RTL languages. Some people would get away with renaming the tag away if they used RTL to get around StrContains.
I might be wrong but when I first coded I searched for a native in SourceBans. I'm glad to see there's one. The intention was to make it compatible with/without SourceBans. I totally agree about ServerCommand and I was quite upset at the time, that I couldn't determine a different solution for it. If it's been there since before I coded this, then I apologize but I had searched for hours and asked many people about it.
Quote:
Originally Posted by Dr. McKay
Also, something that concerned me is that every client's IP address is being sent to steamrep.com (unless the cvar is set to 0). To protect users' privacy, I would recommend only sending SteamRep the IP address if the client is marked as a scammer. (By the way, what exactly does SteamRep do with these IP addresses?)
|
I understand your concern. It was requested from the site that I add this to the plugin for a potentially upcoming feature that would allow a server to check the IP of the connecting user to see if it matches the IP of a 'scammer'. It is still being coded on the backend. I respect people's privacy and I wouldn't add a feature like this without a way of turning it off easily, and the site agreed.
As I stated, I am leaving the SR project, not with bad blood, but IRL is consuming my time. Thanks again for taking a look at the code. I know I am FAR from the best coder, and I appreciate learning from my mistakes.