[ConnorMcLeod]

Last Activity GameTime is stored in a private player offset that is updated each PreThink to the current gametime,
if players button have changed since last frame (button are stored each PostThink in another pdata).
Problem with this is that sometimes the game reset player button, so last activity is updated even if players are AFK.

The first plugin attempts to remove that bug, it makes so pdata is not updated in most situations like descripted above.
2nd plugin updates pdatas when players send a command, because if a player sends a command it means he is not AFK.
3rd plugin check players angles and updates pdatas if angles have changed,
so the pdata only takes in account AFK and not camping.


Related stuff :
To kick a player for idle, you can try this stock (not tested) :

PHP Code:

KickPlayerForIdle(id)
{
#if !defined m_flLastActivityTime
    #define m_flLastActivityTime 124
#endif

#if !defined m_flNextIdleCheckTime
    #define m_flNextIdleCheckTime 190
#endif

#if !defined m_afButtonLast
    #define m_afButtonLast 245
#endif

#if !defined mp_autokick
    static mp_autokick
#endif
    if( !mp_autokick )
    {
        mp_autokick = get_cvar_pointer("mp_autokick")
    }

    new iAutoKick = get_pcvar_num(mp_autokick)

    if( !iAutoKick )
    {
        set_pcvar_num(mp_autokick, 1)
    }

    set_pdata_float(id, m_flLastActivityTime, -9999.9)
    set_pdata_float(id, m_flNextIdleCheckTime, 0.0)
    set_pev(id, pev_button, get_pdata_int(id, m_afButtonLast)
    dllfunc(id, DLLFunc_PlayerPreThink)

    if( !iAutoKick )
    {
        set_pcvar_num(mp_autokick, 0)
    }
} 


Other version :

PHP Code:

KickPlayerForIdle(id)
{
    static __msgTextMsg = 0
    if( !__msgTextMsg )
    {
        __msgTextMsg = get_user_msgid("TextMsg")
    }

    new name[32] ; get_user_name(id, name, charsmax(name))
    
    emessage_begin(MSG_ALL, __msgTextMsg)
    ewrite_byte( print_console )
    ewrite_string( "#Game_idle_kick" )
    ewrite_string( name )
    emessage_end()

    server_cmd("kick ^"%s^"", name)
} 


Note : Max Idle Time allowed to a player is equal to mp_roundtime * 2 and is stored at each new round.
Big thanks to Arkshine who took time to decompile game and answer to specific questions i had.

[ot_207]

Shouldn't this have been posted in new plugins?
Edit: GJ.

[ConnorMcLeod]

I don't think so (Precedent Here), but if it has i would be pleased someone move it there.

[tm.]

In lastactivity_normalizer3.sma if you change MAX_PLAYERS to a value smaller than 32, compiler will return at this line:

get_players(iPlayers, iNum, "ach")

this error:

error 047: array size do not match, or destination array is to small

It seems that get_players requires an array of size 32 to work.

[Arkshine]

You should not modify this value. It's used as reference not as a value you can customize.

[meTaLiCroSS]

Originally Posted by ConnorMcLeod Problem with this is that sometimes the game reset player button, so last activity is updated even if players are AFK.

Can you be more specific please? This is interesting.

[kNowo]

During my debugging, the pdata offset of 124 (m_flLastActivityTime) is set to the time when a player dies because his lastbutton pdata offset (245) is set to IN_SCORE (32768) at that time.

I can think of 2 solutions:
1. hook cmdstart and block the key
2. save the player's last activity time at pre death and set that value at post death

I'm sure they are a few other methods too. What is the best method to fix this bug?

EDIT: Also, it seems that lastactivity_normalizer.sma is not working correctly. Plugin is running but the pdata is still getting updated on death and pre spawn events of an afk player.

[^SmileY]

Originally Posted by kNowo During my debugging, the pdata offset of 124 (m_flLastActivityTime) is set to the time when a player dies because his lastbutton pdata offset (245) is set to IN_SCORE (32768) at that time. I can think of 2 solutions: 1. hook cmdstart and block the key 2. save the player's last activity time at pre death and set that value at post death I'm sure they are a few other methods too. What is the best method to fix this bug? EDIT: Also, it seems that lastactivity_normalizer.sma is not working correctly. Plugin is running but the pdata is still getting updated on death and pre spawn events of an afk player.

omg, it is fixed since last hlds build and this topic is older than 2010.
update your server and use mp_autokick and mp_autokick_timeout vars.

[kNowo]

Originally Posted by ^SmileY omg, it is fixed since last hlds build and this topic is older than 2010. update your server and use mp_autokick and mp_autokick_timeout vars.

Get your facts straight before posting or don't post at all.

[^SmileY]

Why? If you are using a old server the fact is then you need to fix using this tip.
But i assume you are a Non Steammer user for not using a updated server.

Here is the fact!

This is a 2010 article, you should really consider to update you server to correctly use the mp_autokick* vars.