[yash1441]

Originally Posted by Kamizun Created the Database, connected but I can just spam sm_daily and get credits everytime. The plugin created the tables but its not writting down the connected players or who use the commands. There are error logs: [SM] Exception reported: Current result set has no fetched rows [SM] Blaming: dailycredits_mysql2.smx [SM] Call stack trace: [SM] [0] SQL_FetchInt [SM] [1] Line 94, ...\dailycredits_mysql2.sp::GiveCredits [SM] [2] Line 70, ...\dailycredits_mysql2.sp::Cmd_Daily [SM] Exception reported: Current result set has no fetched rows [SM] Blaming: dailycredits_mysql2.smx [SM] Call stack trace: [SM] [0] SQL_FetchInt [SM] [1] Line 95, ...\dailycredits_mysql2.sp::GiveCredits [SM] [2] Line 70, ...\dailycredits_mysql2.sp::Cmd_Daily Add: I did not forget to remove the old one and I did not change any code from the plugin. I changed the name to dailycredits_mysql2 because I already had one on my desktop Thank you for your time

Fixed! Forgot to use the query stored in buffer

[Kamizun]

Still having the same error, tried the one on alliedmods and github. Both are giving me the same error.

[yash1441]

Originally Posted by Kamizun Still having the same error, tried the one on alliedmods and github. Both are giving me the same error.

Try now, it should work. I hope
If it doesn't, does it create rows with the player info now?

[Kamizun]

Originally Posted by yash1441 Try now, it should work. I hope If it doesn't, does it create rows with the player info now?

Having the exact same problem. Tried both, alliedmodders and github. None of them work and none of them create rows with player info.

[yash1441]

Originally Posted by Kamizun Having the exact same problem. Tried both, alliedmodders and github. None of them work and none of them create rows with player info.

Ok, I added threaded queries and some more things.
[SM] [0] SQL_FetchInt shouldn't actually give an error because it should only be reached when the player is not in it's first day.

[Nachtfrische]

Hey, great plugin.

I have one suggestion to make, please add a "UNIQUE" to the steam ID of the CREATE TABLE SQL statement.
Like this:

CREATE TABLE IF NOT EXISTS players (steam_id VARCHAR(20) UNIQUE, last_connect INT(12), bonus_amount INT(12));

You also might want to account for the Steam ID being "STEAM_ID_PENDING" sometimes, so make sure you filter it out somehow.

[yash1441]

Originally Posted by Nachtfrische Hey, great plugin.

Thanks man

Originally Posted by Nachtfrische I have one suggestion to make, please add a "UNIQUE" to the steam ID of the CREATE TABLE SQL statement. Like this: CREATE TABLE IF NOT EXISTS players (steam_id VARCHAR(20) UNIQUE, last_connect INT(12), bonus_amount INT(12));

I'll add this to the next update. Also, just for the knowledge, is there any reason for this because I don't think there is any way for duplicate entries anyways?

Originally Posted by Nachtfrische You also might want to account for the Steam ID being "STEAM_ID_PENDING" sometimes, so make sure you filter it out somehow.

I think that was fixed with Sourcemod 1.8 although I'll add the check if it is really necessary.

[DarkDeviL]

Originally Posted by Nachtfrische You also might want to account for the Steam ID being "STEAM_ID_PENDING" sometimes, so make sure you filter it out somehow.

Don't filter such things, just do things properly:

-> https://github.com/yash1441/DailyCre...s_mysql.sp#L56
-> https://github.com/yash1441/DailyCre...s_mysql.sp#L79

Bad code:

	GetClientAuthId(client, AuthId_Steam2, steamId, sizeof(steamId));
	char buffer[200];
	Format(buffer, sizeof(buffer), "SELECT * FROM players WHERE steam_id = '%s'", steamId);

Good code would be like:

	if (GetClientAuthId(client, AuthId_Steam2, steamId, sizeof(steamId))) {
		/* Do what you want with the Steam ID here */
	}

GetClientAuthId returns TRUE if a proper Steam ID was received, so therefore, put it in a IF to make sure.

Not checking / validating the data you receive properly ... usually leads to strange results.

[yash1441]

Updated with arne1288's suggestion. Also added UNIQUE to steam_id. Thanks!

[Nachtfrische]

Good job!
I've had another idea, could you perhaps add a cvar, which limits the max amount of credits you can recieve?
To elaborate: let's say I start with 10 Credits and I get 5 more credits each day, so 10, 15, 20...
At some point, I will be getting 100, 105, 110 credits each day and that can quickly add up and then be too much to give out.

So if you can make a cvar which you can set to, let's say 50, as soon as you reach 50 credits, the amount you recieve won't increase and you'll be getting 50 credits everyday as long as you keep up your daily streak.

Thanks.