[mottzi]

Hey, I want to check if a String just contains the Letters from the Title.
I tried it with 2 for-loops but that doesnt work and I dont know why.

Here is my Code:

PHP Code:

public is_valid_username(szName[])
{
    new chars[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"
    new validchar = 0
    
    for(new i = 0; i < strlen(szName) - 1; i++)
    {
        validchar = 0
        client_print(0, print_chat, szName[i])
        for(new j = 0; j < strlen(chars) - 1; j++)
        {
            if(equal(szName[i], chars[j]))
            {
                validchar = 1
            }
        }
        if(!validchar)
        {
            return false
        }
    }
    return true
} 


would be great if you could help me.
have a nice day

[RoaR]

I think plugin works but you did not define an action to be done when it doesn't equal that.

What did you want the plugin to do when user doesn't have those characters?

[lucas_7_94]

I'm not sure if you should return inside loop , btw , try testing .

public is_valid_username(szName[])
{
    new chars[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"
    
    new bool:founded = false
    
    for(new i = 0; i < strlen(szName) - 1; i++)
    {
        if( founded ) break;

        client_print(0, print_chat, szName[i])
        for(new j = 0; j < strlen(chars) - 1; j++)
        {
            if(equal(szName[i], chars[j]))
            {
                founded = true
            }
        }
    }
    return founded
}

I don't tested and i'm not sure if this works.

[Exolent[jNr]]

@Everyone
None of those will work. Also, you are overthinking.

public is_valid_username(szName[])
{
    new len = strlen(szName);
    
    for(new i = 0; i < len; i++)
    {
        if(!isalnum(szName[i]))
        {
            return false;
        }
    }
    
    return true;
}

[killergirl]

PHP Code:

#include <amxmisc>

public is_valid_username(szName[])
{
    new chars[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"
    new validchar = 0, pos
    
    for(new i = 0; i < sizeof(chars) - 1; i++){
    pos = containi(szName, chars[i])
    
    if(pos == -1){
        validchar = 1
        break;
    }
    }
    
    if(!validchar)
        return true
    else
        return false
} 


[Exolent[jNr]]

Originally Posted by killergirl PHP Code: #include <amxmisc> public is_valid_username(szName[]) {     new chars[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"     new validchar = 0, pos          for(new i = 0; i < sizeof(chars) - 1; i++){     pos = containi(szName, chars[i])          if(pos == -1){         validchar = 1         break;     }     }          if(!validchar)         return true     else         return false }

That won't work either.

[xPaw]

What about regex?

[Exolent[jNr]]

Originally Posted by xPaw What about regex?

I'm unsure of the efficiency comparisons for RegEx in AMXX, but I feel it would be overkill for such a small check.
If it were to be a more complicated pattern then for sure use RegEx.

[mottzi]

Hey thank you exolent
didnt know there is existing a function like this

could you please explain, why my _solution_ didnt work?

[fysiks]

Originally Posted by mottzi Hey thank you exolent didnt know there is existing a function like this could you please explain, why my _solution_ didnt work?

The logic you have in your function will return true if there is only one valid character.

The other major flaw is using equal() to compare two integers (ascii characters). You can't do that. You just need to compare them directly.