[maningrey]

Hello, I've just made this and the first part of the code works, it detects the first command, yet, the second not so much. I'm not sure why?

new Handle:g_Cvar_EndRestart = INVALID_HANDLE;
new Handle:g_Cvar_ChangeLevel = INVALID_HANDLE;

public OnPluginStart() 
{
	g_Cvar_EndRestart = FindConVar("mp_match_end_restart");
	g_Cvar_ChangeLevel = FindConVar("mp_match_end_changelevel");
	HookConVarChange(g_Cvar_EndRestart, ConVarChange_EndRestart);
	HookConVarChange(g_Cvar_ChangeLevel, ConVarChange_ChangeLevel);
}

public ConVarChange_EndRestart(Handle:convar, const String:oldValue[], const String:newValue[])
{
	if (oldValue[0] == newValue[1])
	{
		ServerCommand("mp_match_end_restart 0");
	}
		
	if (oldValue[1] == newValue[1])
	{
		ServerCommand("mp_match_end_restart 0");
	}
		
	if (oldValue[0] == newValue[0])
	{
		return;
	}
	
	if (oldValue[1] == newValue[0])
	{
		return;
	}
		
}

public ConVarChange_ChangeLevel(Handle:convar, const String:oldValue[], const String:newValue[])
{

	if (oldValue[1] == newValue[0])
	{
		ServerCommand("sm_cvar mp_match_end_changelevel 1");
	}

		
	if (oldValue[0] == newValue[0])
	{
		ServerCommand("sm_cvar mp_match_end_changelevel 1");
	}
	
	if (oldValue[0] == newValue[1])
	{
		return;
	}
	
	if (oldValue[1] == newValue[1])
	{
		return;
	}
	
}

[Impact123]

Your code looks odd, what do you thing this check does?

PHP Code:

if (oldValue[1] == newValue[0]) 


Instead of using ServerCommand you should use this

PHP Code:

SetConVarInt(g_Cvar_EndRestart, 0); 


You also don't need more than one convar hook function.

[maningrey]

Originally Posted by Impact123 Your code looks odd, what do you thing this checks does? PHP Code: if (oldValue[1] == newValue[0])  Instead of using ServerCommand you should use this PHP Code: SetConVarInt(g_Cvar_EndRestart, 0);  You also don't need more than one convar hook function.

This was my bad attempt at getting it to check the old value against the new one, so if a plugin changes it from 0 to 1 it changes it back to 0, ect...

[Impact123]

Well, that's not how strings work, you should read this.
That's one way to do what you want.

Spoiler

PHP Code:

#include <sourcemod>

new Handle:g_Cvar_EndRestart = INVALID_HANDLE;
new Handle:g_Cvar_ChangeLevel = INVALID_HANDLE;

public OnPluginStart() 
{
    g_Cvar_EndRestart = FindConVar("mp_match_end_restart");
    g_Cvar_ChangeLevel = FindConVar("mp_match_end_changelevel");

    HookConVarChange(g_Cvar_EndRestart, ConVarChange_Handler);
    HookConVarChange(g_Cvar_ChangeLevel, ConVarChange_Handler);
}

public ConVarChange_Handler(Handle:convar, const String:oldValue[], const String:newValue[])
{
    if (GetConVarInt(g_Cvar_EndRestart) != 0)
    {
        SetConVarInt(g_Cvar_EndRestart, 0);
    }
    
    if (GetConVarInt(g_Cvar_ChangeLevel) != 1)
    {
        SetConVarInt(g_Cvar_ChangeLevel, 1);
    }
} 


Feel free to ask about the code, but please don't full quote me again.

[maningrey]

GetConVarInt! very cool, thank you!

Edit: Yep, I see what I did wrong, fail logic ;p thank you