[SuperRaWR]

http://ampaste.net/m71064bc0

When I call public Action:Command_sendLocation(client, args), the for loop that loops through the clients doesn't break if there's more than 1 client, and it makes the server hang, clients disconnect, and I'm unable to unload the plugin, I have to restart the server.

I put in a bunch of PrintToServer's, which is how I knew that the loop isn't breaking...

To me, it appears as though I'm looping through the clients correctly, but it's not working, I've stared at this for hours now, and I can't figure it out, and would really appreciate it if someone could take some time and point me in the right direction. I'm new to pawn btw.

[berni]

The loops seems fine to me.

Maybe it's SocketSend() that hangs because the socket isn't connected ?

[SuperRaWR]

But it's I had PrintToServer's inside the loop, and they'd keep calling over and over again, so it shouldn't have anything to do with SocketSend(), although you are right, i should have a conditional to ensure we're connected before calling that.

[Leonardo]

good way to save in local file
and read this file from web via php's functions

[berni]

The only other explanations I have is that the var "i" somehow get's altered inside the loop (memory corruption ?) or MaxClients being something insane high.

Use that for debugging:

PHP Code:

PrintToServer("[DEBUG] %d <= %d", i, MaxClients); 


[Leonardo]

btw

PHP Code:

        for (new i=1; i<=MaxClients; i++)
        {
                new String:tempStr[32]; // line 34
                if (IsClientInGame(i) && IsPlayerAlive(i) && socketConnected)
                {
                        decl Float:vecClientEyePos[3];
                        GetClientEyePosition(i, vecClientEyePos);
                        Format(tempStr, 128, "C:%iX:%fY:%f",i,vecClientEyePos[0],vecClientEyePos[1]);
                        StrCat(sendBuffer, sizeof(sendBuffer), tempStr);
                }       
        } 


1/ I guess this is bad to allocate memory on each client (line 34)
2/ tempStr's size 32, but in Format it's a 128.
3/ socketConnected shouldn't be in cycle
4/ (maybe) should add IsClientConnected() in line 35

[berni]

Oh yeah, Gogo Gadgeto Memory Corruption

[toazron1]

What you want is something like this:

PHP Code:

    new String:tempStr[32], Float:vecClientEyePos[3];
    if (socketConnected)
    {
        for (new i=1; i<=MaxClients; i++)
        {
            if (IsClientInGame(i) && IsPlayerAlive(i))
            {
                GetClientEyePosition(i, vecClientEyePos);
                Format(tempStr, sizeof(tempStr), "C:%iX:%fY:%f", i, vecClientEyePos[0], vecClientEyePos[1]);
                StrCat(sendBuffer, sizeof(sendBuffer), tempStr);
            }    
        }
        SocketSend(socketReceive, sendBuffer);
        sendBuffer = "";
    } 


Also - IsClientInGame() implies IsClientConnected afaik