[Krtola]

I have this problem and I need help because dont know how to fix this.
It often happens that after a reload actually I dont get bullet and can not shot.When this happen I have to repeat reload few times,and sometimes help when I drop bazooka on the floor and then pick up them again.
This is the error:

PHP Code:

L 04/25/2017 - 12:11:12: [AMXX] Run time error 10: native error (native "cs_get_weapon_ammo")
L 04/25/2017 - 12:11:12: [AMXX]    [0] amx_bazooka.sma::fw_CmdStart (line 278)
L 04/25/2017 - 12:11:12: [CSTRIKE] Non-player entity 0 out of range 


PHP Code:

public fw_CmdStart(id, uc_handle, seed)
{
    if(!is_user_alive(id) || !is_user_connected(id))
        return FMRES_IGNORED

    if(get_user_weapon(id) != CSW_AT4CS || !g_had_at4cs[id])
        return FMRES_IGNORED
        
    static CurButton
    CurButton = get_uc(uc_handle, UC_Buttons)
    
    if(CurButton & IN_ATTACK)
    {
        static Float:CurTime
        CurTime = get_gametime()
        
        static at4cs
        at4cs = fm_find_ent_by_owner(-1, weapon_at4cs, id)        
        
        if(cs_get_weapon_ammo(at4cs) > 0 && !is_reloading[id])
        {
            if(CurTime - 4.5 > g_lastfire[id])
            {
                set_weapon_anim(id, 1)                            
                
                create_rocket(id)

                                make_punch(id, 500)
                                                
                static Float:Punch_Angles[3]
                
                Punch_Angles[0] =-20.0
                Punch_Angles[1] = 0.0
                Punch_Angles[2] = 0.0
                
                set_pev(id, pev_punchangle, Punch_Angles)
                cs_set_weapon_ammo(at4cs, cs_get_weapon_ammo(at4cs) - 1)
                
                if(cs_get_weapon_ammo(at4cs) <= 0 && !is_reloading[id])
                {
                    if(cs_get_user_bpammo(id, CSW_AT4CS) > 0)
                    {
                        set_task(0.5, "at4cs_reload", id)
                    }
                }
                
                
                
                g_lastfire[id] = CurTime
            }
        } else {
            if(!is_reloading[id])
            {
                if(cs_get_user_bpammo(id, CSW_AT4CS) > 0)
                {
                    if(CurTime - 1.0 > g_lastfire[id])
                    {
                        at4cs_reload(id)
                        g_lastfire[id] = CurTime
                    }
                }
            }
        }
    }
    
    if(CurButton & IN_ATTACK2)
    {
        static Float:CurTime
        CurTime = get_gametime()
        
        if((CurTime - 0.5 > g_lastaim[id]) && !is_reloading[id])
        {
            if(!g_aiming[id])
            {
                g_aiming[id] = 1
            } else {
                g_aiming[id] = 0
            }
            
            g_lastaim[id] = CurTime
        }
    }
    
    CurButton &= ~IN_ATTACK
    set_uc(uc_handle, UC_Buttons, CurButton)
    
    CurButton &= ~IN_RELOAD
    set_uc(uc_handle, UC_Buttons, CurButton)

    return FMRES_HANDLED
} 


This is line 278

PHP Code:

if(cs_get_weapon_ammo(at4cs) > 0 && !is_reloading[id]) 


[HamletEagle]

Make sure at4cs is actually a valid entity before calling cs_get_weapon_ammo. You should always put sanity checks around each value that you retrieve by a native. You never know when things go wrong.

[Krtola]

Originally Posted by HamletEagle Make sure at4cs is actually a valid entity before calling cs_get_weapon_ammo. You should always put sanity checks around each value that you retrieve by a native. You never know when things go wrong.

Is this ok:

PHP Code:

public fw_CmdStart(id, uc_handle, seed)
{
        if(!is_valid_ent(id))
                return FMRES_IGNORED 


[HamletEagle]

NO.

Make sure at4cs is actually a valid entity.

This means to add an if(is_valid_ent(at4cs)). The error is about a native in which at4cs is used, the error tells you that entity index is invalid, so why would you check "id" now?

[Krtola]

Ok. Take a look on this please:

PHP Code:

static at4cs
at4cs = fm_find_ent_by_owner(-1, weapon_at4cs, id)

if(!is_valid_ent(at4cs))
         return FMRES_IGNORED        
if(cs_get_weapon_ammo(at4cs) > 0 && !is_reloading[id])
{ 


[Craxor]

Better use this stock: https://forums.alliedmods.net/showthread.php?t=278123

[HamletEagle]

Yeah.

[Krtola]

#Hamlet Yeah Better use this stock or Yeah my last post?

[HamletEagle]

Your last post.

[CrazY.]

I think the is_user_alive automatically check if the player is connected.