[RumbleFrog]

So I'm getting this error

PHP Code:

L 04/25/2017 - 22:12:39: [SM] Exception reported: Menu handle 20900434 is invalid (error 3)
L 04/25/2017 - 22:12:39: [SM] Blaming: Ticketron.smx()
L 04/25/2017 - 22:12:39: [SM] Call stack trace:
L 04/25/2017 - 22:12:39: [SM]   [0] Menu.ItemCount.get
L 04/25/2017 - 22:12:39: [SM]   [1] Line 1203, C:\Users\xxlos\Ticketron\Ticketron.sp::TagPlayerMenu() 


This is the line it's on:

PHP Code:

public int TagPlayerMenu(Menu menu, MenuAction action, int param1, int param2)
{    
    int pDataPos = (menu.ItemCount - 1); //This Line is 1203
} 


I do have

PHP Code:

IntToString(view_as<int>(pData), Pack_String, sizeof Pack_String);
menu.AddItem(Pack_String, "", ITEMDRAW_IGNORE); 


Could it be I'm trying to pass a disguised DataPack? https://forums.alliedmods.net/showpo...7&postcount=31

[RumbleFrog]

Note, it still returns the ItemCount despite the warning it gives off

[Chaosxk]

Maybe check menu != null first?

[RumbleFrog]

Originally Posted by Chaosxk Maybe check menu != null first?

It's not null though, I already tried null check, and it can still get the count, only reason I can think of, is the data pack I'm converting to string

[RumbleFrog]

Basically this is how I converted the pack to string

PHP Code:

IntToString(view_as<int>(pData), Pack_String, sizeof Pack_String); 


Then on the other side:

PHP Code:

if (menu == null) return;
    
    int pDataPos = (menu.ItemCount - 1);
    char pDataPosChar[16];
    
    menu.GetItem(pDataPos, pDataPosChar, sizeof pDataPosChar);
    
    DataPack pData = view_as<DataPack>(StringToInt(pDataPosChar)); 


[Chaosxk]

I don't think it's your DataPack, i need to see your whole menu callback.

Also your right, menu isn't null so checking it doesn't matter.

[8guawong]

i think you probably closed the handle somewhere

[RumbleFrog]

Here's my entire callback

PHP Code:

public int TagPlayerMenu(Menu menu, MenuAction action, int param1, int param2)
{    
    int pDataPos = (menu.ItemCount - 1);
    char pDataPosChar[16];
    
    menu.GetItem(pDataPos, pDataPosChar, sizeof pDataPosChar);
    
    DataPack pData = view_as<DataPack>(StringToInt(pDataPosChar));
    
    ResetPack(pData);
    
    ReplySource CmdOrigin = ReadPackCell(pData);
    int client = ReadPackCell(pData);
    int ticket = ReadPackCell(pData);
    
    SetCmdReplySource(CmdOrigin);
    
    switch(action)
    {
        case MenuAction_Select:
        {
            if ((menu.ItemCount - 2) == param2)
            {
                char Update_Query[512];
                
                Format(Update_Query, sizeof Update_Query, "UPDATE `Ticketron_Tickets` SET `target_name` = null, `target_steamid` = null, `target_ip` = null WHERE `id` = '%i'", ticket);
            
                hDB.Query(SQL_OnTagPlayerUpdate, Update_Query, pData);
            } else
            {
                int target_id;
                char Update_Query[512], Client_Name[MAX_NAME_LENGTH], Client_SteamID64[32], Client_IP[45], Menu_Buffer[16], Escaped_Name[128];
            
                menu.GetItem(param2, Menu_Buffer, sizeof Menu_Buffer);
                target_id = StringToInt(Menu_Buffer);
            
                GetClientName(target_id, Client_Name, sizeof Client_Name);
                GetClientAuthId(target_id, AuthId_SteamID64, Client_SteamID64, sizeof Client_SteamID64);
                GetClientIP(target_id, Client_IP, sizeof Client_IP);
            
                hDB.Escape(Client_Name, Escaped_Name, sizeof Escaped_Name);
            
                Format(Update_Query, sizeof Update_Query, "UPDATE `Ticketron_Tickets` SET `target_name` = '%s', `target_steamid` = '%s', `target_ip` = '%s' WHERE `id` = '%i'", Escaped_Name, Client_SteamID64, Client_IP, ticket);
            
                hDB.Query(SQL_OnTagPlayerUpdate, Update_Query, pData);
            }
        }
        case MenuAction_Cancel:
        {
            CReplyToCommand(client, "%s", Divider_Failure);
            CReplyToCommand(client, "{grey}Tagging player was canceled.");
            CReplyToCommand(client, "%s", Divider_Failure);
        }
    }
    
    delete menu;
} 


[RumbleFrog]

I deleted the menu towards the end, but that shouldn't affect it?

[8guawong]

remove and see what happens