[Natsheh]

Originally Posted by CrazY. I think the is_user_alive automatically check if the player is connected.

100 % correct. no need for using both together.

[PartialCloning]

When using forwards like cmdstart you're better off using a variable to store when the player is alive or dead than calling is_user_alive every time.

You should check "!g_had_at4cs[id]" before "get_user_weapon(id) != CSW_AT4CS" as get_user_weapon wouldn't be called when it's not needed.

[PRoSToTeM@]

Show weapon_at4cs variable. You can replace entity searching with just getting m_pActiveItem (or cs_get_user_weapon_entity in amxx 1.8.3), but this error is weird if weapon_at4cs is logically correct.
Maybe this can be bugged get_user_weapon which updates current weapon not immediately, better to replace it with m_pActiveItem + cs_get_weapon_id check (or cs_get_user_weapon in amxx 1.8.3).

Originally Posted by HamletEagle You should always put sanity checks around each value that you retrieve by a native. You never know when things go wrong.

No, some things are guaranteed to be valid and correct, but in this situation there can be a problem with get_user_weapon, because it isn't updated immediately after weapon changing.

[Krtola]

Originally Posted by PRoSToTeM@ Show weapon_at4cs variable. You can replace entity searching with just getting m_pActiveItem (or cs_get_user_weapon_entity in amxx 1.8.3), but this error is weird if weapon_at4cs is logically correct. Maybe this can be bugged get_user_weapon which updates current weapon not immediately, better to replace it with m_pActiveItem + cs_get_weapon_id check (or cs_get_user_weapon in amxx 1.8.3). No, some things are guaranteed to be valid and correct, but in this situation there can be a problem with get_user_weapon, because it isn't updated immediately after weapon changing.

Do you ask for this variable?

#define weapon_at4cs "weapon_m249"
#define CSW_AT4CS CSW_M249

[HamletEagle]

No, some things are guaranteed to be valid and correct, but in this situation there can be a problem with get_user_weapon, because it isn't updated immediately after weapon changing.

Good luck explaining to a beginner when to and when to not. It's better to add a check than mess things up. Also you did not take into account other plugins that may be doing weird things.

[PRoSToTeM@]

Yup, there is a problem with get_user_weapon, you can test it with this code (problem appears on weapon change, on weapon drop and maybe on weapon strip):

PHP Code:

    register_forward(FM_CmdStart, "CmdStarted", ._post=true);
}

public CmdStarted(player, ucmdHandle, randomSeed) {
    if (!is_user_alive(player)) {
        return;
    }
    
    new amxmodxWeaponId = get_user_weapon(player);
    const m_pActiveItem = 373;
    new cstrikeWeaponId = cs_get_weapon_id(get_pdata_cbase(player, m_pActiveItem));
    
    if (amxmodxWeaponId != cstrikeWeaponId) {
        new weaponName[32];
        get_weaponname(amxmodxWeaponId, weaponName, charsmax(weaponName));
        new actualWeaponName[32];
        get_weaponname(cstrikeWeaponId, actualWeaponName, charsmax(actualWeaponName));
        client_print(player, print_chat, "get_user_weapon = %s, but actual weapon is %s", weaponName, actualWeaponName);
    }
} 


Originally Posted by HamletEagle Good luck explaining to a beginner when to and when to not. It's better to add a check than mess things up.

These checks can hide an actual problem and create another problems. AmxModX and Engine API should be better to avoid some of these problems.

Originally Posted by HamletEagle Also you did not take into account other plugins that may be doing weird things.

This is problem of these weird plugins. Don't make workarounds for plugins with weird behaviour.

[PRoSToTeM@]

So, you can just change:

PHP Code:

get_user_weapon(id) != CSW_AT4CS 


To:

PHP Code:

cs_get_user_weapon(id) != CSW_AT4CS 


[Krtola]

Hello one more time.
I dont get this error anymore,but it often happens when I reload bazooka,I dont get bullet and can not shot.
Then I have to reload few more time or to drop bazooka on ground and pickup.

Which inc I need for cs_get_user_weapon ?

[PRoSToTeM@]

cstrike, but this is for amxx 1.8.3.