[Craxor]

Ok, i checked a little, i will tell you from UP to down the changes,

First, all of these:

PHP Code:

#define PLUGIN "Laser"
#define VERSION "1.0"
#define AUTHOR "Alliedmodders/EFFx"

#define TASK_CHECK             200020
#define TASK_KILLME             200021
#define TASK_COUNTDOWN             200022
#define TASK_COUNTDOWNINVIS         200023
#define TASK_SHOWLMS             200024

#define Ham_Player_ResetMaxSpeed Ham_Item_PreFrame

#define m_pPlayer             41
#define OFFSET_LINUX_WEAPONS        4
#define m_pActiveItem            373
#define OFFSET_CLIPAMMO            51


#define INVALID_WEAPONS         ((1<<CSW_KNIFE)|(1<<CSW_HEGRENADE)|(1<<CSW_FLASHBANG)|(1<<CSW_SMOKEGRENADE)|(1<<CSW_C4))
#define szPrefix             "!g[LaserMod]!y:"
#define SPRITE_LASER             "sprites/lgtning.spr" 


Could be 'constants'.


About that one:

PHP Code:

new nVault 


Give a proper name, like NvaultFileId or something like that , not 'nvault'

About that one:

PHP Code:

new bool:isFalling[ 33 ] 


I see in all your variable declaration you are arrange the vars like that " [33] " now why are you doing like that: " [ 33 ] " here ? keep always the same style.


In all your natives publics, remove this:

PHP Code:

    if(!is_user_connected(id))
        return 0 


IMO, this should be handled by coders wich using your natives not by yourself in the native.

I see somewhere you use set_user_gravity()

You could use this stock and give directly the gravity you want, example '750' or '800' ( you can easily make also a cvar with this ):

PHP Code:

SetGravity( id , iGravity ) 
{ 
    static GravityPointer
    GravityPointer = get_cvar_pointer( "sv_gravity" )

    if( is_user_alive( id ) && iGravity )  
    { 
        set_user_gravity( id, float( iGravity ) / float( get_pcvar_num( GravityPointer ) ) )
    } 

} 


About these fucking functions:

PHP Code:

SaveLms( id ) 
{ 
    new szAuthid[ 32 ] 
    get_user_authid( id, szAuthid, cmx( szAuthid ) ) 
    
    new szVaultKey[ 128 ], szVaultData[ 512 ] 
    
    formatex( szVaultKey, 127, "Laser_%s", szAuthid ) 
    formatex( szVaultData, 511, "%d", get_user_lm(id)) 
    nvault_set( nVault, szVaultKey, szVaultData ) 
} 

LoadLms( id ) 
{ 
    new szAuthid[ 32 ] 
    get_user_authid( id, szAuthid, cmx( szAuthid ) ) 

    new szVaultKey[ 128 ], szVaultData[ 512 ] 

    formatex( szVaultKey, 127, "Laser_%s", szAuthid ) 
    formatex( szVaultData, 511, "%d", get_user_lm(id)) 

    nvault_get( nVault, szVaultKey, szVaultData, 511 ) 

    new lm[32]

    parse( szVaultData, lm, 31) 

    set_user_lm(id, 0, str_to_num( lm ) )
} 


They should look like that:

PHP Code:


SaveLms( id ) 
{ 
    new szAuthid[ 32 ] 
    get_user_authid( id, szAuthid, cmx( szAuthid ) ) 
    
    new szData[11];
    num_to_str( get_user_lm(id) , szData, cmx( szData ) )

    nvault_set( nVault, szAuthId, szData ) 
} 

LoadLms( id ) 
{ 
    new szAuthid[ 32 ] 
    get_user_authid( id, szAuthid, cmx( szAuthid ) ) 

    set_user_lm(id, 0, nvault_get( nVault, szAuthId ) )
} 


About plugin_end: You should arrange it more close to plugin_init( ) as done with plugin_precache, etc ...


Also i seee lot of stocks at the middle of the plugin, just arrange all the stocks at the end of the plugin

And remove 'stock' from them, just put directly the function

So insteand of:

stock MyStock()
{

}

They should be:

MyStock()
{

}

[EFFx]

1.

These defines

PHP Code:

#define PLUGIN "Laser"
#define VERSION "1.0"
#define AUTHOR "Alliedmodders/EFFx"

#define TASK_CHECK             200020
#define TASK_KILLME             200021
#define TASK_COUNTDOWN             200022
#define TASK_COUNTDOWNINVIS         200023
#define TASK_SHOWLMS             200024

#define Ham_Player_ResetMaxSpeed Ham_Item_PreFrame

#define INVALID_WEAPONS         ((1<<CSW_KNIFE)|(1<<CSW_HEGRENADE)|(1<<CSW_FLASHBANG)|(1<<CSW_SMOKEGRENADE)|(1<<CSW_C4))
#define SPRITE_LASER             "sprites/lgtning.spr" 


I don't changed they because I think its not necessary.

2.

I renamed him

3.

I made this code from other plugin, and I added on the principal plugin ( Laser_Mod ).

4.

I added is_user_connected() because if someone want add a set_task for give/take Laser Money from other player, it will block a debug.

5.

I think I need not this stock.

6.

Done

7.

Done

8.

I don't find it on my code...



If you have more for say, please, continue with that. I appreciate.

[Craxor]

8.

I mean these stocks
:

PHP Code:

stock laser_messagecolor(const id, const input[], any:...) 
{
    new count = 1, players[ 32 ]
    static msg[ 191 ]
    vformat( msg, 190, input, 3 )
    
    replace_all( msg, 190, "!g", "^4" )
    replace_all( msg, 190, "!y", "^1" )
    replace_all( msg, 190, "!t", "^3" )
    
    if(id) players[ 0 ] = id; else get_players( players, count, "ch" )
    {
        for(new i = 0; i < count; i++)
        {
            if( is_user_connected( players[ i ] ) )
            {
                message_begin( MSG_ONE_UNRELIABLE, get_user_msgid("SayText"), _, players[ i ] )  
                write_byte( players[ i ] )
                write_string( msg )
                message_end( )
            }
        }
    }
}

stock IsUserValid(const index)
    return (is_user_connected(index) && is_user_alive(index) ? true : false)
    
stock HasFlags(const index)
    return (get_user_flags(index) & ACCESS) ? true : false 


Just remove 'stock' and leave them like SaveMl and Load without 'stock'.

Also this one:

PHP Code:

stock FreezePlayer(id,const LaserName[],const VictimName[])
{
    if(HasFlags(UsandoLaser))
        set_user_lm(UsandoLaser, 0, 20)
    
    else
        set_user_lm(UsandoLaser, 0, 5)
                    
    laser_messagecolor(0,"%s The player!t %s!y freezed the !t%s!y.",szPrefix,LaserName,VictimName)
    laser_messagecolor(0,"%s Help him or he will die in %d secon%s.",szPrefix,get_pcvar_num(iPcvarKillSeconds),get_pcvar_num(iPcvarKillSeconds) >= 2 ? "ds" :"d")
    
    set_task(30.0,"KillPlayer",id+TASK_KILLME)
                    
    set_user_rendering(id, kRenderFxGlowShell, 0, 100, 200, kRenderNormal, 100)
    set_pev( id, pev_flags, pev( id, pev_flags ) | FL_FROZEN )
                    
    renden[id] = true
    frozen[id] = true
}
stock UnFreezePlayer(id, freezer)
{
    renden[id] = false
    frozen[id] = false
                    
    set_pev( id, pev_flags, pev( id, pev_flags ) & ~FL_FROZEN )
    set_user_rendering(id)
    remove_task(id+TASK_KILLME)
    
    if(id != freezer)
        play_sound(freezer,sounds_help[random(sizeof sounds_help)],PITCH_LOW)
                    
    if(ismoved[id])
        CanUseLaser[id] = true
} 


They are at the middle of the plugin, leave them at the end of plugin lines with the rest of the stocks and remove 'stock' from forward.


About '4' it is not needed, the coders who use your natives should handle this by themselves, in the most of the cases they will anyway add is_user_alive wich already contain is_user_connected so you can remove them.


Now again:

1. You could declare a global variable gAuthId and take user steamid just once in client_auhorized insteand of call it two times in Load and Save. You know how to do that no?

2.
Here's not an optimization but IMO looks ugly:

PHP Code:

    get_mapname(iMapPrefix,charsmax(iMapPrefix))
    if(equal(iMapPrefix,"de_"))
    { 


Leave one line space between get_map and your else

PHP Code:

    get_mapname(iMapPrefix,charsmax(iMapPrefix))

    if(equal(iMapPrefix,"de_"))
    { 


The same between your if { } and else

3. Your const szPrefix have 3 tabulations space, you used 2 tabulation wtih your const integers, do the same for szPrefix

new const szPrefix[]  = 			"!g[LaserMod]!y:"

Should be like this:

new const szPrefix[]  = 		"!g[LaserMod]!y:"

4. in your _set_user_lm() insteand of if else { } you could do this:

PHP Code:

Lm[id] = !type ? Lm[id] += ammount : Lm[id] -= ammount 


(test to see if is working )

5
// You do not need this, just use is_user_alive

PHP Code:

stock IsUserValid(const index)
    return (is_user_connected(index) && is_user_alive(index) ? true : false) 


// And also this one should be a macro
stock HasFlags(const index)
return (get_user_flags(index) & ACCESS) ? true : false

- >

PHP Code:

#define HasFlags(%1)        (get_user_flags(%1) & ACCESS) 


Anyway you could do more but i don't fully understand your code.

[EFFx]

Some suggestions I added, but have formats that make no sense for me.

PHP Code:

Lm[id] = !type ? Lm[id] += ammount : Lm[id] -= ammount 


This doesn't work.

[Craxor]

Yes, that's why i said you to test it )

However tell me where you don;t understand.

[EFFx]

The '2'

[ish12321]

Originally Posted by EFFx The '2'

He's just trying to say to add a line after get_mapname() to beautify code
He's helping you to beautify your code

[EFFx]

Aah, '-'
Someone can tell me about this plugin in-game?

[ish12321]

Originally Posted by EFFx Aah, '-' Someone can tell me about this plugin in-game?

Didn't understood you

[EFFx]

Originally Posted by ish12321 Didn't understood you

If someone can use this plugin in a server and tell my about bugs if it have.