[xxxperts]

Nice Plugin, but you should have used menu instead using command hook that will be neat & nice.

[luxor]

for (new i=0; i<num; i++) { show_motd( Players[i], buffer, Arg3 ); return PLUGIN_HANDLED; }

return in for, that should be the first reason for unnaproving this plugin

[klippy]

Originally Posted by luxor return in for, that should be the first reason for unnaproving this plugin

Why? There's nothing wrong with returning from a loop.

[xxxperts]

Originally Posted by KliPPy Why? There's nothing wrong with returning from a loop.

+1

[Mario AR.]

Originally Posted by KliPPy There's nothing wrong with returning from a loop.

+2

Hard to say, but; in this particular case, that return should be out of the loop

[klippy]

Originally Posted by Mario AR. +2 Hard to say, but; in this particular case, that return should be out of the loop

Didn't look at the code, I thought he was talking about returning from a loop in general.

[xxxperts]

Originally Posted by Mario AR. +2 Hard to say, but; in this particular case, that return should be out of the loop

There is nothing wrong in his code.

EDIT: Sorry, You were right.! ( my bad )

Originally Posted by fysiks It depends on what you are actually wanting to detect. All of your equali() checks will never happen because the 'T' check will return true first in all of those cases. What do you actually want to be the condition to be?

Agree with these too.

Have you tested the code before posting, because in every loop you had used return_handled which will break the loop after one loop.

PHP Code:


    get_players(Players,num,"ceh","TERRORIST");
    for (new i=0; i<num; i++)
    {
        show_motd( Players[i], buffer, Arg3 );
        return PLUGIN_HANDLED;
    } 


--->

PHP Code:

    get_players(Players,num,"ceh","TERRORIST");
    for (new i=0; i<num; i++)
    {
        show_motd( Players[i], buffer, Arg3 );
    }
    return PLUGIN_HANDLED; 


[luxor]

Originally Posted by KliPPy Why? There's nothing wrong with returning from a loop.

returning like that in for*

[Craxor]

Up-date <3