[bobbobagan]

I got bored, started bashing my keyboard and magically an update appeared

v1.2.3 released, see first page for change log.

[GrO]

Good to see this plugin updated.

You should change the command sm_spec to something like sm_spect or something, cause the other plugin is already using such command.

See my previous post: #29.

So when You type /spec <nick> in the chat it will exec two commands at the same time, which are mutually excluding themselfs.

[bobbobagan]

I am aware there is a clash and have tried to take it up with the author in the past however we are both unwilling to change lol.

I won't be changing my command, since it is replicating Mani Admin Plugin. You are welcome to edit the source of either plugins and change the command then recompile if you like.

[GrO]

I see... Thanks for clearing up this unclear situation ^^.

[GrO]

bobbobagan, could You make a support for SM's group prefixes (@all, @ct, @t etc.) ?

I.E.:

sm_spec @all

It would be very useful.

[Viper_Vicki]

I run an empiresmod server and the plugin works on swapping teams but when we swap to spectate it crashes the server. Can it be fixed please?

Thank you

[ffcfoo]

So this no longer works? It crashes the server every time I move someone.

EDIT: Nvm I didn't read the whole post xD.

EDIT: Nope even with the new gamedata file it still crashes.

[Mister_Magotchi]

ffcfoo: Unless this quit working some time in the last 24 hours, it is still working.

I use it on a regular basis. I used it probably 11 hours ago.

[krolus]

I have 2 several suggestions:
1) remove PrintToChatAll(...,"ts switch by admin") in PerformSwitch() , there is no need to tell twice about teamchanging
2) hook event 'player_team' and set param 'silent' to 'true' if player's team was changed by plugin

PHP Code:

new bool:g_SwitchedByPlugin[MAXPLAYERS+1];

public OnPluginStart()
{
    //cvar and other stuff
    HookEvent("player_team",    Event_PlayerTeam, EventHookMode_Pre);
    //another stuff :)
}

public Action:Event_PlayerTeam(Handle:event, const String:name[], bool:dontBroadcast)
{
    new client     = GetClientOfUserId(GetEventInt(event, "userid"));
    
    if (client && g_SwitchedByPlugin[client]){
        SetEventBool(event, "silent", true);
        g_SwitchedByPlugin[client] = false;
    }
    return Plugin_Changed;
}

void:PerformSwitch(client, bool:toSpec = false)
{
    g_SwitchedByPlugin[client] = true;
    //other stuff
} 


3) Use params in translation files
4) remove 'colour' variable, use CPrintToChat from [INC] Colors instead

[bobbobagan]

Originally Posted by ffcfoo So this no longer works? It crashes the server every time I move someone. EDIT: Nvm I didn't read the whole post xD. EDIT: Nope even with the new gamedata file it still crashes.

It is working fine for me on Windows Source Dedicated Server. Are you using Windows or Linux? What game are you running?


@ krolus: Thanks for the suggestions, I shall make the changes for the next release