[Ethorbit]

I know you can see if a player died, but how would you know if an NPC died? I've been looking everywhere, I cannot find a way.

I don't want to use OnEntityDestroyed as I cannot use SDKHook_OnTakeDamagePost with it to see who killed it.


Edit: Thanks again psychonic!

PHP Code:

public OnEntityCreated(entity) 
{ 
HookEvent("entity_killed", EntityKilled, EventHookMode_Post);
}

public OnEntityDestroyed(entity) 
{ 
UnhookEvent("entity_killed", EntityKilled, EventHookMode_Post);
}

public EntityKilled(Handle:event, const String:name[], bool:Broadcast) 
{      
    new killed = GetEventInt(event, "entindex_killed")        
    if(killed){
        new String:classname[32];
        new String:attackername[32];
        GetEntityClassname(killed, classname, sizeof(classname));
        PrintToChatAll("The npc that died: %s", classname);
        new attacker = GetEventInt(event, "entindex_attacker")
        if(IsValidClient(attacker)){
            GetClientName(attacker, attackername, sizeof(attackername))
            PrintToChatAll("It died by: %s", attackername);
        }
    }
}

stock bool:IsValidClient(client, bool:nobots = true)
{ 
    if (client <= 0 || client > MaxClients || !IsClientConnected(client) || (nobots && IsFakeClient(client)))
    {
        return false; 
    }
    return IsClientInGame(client); 
} 


[cravenge]

Game?

[Ethorbit]

Originally Posted by cravenge Game?

Half-Life 2: Deathmatch (I don't think the game matters), although I am able to detect the health of the npc every time it is hit, my only issue right now is that it's returning very inaccurate numbers:

PHP Code:

public OnEntityCreated(entity) 
{ 
SDKHook(entity, SDKHook_OnTakeDamage, OnTakeDamage); 
}

public OnTakeDamage(victim, attacker, inflictor, Float:damage, damagetype) 
{  
    if(IsValidEntity(victim)){    
        int entvictimhealth
        entvictimhealth = GetEntProp(victim, Prop_Data, "m_iHealth");
        PrintToChatAll("Ent's health: %i", entvictimhealth);
    }
} 


It says Ent's health: 10 or 2 when the npc dies, it doesn't say 0 like it should. My guess is that it returns the last health it has before it dies.

[Powerlord]

...it never occurred to you to do this?

PHP Code:

float health = entvictimhealth - damage;
if (health <= 0.0)
{
    // He's dead, Jim
} 


[Mitchell]

Originally Posted by Powerlord ...it never occurred to you to do this? PHP Code: float health = entvictimhealth - damage; if (health <= 0.0) {     // He's dead, Jim }

This is pretty much what I do in Tf2 for tf_zombie entities. Worked out so far.

[Ethorbit]

Originally Posted by Powerlord ...it never occurred to you to do this? PHP Code: float health = entvictimhealth - damage; if (health <= 0.0) {     // He's dead, Jim }

No, it did not, and it's giving me the same result.

PHP Code:

public OnEntityCreated(entity) 
{ 
SDKHook(entity, SDKHook_OnTakeDamage, OnTakeDamage); 
}

public OnTakeDamage(victim, attacker, inflictor, Float:damage, damagetype) 
{  
    if(IsValidEntity(victim)){
    int entvictimhealth
    entvictimhealth = GetEntProp(victim, Prop_Data, "m_iHealth");
    float health = entvictimhealth - damage;
    PrintToChatAll("The ent's health: %f", health); // Never prints 0.0
        if (health <= 0.0)
        {
            PrintToChatAll("It's dead!"); // Never prints.
        }
    }
} 


Here's what it looks like in-game for me:
https://www.youtube.com/watch?v=BOlDyQYZUFo

I appreciate the feedback.

[8guawong]

try

PHP Code:

if (damage > entvictimhealth) PrintToChatAll("It's dead!"); 


[psychonic]

I believe that most NPCs support the entity_killed event. You could just listen for that.

[eyal282]

Originally Posted by Ethorbit No, it did not, and it's giving me the same result. PHP Code: public OnEntityCreated(entity)  {  SDKHook(entity, SDKHook_OnTakeDamage, OnTakeDamage);  } public OnTakeDamage(victim, attacker, inflictor, Float:damage, damagetype)  {       if(IsValidEntity(victim)){     int entvictimhealth     entvictimhealth = GetEntProp(victim, Prop_Data, "m_iHealth");     float health = entvictimhealth - damage;     PrintToChatAll("The ent's health: %f", health); // Never prints 0.0         if (health <= 0.0)         {             PrintToChatAll("It's dead!"); // Never prints.         }     } }  Here's what it looks like in-game for me: https://www.youtube.com/watch?v=BOlDyQYZUFo I appreciate the feedback.

It seems to me that you're comparing a float and an integer, I doubt it works properly.

[hmmmmm]

Operations that mix floats and integers work AFAIK. The int is just implicitly converted to a float.