[id5473]

So I've used this for the last couple of weeks and noticed that it's mostly nick who's announcing stuff. Why i wonder? i looked at the source.. expecting him to be the first to be checked.. but no he's even the 3rd. yet he is almost always the one saying the line.
Does it go through all "if" statements for one infected? because on rare occasion i have 2 survivors say their line at the same time. (for the same infected - but that could also be that the director just spawns 2 of the same type)
Another possible cause i could come up with: nick is 'special' with his ability to mute coach and ellis.. if either of them would vocalize but nicks "if" also returns true he might just flat out interrupt them before they even start.
So i wonder if it would make sense to just add another (maybe random?) timer that prevents the same survivor to vocalize again?

[DeathChaos25]

Originally Posted by id5473 So I've used this for the last couple of weeks and noticed that it's mostly nick who's announcing stuff. Why i wonder? i looked at the source.. expecting him to be the first to be checked.. but no he's even the 3rd. yet he is almost always the one saying the line. Does it go through all "if" statements for one infected? because on rare occasion i have 2 survivors say their line at the same time. (for the same infected - but that could also be that the director just spawns 2 of the same type) Another possible cause i could come up with: nick is 'special' with his ability to mute coach and ellis.. if either of them would vocalize but nicks "if" also returns true he might just flat out interrupt them before they even start. So i wonder if it would make sense to just add another (maybe random?) timer that prevents the same survivor to vocalize again?

Yes, it cycles through ALL survivors and based on the percentage chance, they vocalize.

The chance is calculated individually for every survivor, I haven't really noticed this oddity as I have it set to 75% chance myself.

It is also possible to just set the chance to 100% and the cooldowns to 0 seconds and every survivor should vocalize the warnings.

Also, did you update to the newest version?

The way the plugin works, is it forces a survivor to vocalize, and after such, the cooldown comes in.

However, the older versions didn't check if a survivor was vocalizing, meaning, if they were, the warning would fail to be vocalize, but the cooldown was still being applied.

In the latest version, the plugin first checks to see if a survivor is not already vocalizing to prevent this from happening

[id5473]

apparently i wasn't using the latest version. sorry
Updated now. But i have my doubts it's gone. But i'll keep an EAR on it ;)

[id5473]

i still think it's only one survivor announcing everything during an entire campaign.. hasn't anyone using this observed the same effect? While it doesn't seem to be nick all the time.
In the last campaign I played just now for instance (dark carnival) coach announced all the "bugged infected" in all 5 maps.

Spoiler

// This file was auto-generated by SourceMod (v1.6.1)
// ConVars for plugin "l4d2_si_warnings_vocalize_fix.smx"


// How many seconds must survivors wait to warn for hearing boomers again
// -
// Default: "120"
// Minimum: "1.000000"
// Maximum: "360.000000"
boomer_delay "150"

// How many seconds must survivors wait to warn for hearing chargers again
// -
// Default: "120"
// Minimum: "1.000000"
// Maximum: "360.000000"
charger_delay "150"

// How many seconds must survivors wait to warn for hearing smokers again
// -
// Default: "120"
// Minimum: "1.000000"
// Maximum: "360.000000"
smoker_delay "150"

// How many seconds must survivors wait to warn between each different special infected type
// -
// Default: "30"
// Minimum: "1.000000"
// Maximum: "90.000000"
special_delay "30"

// How many seconds must survivors wait to warn for hearing spitters again
// -
// Default: "120"
// Minimum: "1.000000"
// Maximum: "360.000000"
spitter_delay "150"

// How many seconds must survivors wait to warn for hearing tanks again
// -
// Default: "120"
// Minimum: "1.000000"
// Maximum: "360.000000"
tank_delay "150"

// Chance out of 100 (i.e 25 for 25% chance) that a survivor will vocalize the 'I heard' lines upon the Infected's spawn
// -
// Default: "33"
// Minimum: "1.000000"
// Maximum: "100.000000"
vocalize_chance "33"

[DeathChaos25]

Originally Posted by id5473 i still think it's only one survivor announcing everything during an entire campaign.. hasn't anyone using this observed the same effect? While it doesn't seem to be nick all the time. In the last campaign I played just now for instance (dark carnival) coach announced all the "bugged infected" in all 5 maps. Spoiler // This file was auto-generated by SourceMod (v1.6.1) // ConVars for plugin "l4d2_si_warnings_vocalize_fix.smx" // How many seconds must survivors wait to warn for hearing boomers again // - // Default: "120" // Minimum: "1.000000" // Maximum: "360.000000" boomer_delay "150" // How many seconds must survivors wait to warn for hearing chargers again // - // Default: "120" // Minimum: "1.000000" // Maximum: "360.000000" charger_delay "150" // How many seconds must survivors wait to warn for hearing smokers again // - // Default: "120" // Minimum: "1.000000" // Maximum: "360.000000" smoker_delay "150" // How many seconds must survivors wait to warn between each different special infected type // - // Default: "30" // Minimum: "1.000000" // Maximum: "90.000000" special_delay "30" // How many seconds must survivors wait to warn for hearing spitters again // - // Default: "120" // Minimum: "1.000000" // Maximum: "360.000000" spitter_delay "150" // How many seconds must survivors wait to warn for hearing tanks again // - // Default: "120" // Minimum: "1.000000" // Maximum: "360.000000" tank_delay "150" // Chance out of 100 (i.e 25 for 25% chance) that a survivor will vocalize the 'I heard' lines upon the Infected's spawn // - // Default: "33" // Minimum: "1.000000" // Maximum: "100.000000" vocalize_chance "33"

If it helps, I've set vocalize_chance to 75 myself, and I rarely get 2 survivors vocalizing at the same time, and I get variations amongst who does the vocalizing.

The thing is, after an SI spawns, there is a full 2 second delay before warnings are issued.

However, since the warnings are coming out of scene processor, as opposed to being a scripted scene, the warnings are low priority and can easily get cancelled out before being initialized.

Even with me setting the chance to 75%, they're not as common as you'd think they'd be.

[id5473]

Here's an altered version of the plugin that doesn't call the vcd files but rather the concept and then allows the response system of l4d2 based on the talker files do the timer delay and stuff. (concepts and rules for the survivors included)

I haven't done super extensive testing but it works from what i can tell.

so using this smx without adapting the talker files is pointless.

id

[DeathChaos25]

Originally Posted by id5473 Here's an altered version of the plugin that doesn't call the vcd files but rather the concept and then allows the response system of l4d2 based on the talker files do the timer delay and stuff. (concepts and rules for the survivors included) I haven't done super extensive testing but it works from what i can tell. so using this smx without adapting the talker files is pointless. id

I actually thought about this at first, but because the concepts themselves never actually fired, I just completely discarded the idea without even trying.

But now I see that they indeed work when forced to fire, but since they don't exist in Vanilla talker files, plugin users would need to either modify their talker files or get Modified Talker, which IMO, there's no reason why anyone shouldn't at least be using MT in some shape or form.

I won't have access to my client PC for a few days, but could you try doing a small change within your Nick talker files and tell me if it works?

Change this;

Spoiler

response playercallforrescuegambler
{
        speak "gambler_callforrescue01" noscene  //goddamn it, i'm stuck in here.  get me out!
	speak "gambler_callforrescue02" noscene  //someone want to come get me out of here?
	speak "gambler_callforrescue03" noscene  //i'm no use to anyone in here, get me out of here!
	speak "gambler_callforrescue04" noscene  //you guys out there?  come get me!
	speak "gambler_callforrescue05" noscene  //i need someone's help for just five seconds!
	speak "gambler_callforrescue06" noscene  //can one of you people come get me, please?
	speak "gambler_callforrescue07" noscene  //i am trapped in a room!
	speak "gambler_callforrescue08" noscene  //i cannot get out of here by myself!
	speak "gambler_callforrescue09" noscene  //come on guys, get me out of here.
	speak "gambler_callforrescue10" noscene  //you know i'm going to be a big help.  just get me out of here!
	speak "gambler_callforrescue11" noscene  //alright, who's available to get me out of here?
	speak "gambler_callforrescue12" noscene  //just this once i need some help.
}

with;

Spoiler

response playercallforrescuegambler
{
	scene "scenes/gambler/callforrescue01.vcd"  //goddamn it, i'm stuck in here.  get me out!
	scene "scenes/gambler/callforrescue02.vcd"  //someone want to come get me out of here?
	scene "scenes/gambler/callforrescue03.vcd"  //i'm no use to anyone in here, get me out of here!
	scene "scenes/gambler/callforrescue04.vcd"  //you guys out there?  come get me!
	scene "scenes/gambler/callforrescue05.vcd"  //i need someone's help for just five seconds!
	scene "scenes/gambler/callforrescue06.vcd"  //can one of you people come get me, please?
	scene "scenes/gambler/callforrescue07.vcd"  //i am trapped in a room!
	scene "scenes/gambler/callforrescue08.vcd"  //i cannot get out of here by myself!
	scene "scenes/gambler/callforrescue09.vcd"  //come on guys, get me out of here.
	scene "scenes/gambler/callforrescue10.vcd"  //you know i'm going to be a big help.  just get me out of here!
	scene "scenes/gambler/callforrescue11.vcd"  //alright, who's available to get me out of here?
	scene "scenes/gambler/callforrescue12.vcd"  //just this once i need some help.
}

And test if they work?

As for the edit you posted, I see a few things that could be done better, I'll get to it and tidy it up a bit.

A few examples being no code for checking if client index belongs to a survivor, if said player is actually alive, etc...

Note that with the vcd files method, Zoey modelled Rochelles would at least have SOME lines with Zoey's voice, now Zoey models won't ever warn because the concept doesn't exist, so she'll still talk as Rochelle, etc...

Also, why did you keep the model check?

It's not as if the concept is Survivor specific, so we can entirely remove that section.

Before I keep on Rambling, I'll just tidy up your version and post it alongside the Main Version in the main post for Now, although I suspect I'll keep your version as the code will be more optimal, short and sweet.

Edit : Well, here it is.

Spoiler

PHP Code:

#include <sourcemod>
#include <sceneprocessor> 

#define WARN_BOOMER "WarnBoomer"
#define WARN_SMOKER "WarnSmoker"
#define WARN_SPITTER "WarnSpitter"
#define WARN_CHARGER "WarnCharger"
#define WARN_TANK "WarnTank"

#define ZOMBIECLASS_SMOKER 1
#define ZOMBIECLASS_BOOMER 2
#define ZOMBIECLASS_HUNTER 3
#define ZOMBIECLASS_SPITTER 4
#define ZOMBIECLASS_JOCKEY 5
#define ZOMBIECLASS_CHARGER 6
#define ZOMBIECLASS_TANK 8

#define PLUGIN_VERSION "1.5"

public Plugin:myinfo =
{
    name = "[L4D2] Special Infected Warnings Vocalize Fix",
    author = "DeathChaos25",
    description = "Fixes the 'I heard a (Insert Special Infected here)' warning lines not working for some specific Special Infected.",
    version = PLUGIN_VERSION,
    url = "https://forums.alliedmods.net/showthread.php?p=2189049",
}

public OnPluginStart() 
{ 
    HookEvent("player_spawn", PlayerSpawn_Event) 
    CreateConVar("l4d2_si_warnings_vocalize_fix_version", PLUGIN_VERSION, "[L4D2] Special Infected Warnings Vocalize Fix", FCVAR_PLUGIN|FCVAR_SPONLY|FCVAR_REPLICATED|FCVAR_NOTIFY|FCVAR_DONTRECORD) 
    
}

public PlayerSpawn_Event(Handle:event, const String:name[], bool:dontBroadcast) 
{
    new client = GetClientOfUserId(GetEventInt(event, "userid")) 
    
    if (client <= 0 || client > MaxClients || !IsClientInGame(client) || GetClientTeam(client) != 3) {
        return
    }
    new class = GetEntProp(client, Prop_Send, "m_zombieClass") 
    decl String:announce_special[PLATFORM_MAX_PATH] 
    
    /* What Special should the survivors warn for having heard? */
    if (class == ZOMBIECLASS_BOOMER)  announce_special = WARN_BOOMER 
    else if (class == ZOMBIECLASS_SMOKER) announce_special = WARN_SMOKER 
    else if (class == ZOMBIECLASS_CHARGER) announce_special = WARN_CHARGER 
    else if (class == ZOMBIECLASS_SPITTER) announce_special = WARN_SPITTER 
    else if (class == ZOMBIECLASS_TANK) announce_special = WARN_TANK
    
    /* Only one survivor will actually be picked to Vocalize
    *  Once a survivor who meets all of the criteria is found,
    *  he/she will warn and the loop will terminate */
    
    /* Because we don't want to always pick the first client index
    *  that matches all criteria, we use a percentage chance to
    *  possibly skip over it instead of always choosing the first positive*/
    for (new i = 1; i <= MaxClients; i++) {
        new random = GetRandomInt(1,4)
        if (IsSurvivor(i) && IsPlayerAlive(i) && !IsActorBusy(i) && random == 1) {                
            PerformSceneEx(i, announce_special, _, 2.0)
            i=MaxClients
            break 
        }
    }    
}    

stock bool:IsSurvivor(client)
{
    if (client > 0 && client <= MaxClients && IsClientInGame(client) && GetClientTeam(client) == 2)
    {
        return true 
    }
    return false 
} 


Haven't really tested it but it should work no problems, so please test it out to see if it indeed does work before I edit the main post.

Edit #2 : Made the changes mentioned in post #59

[id5473]

Originally Posted by DeathChaos25 A few examples being no code for checking if client index belongs to a survivor, if said player is actually alive, etc... ... Also, why did you keep the model check? It's not as if the concept is Survivor specific, so we can entirely remove that section.

I compare the index with the model.. if the player with index X has model Y it must be a survivor. I'm not sure what the response here is if the player is dead. does he still have a survivor model assigned? or is he in spectator team?

I need the model check to figure out what playerindex has the survivor i picked earlier so i can make him vocalize. if he can't be found i pick a new survivor and try again.
I think your solution will most likely pick the same survivors over and over as i don't think the playerindexes change too much and if .. lets say ellis has playerindex 1 he'll be the one announcing most of the time as the loops reaches his index fist all the time.. no?

I'll try your talker adjustment when i'm home from work.

[DeathChaos25]

Originally Posted by id5473 I compare the index with the model.. if the player with index X has model Y it must be a survivor. I'm not sure what the response here is if the player is dead. does he still have a survivor model assigned? or is he in spectator team? I need the model check to figure out what playerindex has the survivor i picked earlier so i can make him vocalize. if he can't be found i pick a new survivor and try again. I think your solution will most likely pick the same survivors over and over as i don't think the playerindexes change too much and if .. lets say ellis has playerindex 1 he'll be the one announcing most of the time as the loops reaches his index fist all the time.. no? I'll try your talker adjustment when i'm home from work.

It depends, you don't really need to check models, just checking to see if they're a survivor (Team #2) is enough, because let's say for some reason, I am an Infected, and I have a Zoey model, with a model only based check, this would result in a positive, and we can't have that.

As for the check, you are almost completely correct.

In the check I coded, there are 3 Different conditions.
a) Player must be a survivor
b) they must be alive
c) they must not currently be vocalizing

Maybe I should once again add a percentage chance so that we can possibly skip a few indexes every time instead of having the first index possibly result in a positive every single time, I'll edit the code in the previous post.

If any of these return a false positive, the loop moves on into the next client index, and so on until a client index who meets all 3 conditions is found, and then that survivor is made to vocalize the warning.

Also note that client indexes are "recycled" in the sense that the same index can belong to 2 different people at different times, but userid is unique to every user.
Let's say I join a versus server, and my client index is 3, and I am survivor Nick.
After some time, I leave the server, client index 3 is now assigned to someone else, maybe an Infected Bot.

A Different person now joins the same server, but as a Spectator this time, client index 3 is now assigned to this person, all of this could have happened in the span of a single minute, maybe less time, or more time.

Meaning storing client indexes over time is not advisable.

[id5473]

The scenes don't work i'm afraid.
I suppose it's maybe because the models aren't actually there yet (only that looping orange animation outline) so the facial animations stored in these scenes would be useless anyway. I played around with the conditions a bit but to no avail.

"for some reason, I am an Infected, and I have a Zoey model," - this event is too unlikely to actually check for it imho. just like checking for buckshot dmg type when writing a plugin around punching survivors as a tank. ;)

Also I think the check "they must not currently be vocalizing"is optional as the response system will determine if he's busy or not and will either start the line or not. (unless you are going to re-roll who's vocalizing... otherwise it's superfluous, no?)

Granted I know little about client indexes.. but i've observed it takes a fair 10-50 secs for people to click on (join game) till they have actually joined the game.
(if you run l4d2 with the console parameter -dev you can easily see (even as a client yourself) when someone connects (some DLC1/DLC2 installed = 0 messages appear) and when he finally joins the game a message #Cstrike_TitlesTXT_Game_connected appears.

Bottomline is: clientindex changing the owner during one of the loops is highly unlikely i think. (my assumption being: clientindex is distributed as soon as he starts connecting)
esp. if you run a normal realism/coop server with 4 slots. even if it's 8 slot server.