[XiLuo]

I guess it not be,timer repeat issue is the most easier wrong,timer can kill(initialize) by onMapStart(),onMapEnd(),
RoundStart or RoundEnd.
The best way to deal timer issue is that consider original timer.
Every time to create timer should to consider the last timer had been killed? Or timer may will repeat and stack
more

[XiLuo]

I perfectly agree with 1337norway ,try many times you will know how event,timer work.

[Ilusion9]

PHP Code:


Handle hTimer;

public void OnMapEnd()
{
    delete hTimer;
}

public Action Event_RoundEnd(Event event, const char[] name, bool dontBroadcast)
{
    delete hTimer;
}

public Action Event_RoundStart(Event event, const char[] name, bool dontBroadcast)
{
    g_iCountdown = 30;
    
    hTimer = CreateTimer(1.0, EndZoneCheck, _, TIMER_REPEAT);
}

public Action EndZoneCheck(Handle timer, any data)
{
    for (int i = 1; i <= MaxClients; i++)
    {
        if (IsClientInGame(i) && IsPlayerAlive(i) && coursetimer_InEndZone(i))
        {
            EmitSoundToAll("training/countdown.wav", i, SNDCHAN_VOICE, SNDLEVEL_RAIDSIREN);
            PrintToChatAll("[SM] \x07%N \x02has reached the end!", i);
            PrintToChatAll("[SM] \x0330 seconds remaining to complete the map.");
            
            ForcePlayerSuicide(i);
            
            hTimer = CreateTimer(1.0, Timer_Countdown, GetClientUserId(i), TIMER_REPEAT);
            return Plugin_Stop;
        }
    }
    
    return Plugin_Continue;
}

public Action Timer_Countdown(Handle timer, any data)
{
    int client = GetClientOfUserId(data);

    if (g_iCountdown > 0 && IsClientInGame(client))
    {
        if ((g_iCountdown == 20) || (g_iCountdown == 10) || (g_iCountdown == 5) || (g_iCountdown < 4))
        {
            if (g_iCountdown == 1)
            {
                PrintToChatAll("[SM] \x03%d second remaining to complete the map.", g_iCountdown);
                
                for (int i = 1; i <= MaxClients; ++i)
                {
                    if(IsClientInGame(i) && IsPlayerAlive(i) && GetClientTeam(i) > 1)
                    {
                        ForcePlayerSuicide(i);
                    }
                }
                
                hTimer = null;
                return Plugin_Stop;
            }
        }
        else 
        {
            PrintToChatAll("[SM] \x03%d seconds remaining to complete the map.", g_iCountdown);
        }
        
        g_iCountdown--;
    }
    
    return Plugin_Continue;
} 


[Lubricant Jam]

Originally Posted by Ilusion9 PHP Code: Handle hTimer; public void OnMapEnd() {     delete hTimer; } public Action Event_RoundEnd(Event event, const char[] name, bool dontBroadcast) {     delete hTimer; } public Action Event_RoundStart(Event event, const char[] name, bool dontBroadcast) {     g_iCountdown = 30;          hTimer = CreateTimer(1.0, EndZoneCheck, _, TIMER_REPEAT); } public Action EndZoneCheck(Handle timer, any data) {     for (int i = 1; i <= MaxClients; i++)     {         if (IsClientInGame(i) && IsPlayerAlive(i) && coursetimer_InEndZone(i))         {             EmitSoundToAll("training/countdown.wav", i, SNDCHAN_VOICE, SNDLEVEL_RAIDSIREN);             PrintToChatAll("[SM] \x07%N \x02has reached the end!", i);             PrintToChatAll("[SM] \x0330 seconds remaining to complete the map.");                          ForcePlayerSuicide(i);                          hTimer = CreateTimer(1.0, Timer_Countdown, GetClientUserId(i), TIMER_REPEAT);             return Plugin_Stop;         }     }          return Plugin_Continue; } public Action Timer_Countdown(Handle timer, any data) {     int client = GetClientOfUserId(data);     if (g_iCountdown > 0 && IsClientInGame(client))     {         if ((g_iCountdown == 20) || (g_iCountdown == 10) || (g_iCountdown == 5) || (g_iCountdown < 4))         {             if (g_iCountdown == 1)             {                 PrintToChatAll("[SM] \x03%d second remaining to complete the map.", g_iCountdown);                                  for (int i = 1; i <= MaxClients; ++i)                 {                     if(IsClientInGame(i) && IsPlayerAlive(i) && GetClientTeam(i) > 1)                     {                         ForcePlayerSuicide(i);                     }                 }                                  hTimer = null;                 return Plugin_Stop;             }         }         else          {             PrintToChatAll("[SM] \x03%d seconds remaining to complete the map.", g_iCountdown);         }                  g_iCountdown--;     }          return Plugin_Continue; }

This fixed my issue, thanks a bunch!

[Lubricant Jam]

Okay it works however if you are the last person alive and complete the map, the timer still runs on the next round so it's not completely fixed.

[backwards]

How are you checking to see if the person completes the map or not? Is it based on a zone or something? i'm assuming you just have to do the same thing with the timer on that event. Kill the timer or delete the handle and it should be fine

[Lubricant Jam]

Originally Posted by 1337norway How are you checking to see if the person completes the map or not? Is it based on a zone or something? i'm assuming you just have to do the same thing with the timer on that event. Kill the timer or delete the handle and it should be fine

Using a native I made from the timer, works perfectly fine it's just the timer that causes the problem. I think I've sorted it, I'll have to test further.

public Action EndZoneCheck(Handle timer, int userid)
{
    for (int i = 1; i <= MaxClients; i++)
    {
		if (IsClientInGame(i) && coursetimer_InEndZone(i) && IsPlayerAlive(i))
		{
			if (g_iCompleted == 0) {
				EmitSoundToAll("training/countdown.wav", i, SNDCHAN_VOICE, SNDLEVEL_RAIDSIREN);
				ForcePlayerSuicide(i);
				if (IsClientInGame(i) && (coursetimer_CurrentStyle(i) >= 4) < 4 && IsPlayerAlive(i))
				{
					PrintToChatAll("[SM] \x07%N \x02has reached the end!", i);
					PrintToChatAll("[SM] \x0330 seconds remaining to complete the map.");
					hTimer = CreateTimer(1.0, Timer_Countdown, GetClientUserId(i), TIMER_REPEAT);
					g_iCompleted++;
				} else hTimer = null;
				return Plugin_Stop;
			}
		}
	}

	return Plugin_Continue;
}

[Ilusion9]

Originally Posted by Lubricant Jam Okay it works however if you are the last person alive and complete the map, the timer still runs on the next round so it's not completely fixed.

PHP Code:


public Action Event_RoundEnd(Event event, const char[] name, bool dontBroadcast)
{
    delete hTimer;
} 


you must hook the round_end event.

[Lubricant Jam]

Originally Posted by Ilusion9 PHP Code: public Action Event_RoundEnd(Event event, const char[] name, bool dontBroadcast) {     delete hTimer; }  you must hook the round_end event.

Yes, it is hooked. I even tried making a delay to see if that would help also, still no luck.

public Action Event_RoundEnd(Event event, const char[] name, bool dontBroadcast)
{
	delete hTimer;
	CreateTimer(1.0, ClearTimer);
}

public Action ClearTimer(Handle timer)
{
	delete hTimer;
}

EDIT: Do you want me to hook it to round_end or round_officially_end?

[Bacardi]

What game is this ?