Raised This Month: $51 Target: $400
 12% 

Gladiator Knife Mod v 1.1b


Post New Thread Reply   
 
Thread Tools Display Modes
soccdoodcss
Veteran Member
Join Date: Nov 2006
Location: Wisconsin
Old 02-03-2007 , 00:02   Re: Gladiator Knife Mod v 1.1a / Vote
Reply With Quote #11

That's a god idea... Ill look into it. Also, I wonder if there are any gladiator-like shield models.
__________________
"Now safe beneath their wisdom and their feet.
Here I will teach you truly how to sleep."

Last edited by soccdoodcss; 02-03-2007 at 01:20.
soccdoodcss is offline
Send a message via AIM to soccdoodcss
soccdoodcss
Veteran Member
Join Date: Nov 2006
Location: Wisconsin
Old 02-04-2007 , 02:13   Re: Gladiator Knife Mod v 1.1a / Vote
Reply With Quote #12

Sorry to bump yet again. But I was wondering is anyone was willing to share there opinions on this plugin. Any suggestions are also more than welcome.
__________________
"Now safe beneath their wisdom and their feet.
Here I will teach you truly how to sleep."
soccdoodcss is offline
Send a message via AIM to soccdoodcss
Da_sk8rboy
Veteran Member
Join Date: Jul 2006
Old 02-04-2007 , 04:12   Re: Gladiator Knife Mod v 1.1a / Vote
Reply With Quote #13

why not remove all the other plugins besides the newest & updated version?
__________________
i stop around here and there.
Da_sk8rboy is offline
Hawk552
AMX Mod X Moderator
Join Date: Aug 2005
Old 02-04-2007 , 12:26   Re: Gladiator Knife Mod v 1.1a / Vote
Reply With Quote #14

Quote:
Originally Posted by Da_sk8rboy View Post
why not remove all the other plugins besides the newest & updated version?
Do this.

Code:
get_pcvar_num(gm_level) !=0
Although this technically is the same thing and I'm pretty sure it gets optimized out, it looks nicer if you do this instead:

Code:
get_pcvar_num(gm_level)
Similarly, this:

Code:
get_pcvar_num(gm_on) == 0
can be shortened to:

Code:
!get_pcvar_num(gm_on)
Code:
new killer = read_data(1)
    new victim = read_data(2)
    new killername[31]
    get_user_name(killer,killername,31)
    new victimname[31]
    get_user_name(victim,victimname,31)
There are 2 things you can do with this. One is mandatory, the other isn't.

You never checked if the killer is actually connected before you got his name. If anyone does kill in console, dies for an unknown reason, or anything like that, they will trigger a runtime error.

It also looks nicer, although it's the same functionality, to do this instead:

Code:
new killer = read_data(1),victim = read_data(2),killername[31]
    get_user_name(killer,killername,31)
    new victimname[31]
    get_user_name(victim,victimname,31)
Since it looks like you're using the style where you drop brackets whenever possible, you should be consistent. Places like this:

Code:
public end_vote()
{
    if (voted==0)
    {
        if (vote_yes > vote_no)
        {
            set_vote_yes()
        }
        else if (vote_no >= vote_yes)
        {
            set_vote_no()
        }
    }
}
Might look like this instead:

Code:
public end_vote()     if (voted==0)         if (vote_yes > vote_no)             set_vote_yes()         else if (vote_no >= vote_yes)             set_vote_no()

Places like this:

Code:
public print_vote()
{
    min_votes = num/2
    client_print(0,print_chat,"[GM] Yes: %d      No: %d      Needed: %d",vote_yes,vote_no,min_votes)
    set_vote()
}
Should be private instead (i.e. remove the "public"). The rule of thumb is that any function which is never used in quotes and is not defined as a forward should be private.
__________________
Hawk552 is offline
Send a message via AIM to Hawk552
soccdoodcss
Veteran Member
Join Date: Nov 2006
Location: Wisconsin
Old 02-04-2007 , 14:03   Re: Gladiator Knife Mod v 1.1a / Vote
Reply With Quote #15

Alright, thanks a lot. Optimizing now.

Edit: I don't fully get the whole private/public thing yet. I will look into understanding it. For now, i fixed it up and removed the public from the 2 print vote functions. Fixed other things.

Edit 2: Fixing: Sometimes on round start you wouldnt start with a shield. Had some bugs, fixed them. If anyone finds anymore, tell me.

Edit 3: Ive decided not to set a model for the knife. Mostly because i havent found any appropriate models.
__________________
"Now safe beneath their wisdom and their feet.
Here I will teach you truly how to sleep."

Last edited by soccdoodcss; 02-04-2007 at 23:17.
soccdoodcss is offline
Send a message via AIM to soccdoodcss
1NiteStand
Junior Member
Join Date: Feb 2007
Old 02-04-2007 , 23:34   Re: Gladiator Knife Mod v 1.1b
Reply With Quote #16

u should make it so that u can use knife and guns so when u are holding a knife this mod is active and when ur holding a gun this plugins is disabled. u know wat i mean?
__________________
Why do you ask? CAUSE IT'S BALLIN BITCH BALLIN!

+KaRma Me?
1NiteStand is offline
vvg125
AMX Mod X Beta Tester
Join Date: Dec 2006
Location: Queens (Douglaston), New
Old 02-04-2007 , 23:46   Re: Gladiator Knife Mod v 1.1b
Reply With Quote #17

That ultimately defeats the point of the plugin? This plugin is made so it's like a knife arena sort of thing. What's the point if people can use guns?
__________________
vvg125 is offline
Send a message via AIM to vvg125 Send a message via MSN to vvg125 Send a message via Yahoo to vvg125
soccdoodcss
Veteran Member
Join Date: Nov 2006
Location: Wisconsin
Old 02-04-2007 , 23:51   Re: Gladiator Knife Mod v 1.1b
Reply With Quote #18

Exactly, it is a knife only mod. I think pistols with shield would be fun, but only if it a separate plugin, or a different setting on this plugin.
__________________
"Now safe beneath their wisdom and their feet.
Here I will teach you truly how to sleep."

Last edited by soccdoodcss; 02-05-2007 at 00:05.
soccdoodcss is offline
Send a message via AIM to soccdoodcss
kingzope
Member
Join Date: Sep 2005
Location: PA
Old 02-05-2007 , 11:20   Re: Gladiator Knife Mod v 1.1b
Reply With Quote #19

Wow I will have to try this out. Great idea and +karma man.
__________________
{KHH}Counter-Strike - 205.234.209.14:27015
kingzope is offline
Old 02-05-2007, 18:36
1NiteStand
This message has been deleted by Hawk552. Reason: stupid comment, irrelevant information
soccdoodcss
Veteran Member
Join Date: Nov 2006
Location: Wisconsin
Old 02-05-2007 , 23:28   Re: Gladiator Knife Mod v 1.1b
Reply With Quote #20

Quote:
Originally Posted by kingzope View Post
Wow I will have to try this out. Great idea and +karma man.
Thanks, hope you are still fond of it after trying.
BTW: If anyone has any ideas or suggestions, I would gladly consider them. You know where to call.
__________________
"Now safe beneath their wisdom and their feet.
Here I will teach you truly how to sleep."
soccdoodcss is offline
Send a message via AIM to soccdoodcss
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 17:50.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode