[Halt]

So I have a perk system setup in my Zombie Mod where players use points they've earned from killing zombies, but it seems to reward a larger amount of points then it should. It rewards points on hooked events like player death.

public Action At_Player_Death(Handle event, const String:name[], bool:dontBroadcast)
{
	new Client = GetClientOfUserId(GetEventInt(event, "userid"));
	new Attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
	if(bIsPlayerAlive[Attacker] && !bIsPlayerZombie[Attacker])
	{
		ZomPoints[Attacker] += 0.5;

Then points are taken away in a block such as this

public void OnClientDisconnect_Post(int Client)
{
	ZomPoints[Client] = 0;

public Action ArtillaryStrike(int Client, int args) //&& ZomPoints[Client] >= 10 && HasRoundStarted
{
	if(bIsPlayerAlive[Client] && !bIsPlayerZombie[Client] && ZomPoints[Client] >= 10 && !ArtillaryRestriction[Client])
	{
	     ZomPoints[Client] -= 10;

I'm not sure the issue perhaps a more experienced eye could spot an error.

[8guawong]

wihtout the full code we can't help you
and stop posting in the wrong section

[Mitchell]

If you want expected results don't mix floats and ints.

[Halt]

Can a moderator please move this thread?

Originally Posted by Mitchell If you want expected results don't mix floats and ints.

Thanks for the tip, will fix. Can you explain why this is bad? (Just so I know for future reference)

[Maxximou5]

As Mitchell said, it's bad because you'll get unexpected results. If you need to give 0.5, set ZomPoints as a float and use it as such and convert it when necessary. Otherwise, increase your point system to where 0.5 becomes a value a 1 and use it as a int.
Also, you shouldn't mix old with new syntax either.

[Halt]

Originally Posted by Maxximou5 Also, you shouldn't mix old with new syntax either.

Currently trying to switch over to the new syntax. My script is a bit sloppy.

Where in here is old syntax?

[Maxximou5]

Your first code block.

PHP Code:

public Action At_Player_Death(Handle event, const String:name[], bool:dontBroadcast)
{
    new Client = GetClientOfUserId(GetEventInt(event, "userid"));
    new Attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
    if(bIsPlayerAlive[Attacker] && !bIsPlayerZombie[Attacker])
    {
        ZomPoints[Attacker] += 0.5; 


Should be:

PHP Code:

public Action At_Player_Death(Event event, const char[] name, bool dontBroadcast)
{
    int Client = GetClientOfUserId(event.GetInt("userid"));
    int Attacker = GetClientOfUserId(event.GetInt("attacker"));
    if(bIsPlayerAlive[Attacker] && !bIsPlayerZombie[Attacker])
    {
        ZomPoints[Attacker] += 0.5; 


[Halt]

Spoiler

Originally Posted by Maxximou5 Your first code block. PHP Code: public Action At_Player_Death(Handle event, const String:name[], bool:dontBroadcast) {     new Client = GetClientOfUserId(GetEventInt(event, "userid"));     new Attacker = GetClientOfUserId(GetEventInt(event, "attacker"));     if(bIsPlayerAlive[Attacker] && !bIsPlayerZombie[Attacker])     {         ZomPoints[Attacker] += 0.5;  Should be: PHP Code: public Action At_Player_Death(Event event, const char[] name, bool dontBroadcast) {     int Client = GetClientOfUserId(event.GetInt("userid"));     int Attacker = GetClientOfUserId(event.GetInt("attacker"));     if(bIsPlayerAlive[Attacker] && !bIsPlayerZombie[Attacker])     {         ZomPoints[Attacker] += 0.5;

Thanks! And when setting my float to zero it's just 0, not 0.0 correct?

[Maxximou5]

I believe it to be good practice to always add a dot delimiter like .0 when dealing with floats.
If it's a float, treat it as such and your code should show it.

[DarkDeviL]

Originally Posted by Halt Can a moderator please move this thread?

Posting that kind of stuff in public doesn't really help or bring any attention from the moderators/administrators:

Use the Report Post button near the thread, and put in a comment describing what issue you see, e.g. "Seems to be wrong section. I suggest moving the thread to Scripting", etc.