[nG_getwreck]

Hello, I have problem with this plugin.

I try adding a price and limit at the same item but it doesn't work..
Code:

PHP Code:

    else if(key == 3)
    {
        if((zp_ammopacks_get(id) >= 50) || (limit_antidote[id] < 2))
        {
            ze_give_antidote(id)
            zp_ammopacks_set(id, zp_ammopacks_get(id) - 50)
            limit_antidote[id]++
        }
        else(zp_ammopacks_get(id) <= 50)
        {
            client_printcolored(id, "!g[=SG=] !nYou don't have enough !gAmmoPacks !nto buy !tAnti-Dote")
        }
        if(limit_antidote[id] > 2)
        {
            limit_antidote[id]++
            client_printcolored("!g[=SG=] !nYou've reached the limit !g[2/2]")
        }
    }
    menu_destroy(menu)
    return PLUGIN_HANDLED
} 


[Natsheh]

PHP Code:


    else if(key == 3)
    {
        if(limit_antidote[id] >= 2)
        {
            client_printcolored("!g[=SG=] !nYou've reached the limit !g[2/2]")
        }

        else if((zp_ammopacks_get(id) >= 50))
        {
            ze_give_antidote(id)
            zp_ammopacks_set(id, zp_ammopacks_get(id) - 50)
            limit_antidote[id]++
        }
        else
        {
            client_printcolored(id, "!g[=SG=] !nYou don't have enough !gAmmoPacks !nto buy !tAnti-Dote")
        }
    } 


code order.

[LondoN]

if ( key == 3 )
{
	if ( zp_ammopacks_get ( pEntity ) < PRICE )
		return 1;

	if ( limit_antidote [ pEntity ] >= LIMIT_ANTIDOTE )
		return 1;

	limit_antidote [ pEntity ]++;
	zp_ammopacks_set ( pEntity, zp_ammopacks_get ( pEntity ) - PRICE );
	ze_give_antidote ( pEntity );
}

[Natsheh]

Originally Posted by LondoN if ( key == 3 ) { if ( zp_ammopacks_get ( pEntity ) < PRICE ) return 1; if ( limit_antidote [ pEntity ] >= LIMIT_ANTIDOTE ) return 1; limit_antidote [ pEntity ]++; zp_ammopacks_set ( pEntity, zp_ammopacks_get ( pEntity ) - PRICE ); ze_give_antidote ( pEntity ); }

can you explain why are you using return ? when the menu isn't destroyed ?

and why did you change id to pEntity ?

don't give any misleading code if you don't understand enough.

[LondoN]

Originally Posted by Natsheh can you explain why are you using return ? when the menu isn't destroyed ? and why did you change id to pEntity ? don't give any misleading code if you don't understand enough.

this is my style of codding..
but you're right about the return situation.

when i was do some tests for myself, if i don't used the return on verifications like this the code keeped running. for ex

if(money < price)
print(id, "no enought money")
else
give_bonus(id)

if my money was lower than the price the code keeped running, the print with no money shows but the bonus always execute.

idk, i just sayed, it's the 'metod' what works fine to me..

[Celena Luna]

PHP Code:

    else if(key == 3)
    {
        if(limit_antidote[id] == 2) //You only need to check if it equal 2 (max purchase), since it shouldn't be > 2 in the first place
            client_printcolored("!g[=SG=] !nYou've reached the limit !g[2/2]")
        else 
        {
            //everthing inside here only happened when limit < 2
            if(zp_ammopacks_get(id) < 50) 
                client_printcolored(id, "!g[=SG=] !nYou don't have enough !gAmmoPacks !nto buy !tAnti-Dote")
            else    
            {
                //everthing inside here only happened when limit < 2 and AP >= 50
                ze_give_antidote(id)
                zp_ammopacks_set(id, zp_ammopacks_get(id) - 50)
                limit_antidote[id]++
            }
        }  
    }
    menu_destroy(menu)
    return PLUGIN_HANDLED
} 


[Natsheh]

Oh wasn't paying attention.

Selena works but would be rather using else if than using else twice.

I fixed the code on post 2

[nG_getwreck]

Thanks for you answers, I prefer what natsheh suggests.

Solved