[Dragokas]

Hi,

PHP Code:

void UpdateList()
{
    char sPath0[PLATFORM_MAX_PATH] = "valentine/file.mp3";
    char sPath1[PLATFORM_MAX_PATH];
    File hFile = OpenFile("addons/sourcemod/data/music_mapstart.txt", "r");

    while( !hFile.EndOfFile() && hFile.ReadLine(sPath1, sizeof(sPath1)) )
    {
        break; // read first line only
    }
    
    PrintToServer("item 0: %s", sPath0);
    PrintToServer("item 1: %s", sPath1);
    
    PrintToServer("Str equal? %b", StrEqual(sPath0, sPath1));
    PrintToServer("len[0]: %i, len[1]: %i", strlen(sPath0), strlen(sPath1));
    
    // print codes of the last characters of each buffer
    PrintToServer("asc[15]: %i, asc[16]: %i, asc[17]: %i, asc[18]: %i", sPath0[15], sPath0[16], sPath0[17], sPath0[18] );
    PrintToServer("asc[17]: %i, asc[18]: %i, asc[19]: %i, asc[20]: %i", sPath1[17], sPath1[18], sPath1[19], sPath1[20] );
} 


item 0: valentine/file.mp3 item 1: valentine/file.mp3 Str equal? 0 len[0]: 18, len[1]: 20 asc[15]: 3371117, asc[16]: 13168, asc[17]: 51, asc[18]: 0 asc[17]: 658739, asc[18]: 2573, asc[19]: 10, asc[20]: 0

How is it possible non-binary file function return LF ?
Is 2573 mean CR? Why so strange code?

What kind of encoding is it - "13168" (0x3370) ? "p" character has no 2-byte analogue, afaik.

sm v.1.9

[adma]

I don't quite understand the problem, but when I have needed to read lines from a file I have always used TrimString before doing anything with the string retrieved by File.ReadLine(). e.g.

PHP Code:

while (!hFile.EndOfFile() && hFile.ReadLine(sBuffer, sizeof(sBuffer))) {
  TrimString(sBuffer);
  hArray.PushString(sBuffer);
} 


[Dragokas]

adma, problem is: ReadLine read to buffer line break character. So such line can't be used by e.g. EmitSound.
TrimString can't remove line breaks. It is intended for white space character only.
Non-binary functions should not return such character at all. For that kind of stuff Read() function is intended.

Second problem: why ASCII code of individual character of string have such strange code number.
51 - is a correct code of "3" character (last character of "valentine/file.mp3" string). 13168 - don't know, what is it.

UPD. I simplified code in 1-st post to reflect the problem as simple as possible.

I found this walkaround in "sm downloader" plugin:

PHP Code:

        len = strlen(buffer);
        if (buffer[len-1] == '\n')
            buffer[--len] = '\0'; 


But, actually I don't need such check. It is a bug in ReadLine() function.
sm v.1.10.6361 is also affected.

[Ilusion9]

PHP Code:

ReplaceStringEx(buffer, sizeof(buffer), "\n", "\0"); 


yes, file.ReadLine reads new line characters.

[asherkin]

Line breaks are whitespace.

[Dragokas]

asherkin, thanks, I see. I checked. It's definitely trim them.

[Dragokas]

Originally Posted by Dragokas PrintToServer("asc[15]: %i, asc[16]: %i, asc[17]: %i, asc[18]: %i", sPath0[15], sPath0[16], sPath0[17], sPath0[18] ); Is 2573 mean CR? Why so strange code? What kind of encoding is it - "13168" (0x3370) ? "p" character has no 2-byte analogue, afaik.

Ok, solved. Instead, it should be:

int c1, c2, c3, c4;
c1 = sPath0[15];
c2 = sPath0[16];
c3 = sPath0[17];
c4 = sPath0[18];

PrintToServer("asc[15]: %i, asc[16]: %i, asc[17]: %i, asc[18]: %i", c1, c2, c3, c4 );

Now, codes are printed correctly.

[Dragokas]

P.S. Possibly some problem or specific of sourcemod.
C++ handles both cases identically.