Raised This Month: $51 Target: $400
 12% 

[ANY] Anti Color Abuse


Post New Thread Reply   
 
Thread Tools Display Modes
Huntereb
>:) (:<
Join Date: Jul 2012
Old 09-25-2012 , 09:14   Re: [ANY] Anti Color Abuse
Reply With Quote #11

Quote:
Originally Posted by TheHardstyleBro View Post
Well how can I use it?

If it's for admins only
Just install it and people won't be able to use the glitch anymore, nothing to configure.
Huntereb is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 11-10-2012 , 00:15   Re: [ANY] Anti Color Abuse
Reply With Quote #12

Nice job!

You forgot to fill in your public cvar in your OP, so I did so for you.

Also, I'd recommend documenting the anticolorabuseflag override, which defaults to ADMFLAG_GENERIC, in the OP.

Finally, instead of this:

PHP Code:
g_bEnabled = (StringToInt(newValue) == false true); 
You could just use this:

PHP Code:
g_bEnabled bool:StringToInt(newValue); 
This will convert the integer into a bool, since all cells are the same in Pawn anyway, just tagged differently. If you were unable to tag it for any reason, you should do this:

PHP Code:
g_bEnabled = (StringToInt(newValue) == 1); 
The (StringToInt(newValue) == 1) returns a boolean result, no need to use a conditional.

Either way, good job. I'd love to see this implemented directly into the processor.
__________________
Dr. McKay is offline
11530
Veteran Member
Join Date: Sep 2011
Location: Underworld
Old 11-10-2012 , 15:35   Re: [ANY] Anti Color Abuse
Reply With Quote #13

Quote:
Originally Posted by Dr. McKay View Post
Nice job!

You forgot to fill in your public cvar in your OP, so I did so for you.
Yea for some reason whenever I edit the public cvar myself it doesn't take effect.

Quote:
Originally Posted by Dr. McKay View Post
Also, I'd recommend documenting the anticolorabuseflag override, which defaults to ADMFLAG_GENERIC, in the OP.
Done

Quote:
Originally Posted by Dr. McKay View Post

Finally, instead of this:

PHP Code:
g_bEnabled = (StringToInt(newValue) == false true); 
You could just use this:

PHP Code:
g_bEnabled bool:StringToInt(newValue); 
This will convert the integer into a bool, since all cells are the same in Pawn anyway, just tagged differently. If you were unable to tag it for any reason, you should do this:

PHP Code:
g_bEnabled = (StringToInt(newValue) == 1); 
The (StringToInt(newValue) == 1) returns a boolean result, no need to use a conditional.

Either way, good job. I'd love to see this implemented directly into the processor.
I've never been a great fan of casting, even in an almost typeless language. Your last expression isn't quite the same as mine however. Mine will set the variable to false if the convar is 0, and true for everything else. Yours sets the variable to true if the convar is 1 and false for everything else. Granted, I could use:

PHP Code:
g_bEnabled = (StringToInt(newValue) != 0); 
But I may as well stick to mine since they'd be synonymous and I'm a lazy critter.
__________________

Last edited by 11530; 11-11-2012 at 00:05.
11530 is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 11-10-2012 , 16:29   Re: [ANY] Anti Color Abuse
Reply With Quote #14

Quote:
Originally Posted by 11530 View Post
Yea for some reason whenever I edit the public cvar myself it doesn't take effect.
If you change the public cvar, it requires an unapproval and reapproval, so that's why that happens.
__________________
Dr. McKay is offline
11530
Veteran Member
Join Date: Sep 2011
Location: Underworld
Old 11-10-2012 , 17:01   Re: [ANY] Anti Color Abuse
Reply With Quote #15

Quote:
Originally Posted by Dr. McKay View Post
If you change the public cvar, it requires an unapproval and reapproval, so that's why that happens.
Ah interesting, even from blank?
__________________

Last edited by 11530; 11-10-2012 at 17:01.
11530 is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 11-10-2012 , 19:57   Re: [ANY] Anti Color Abuse
Reply With Quote #16

Quote:
Originally Posted by 11530 View Post
Ah interesting, even from blank?
Yup.
__________________
Dr. McKay is offline
vodka00
Veteran Member
Join Date: Jun 2012
Location: Los Angeles
Old 11-30-2012 , 13:56   Re: [ANY] Anti Color Abuse
Reply With Quote #17

It seems that people are still able to use colors even when I have this plugin running. Help please.
__________________
cw main:

cw speedruns:
vodka00 is offline
Horsedick
AlliedModders Donor
Join Date: Sep 2011
Old 11-30-2012 , 18:50   Re: [ANY] Anti Color Abuse
Reply With Quote #18

Quote:
Originally Posted by vodka00 View Post
It seems that people are still able to use colors even when I have this plugin running. Help please.
explain how? You didn't give much information with this.
Horsedick is offline
vodka00
Veteran Member
Join Date: Jun 2012
Location: Los Angeles
Old 11-30-2012 , 20:29   Re: [ANY] Anti Color Abuse
Reply With Quote #19

Quote:
Originally Posted by Horsedick View Post
explain how? You didn't give much information with this.
Well, they are not telling me. I just assume they are using same method this plugin is trying to block. Unless there is a different method for Eventscripts.
__________________
cw main:

cw speedruns:
vodka00 is offline
Horsedick
AlliedModders Donor
Join Date: Sep 2011
Old 11-30-2012 , 21:49   Re: [ANY] Anti Color Abuse
Reply With Quote #20

Quote:
Originally Posted by vodka00 View Post
Well, they are not telling me. I just assume they are using same method this plugin is trying to block. Unless there is a different method for Eventscripts.

lol who is they? Post some SteamID's so rest of can be on the look out and perhaps ask them or view the logs from our end. Look at your logs they can't skirt the logs it will show up in those.

Last edited by Horsedick; 11-30-2012 at 21:50.
Horsedick is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 21:44.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode