[Craxor]

Originally Posted by EFFx Like csgo, an enemy will receive the bonus every disconnect. But i dont recommend it for public server, this plugin is good for pug servers. But if you guys want him for public server, who is me for be against?

Yea yea is nice don't worry, personaly i like it.

[EFFx]

Thank you, i appreciate it.

[addons_zz]

And here I thinking there is nothing new to do for the AMXX. Seems cool install it on my server.

[EFFx]

Originally Posted by addons_zz And here I thinking there is nothing new to do for the AMXX. Seems cool install it on my server.

I appreciate it.

Has so much thing for do on amxx, just open your mind for think in one.

[HamletEagle]

Well, looks mostly fine. Few things I would suggest:
-add ML
-Is HasTeam check really needed in Event_DeathMsg? I don't think so.
-Remove "public" from GiveCompensation, not everything has to be public. You would use that for functions that may be called from other plugin/modules. Your function can be private.
-You are using way too many (). For example:

PHP Code:

if ( ( iPlayers[ i ] != iCompensatePlayer ) )
if ( ( iKiller == iVictim ) && ( HasTeam( iKiller ) ) ) 


And with the addition spaces your code becomes harder to read.
-In your two loops don't reindex the iPlayers array.

[EFFx]

All things added, just:

What you mean with "reindex the iPlayers array"?

[addons_zz]

I think it is this:

    for( new index = 0; index < playersCount; index++ )
    {
        server_print( "I am indexing the player %d, for the fist time", players[ index ] )
        server_print( "I am re-indexing the player %d, for the second time", players[ index ] )
    }

Versus this:

    new player_id;

    for( new index = 0; index < playersCount; index++ )
    {
        player_id = players[ index ];

        server_print( "I am indexing the player %d, for the fist time", player_id )
        server_print( "I am still indexing the player %d, for the first time", player_id )
    }

When you access an array more than one time, cache its value on a variable, otherwise you will to spend CPU time recalculating the array index each time.
When you do `players[ index ]`, the computer does:

players array base address + index

After it it finally access the index you want to. However, if you cache the value, this calculation is performed only only time for that index, saving CPU cycles.

[EFFx]

I have two loopings, the first is for give a message for the compensate player's team. And the other is for give a message for the enemy team of the compensate player. How you suggest to edit there?

[addons_zz]

Hey, if you understood what I said, you already know were it is.

Update: I checked you code, it is there on both your loops, and it is looking for you, just waiting for you to see it.

[EFFx]

Yes, I understand what you said, but both loopings is for different teams.

PHP Code:

        new PlayersID

        for(new i = 0;i < iNumPlayers;i++) 
        { 
            PlayersID = szPlayers[i]

            if(PlayersID != iCompensatePlayer) 
            { 
                compensation_chatcolor(szPlayers[ i ] , "%s %L",szPrefix,szPlayers[i],"TEAM_COMPENSATE_PLAYER_MESSAGE",szCompensateName,iRandom <= 4 ? iMoneyBonus_First : iMoneyBonus_Second,szDeadName) 
            } 
        } 

        get_players(szPlayers,iNumPlayers,"eh",szOppositeTeams[cs_get_user_team(iCompensatePlayer)]) 
        for(new i = 0;i < iNumPlayers;i++) 
        { 
            PlayersID = szPlayers[i]

            if(PlayersID != iDeadPlayer)
                compensation_chatcolor(szPlayers[i],"%s %L",szPrefix,szPlayers[i],"ENEMY_COMPENSATE_MESSAGE",iRandom <= 4 ? iMoneyBonus_First : iMoneyBonus_Second,szDeadName) 
        } 


This?