[zmd94]

Welcome.

[Kotoamatsukami]

PHP Code:

for(i = 0; i < iPlayerCount; i++)
        {
            id = iPlayers[i] 


Pardon, curious on something here.
The above code, isn't this re-indexing? I though you can just use the 'i' as the index instead?

[addons_zz]

No, on the above code there are no re-indexing. On the above code you cannot refer to the players by the index on the `i` variable, because:

1. the players ids are from 1 until 32.
2. the playersCount can low as 10.

For example, on the server there are 10 players with the id's 4, 31, 23, 1, 3, 9, 5, 15, 19, 22.
And doing a loop from 0 until 10 will:

1. get the invalid players 2, 6, 7, 8
2. and not get the valid players 31, 23, 22, 19, 15, 23

When we do get_players( players, playersCount ), we:

1. get an array within the 4, 31, 23, 1, 3, 9, 5, 15, 19, 22.
2. And doing a loop on that array from 0 until 10 accessing each array's index we got all the valid players we want to, because the get_players( players, playersCount ) will fill the array within the valid ids 4, 31, 23, 1, 3, 9, 5, 15, 19, 22.

This is re-indexing:

for(i = 0; i < iPlayerCount; i++)
    {
        // accessing the same array position more than one time.
        client_print( iPlayers[i], print_chat, "Hi1" );
        client_print( iPlayers[i], print_chat, "Hi2" );
    }

This is not re-indexing:

new id;
for(i = 0; i < iPlayerCount; i++)
    {
        id = iPlayers[i];

        // not accessing the same array position more than one time.
        client_print( id, print_chat, "Hi1" );
        client_print( id, print_chat, "Hi2" );
    }

More low code about why the reindexing is happening:

for(i = 0; i < iPlayerCount; i++)
    {
        // re-indexing come from the fact where each time you access
        // an array index, the computer has to to a sum before it.
        client_print( (iPlayers + i), print_chat, "Hi1" );
        client_print( (iPlayers + i), print_chat, "Hi2" );

        // (iPlayers + i) <-- this is not a valid code, just for illustrate the sum the computer is doing behind the scenes.
    }

-->

new id;
for(i = 0; i < iPlayerCount; i++)
    {
        // caching the value, we only do this sum one time.
        id = (iPlayers + i); 

        client_print( id, print_chat, "Hi1" );
        client_print( id, print_chat, "Hi2" );

        // (iPlayers + i) <-- this is not a valid code, just for illustrate the sum the computer is doing behind the scenes.
    }

For more details see: https://wiki.alliedmods.net/Optimizing_Plugins_(AMX_Mod_X_Scripting)#Don. 27t_Re-index_Arrays

[Kotoamatsukami]

Originally Posted by addons_zz No, on the above code there are no re-indexing. On the above code you cannot refer to the players by the index on the `i` variable, because: the players ids are from 1 until 32. the playersCount can low as 10. For example, on the server there are 10 players with the id's 4, 31, 23, 1, 3, 9, 5, 15, 19, 22. And doing a loop from 0 until 10 will: get the invalid players 2, 6, 7, 8 and not get the valid players 31, 23, 22, 19, 15, 23 When we do get_players( players, playersCount ), we: get an array within the 4, 31, 23, 1, 3, 9, 5, 15, 19, 22. And doing a loop on that array from 0 until 10 accessing each array's index we got all the valid players we want to, because the get_players( players, playersCount ) will fill the array within the valid ids 4, 31, 23, 1, 3, 9, 5, 15, 19, 22. This is re-indexing: for(i = 0; i < iPlayerCount; i++)     {         // accessing the same array position more than one time.         client_print( iPlayers[i], print_chat, "Hi1" );         client_print( iPlayers[i], print_chat, "Hi2" );     } This is not re-indexing: new id; for(i = 0; i < iPlayerCount; i++)     {         id = iPlayers[i];         // not accessing the same array position more than one time.         client_print( id, print_chat, "Hi1" );         client_print( id, print_chat, "Hi2" );     } More low code about why the reindexing is happening: for(i = 0; i < iPlayerCount; i++)     {         // re-indexing come from the fact where each time you access         // an array index, the computer has to to a sum before it.         client_print( (iPlayers + i) , print_chat, "Hi1" );         client_print( (iPlayers + i), print_chat, "Hi2" );         // (iPlayers + i) <-- this is not a valid code, just for illustrate the sum the computer is doing behind the scenes.     } --> new id; for(i = 0; i < iPlayerCount; i++)     {         // caching the value, we only do this sum one time.         id = (iPlayers + i);         client_print( id, print_chat, "Hi1" );         client_print( id, print_chat, "Hi2" );         // (iPlayers + i) <-- this is not a valid code, just for illustrate the sum the computer is doing behind the scenes.     } For more details see: https://wiki.alliedmods.net/Optimizing_Plugins_(AMX_Mod_X_Scripting)#Don. 27t_Re-index_Arrays

That was marvelous!
Understood, sir. Thank you.

[instinctpt1]

A Serious Bug please Fix ...

When a War is going on ; if someone connects in between to server he can get random guns regardless of SPecial War which is going on and also VIP plugin also interupts this plugin bcoz of VIP menu opened on Player's Screen ====> Like a Admin Started SPR then all will get that GUN , but VIP menu is still open on VIP's Screen then they will select desired GUN from VIP menu and hence then can overpass Special Round (SPR) and disturbs whole Server ||

But its not the case with knife .. Knife Works PERFECTLY !! ( Both problems are not there in Knife )

[zmd94]

Really appreciate your report, Instinctpt. Yet, I just want more comfirmation.

Although, player can get other gun that current gun of weapon war, they still cannot use it right? The gun will be mulfunction.

[instinctpt1]

Originally Posted by zmd94 Really appreciate your report, Instinctpt. Yet, I just want more comfirmation.

No no

Look its like this :
1=> Sometimes its caused by VIP menu when SPECIAL WAR starts , VIP quickly take another GUN from the menu which is still open (VIP MENU of too many other GUns) on their Screen ( So now they are not exactly same like others )

2=> Whenever someone (new) enters the server During SPECIAL WAR ; they can now buy anything they likes

3=> During SPECIAL WAR of any Weapon Ex. TMP or any GUN is going on, Players can still buy like just Press F1 and yippee you got m4 too powerful then TMP , now they disturbs everyone

....... i dont knw but this only happens with GUNS ... Knife and grenades Round are not affected and they have no Bugs

[zmd94]

Although, player can get or buy other gun than current gun of weapon war, they still cannot use it right? The gun will be mulfunction.

[instinctpt1]

Nope its not malfunctioning they are Getting it very well and can use it Properly

[zmd94]

It is weird as the code should block it. Please try to put this plugin in the first place in your plugins.ini file.