[TheFlyingApple]

Hi,

I'm trying to create a script that slaps someone every 2 seconds, 30 seconds into the round. However, the slap timer never stops, which means that on the next round start, everyone will be slapped instantly.. What am I doing wrong?

PHP Code:

#pragma semicolon 1
#pragma newdecls required 
#include <sourcemod>
#include <sdktools>
#include <multicolors>

new Handle:g_timerAntiCamp1 = INVALID_HANDLE;
new Handle:g_timerAntiCamp2 = INVALID_HANDLE;

public OnPluginStart()
{
    HookEvent("round_start", Round_Start_Hook);
    HookEvent("round_end", Round_End_Hook);
}

public OnMapEnd()
{
    g_timerAntiCamp1 = INVALID_HANDLE;
    g_timerAntiCamp2 = INVALID_HANDLE;
}

public Action Round_Start_Hook(Handle event, const char[] name, bool dontBroadcast)
{    
    g_timerAntiCamp1 = CreateTimer(30.0, CheckRoundTime, TIMER_FLAG_NO_MAPCHANGE);
}

public Action Round_End_Hook(Handle event, const char[] name, bool dontBroadcast)
{
    /* Clean up timers */
    if (g_timerAntiCamp1 != INVALID_HANDLE) {
        CloseHandle(g_timerAntiCamp1);
        g_timerAntiCamp1 = INVALID_HANDLE;
    }

    if (g_timerAntiCamp2 != INVALID_HANDLE) {
        CloseHandle(g_timerAntiCamp2);
        g_timerAntiCamp2 = INVALID_HANDLE;
    }
    
}

public Action CheckRoundTime(Handle:timer)
{
    g_timerAntiCamp2 = CreateTimer(2.0, CheckPlayerZone, TIMER_FLAG_NO_MAPCHANGE|TIMER_REPEAT);
}

public Action CheckPlayerZone(Handle:timer) 
{
    for (new i = 1; i <= MaxClients; i++)
    {
        if (i >= 1 && i <= MaxClients && IsClientConnected(i) && IsClientInGame(i) && IsPlayerAlive(i))
        {

            SlapPlayer(i, 20, true);
            CPrintToChat(i, "{green}You are getting slapped");
        }
    }
} 


[ddhoward]

Why the old syntax? You've even got #newdecls required but you're not using the newdecls?

Also, why the extra i >= 1 && i <= MaxClients check? You're already looping i through 1 and MaxClients; it's guaranteed to be within that range. Also, IsClientInGame() has a IsClientConnected() check built in.

PHP Code:

#pragma newdecls required 
#include <sourcemod>
#include <sdktools>
#include <multicolors>

Handle g_timerAntiCamp1;
Handle g_timerAntiCamp2;

public void OnPluginStart()
{
    HookEvent("round_start", Round_Start_Hook);
    HookEvent("round_end", Round_End_Hook);
}

public void OnMapEnd()
{
    delete g_timerAntiCamp1;
    delete g_timerAntiCamp2;
}

public Action Round_Start_Hook(Handle event, const char[] name, bool dontBroadcast)
{    
    g_timerAntiCamp1 = CreateTimer(30.0, CheckRoundTime, TIMER_FLAG_NO_MAPCHANGE);
}

public Action Round_End_Hook(Handle event, const char[] name, bool dontBroadcast)
{
    delete g_timerAntiCamp1;
    delete g_timerAntiCamp2;
    PrintToConsoleAll("Round ended, timers deleted");
}

public Action CheckRoundTime(Handle timer)
{
    g_timerAntiCamp2 = CreateTimer(2.0, CheckPlayerZone, TIMER_FLAG_NO_MAPCHANGE|TIMER_REPEAT);
}

public Action CheckPlayerZone(Handle timer) 
{
    for (int i = 1; i <= MaxClients; i++)
    {
        if (IsClientInGame(i) && IsPlayerAlive(i))
        {

            SlapPlayer(i, 20, true);
            CPrintToChat(i, "{green}You are getting slapped");
        }
    }
} 


My suggestion would be to add some debug text in the round end hook, to see if that's even actually firing. I've added such text above.

[8guawong]

Originally Posted by TheFlyingApple Hi, I'm trying to create a script that slaps someone every 2 seconds, 30 seconds into the round. However, the slap timer never stops, which means that on the next round start, everyone will be slapped instantly.. What am I doing wrong? PHP Code: #pragma semicolon 1 #pragma newdecls required  #include <sourcemod> #include <sdktools> #include <multicolors> new Handle:g_timerAntiCamp1 = INVALID_HANDLE; new Handle:g_timerAntiCamp2 = INVALID_HANDLE; public OnPluginStart() {     HookEvent("round_start", Round_Start_Hook);     HookEvent("round_end", Round_End_Hook); } public OnMapEnd() {     g_timerAntiCamp1 = INVALID_HANDLE;     g_timerAntiCamp2 = INVALID_HANDLE; } public Action Round_Start_Hook(Handle event, const char[] name, bool dontBroadcast) {         g_timerAntiCamp1 = CreateTimer(30.0, CheckRoundTime, TIMER_FLAG_NO_MAPCHANGE); } public Action Round_End_Hook(Handle event, const char[] name, bool dontBroadcast) {     /* Clean up timers */     if (g_timerAntiCamp1 != INVALID_HANDLE) {         CloseHandle(g_timerAntiCamp1);         g_timerAntiCamp1 = INVALID_HANDLE;     }     if (g_timerAntiCamp2 != INVALID_HANDLE) {         CloseHandle(g_timerAntiCamp2);         g_timerAntiCamp2 = INVALID_HANDLE;     }      } public Action CheckRoundTime(Handle:timer) {     g_timerAntiCamp2 = CreateTimer(2.0, CheckPlayerZone, TIMER_FLAG_NO_MAPCHANGE|TIMER_REPEAT); } public Action CheckPlayerZone(Handle:timer)  {     for (new i = 1; i <= MaxClients; i++)     {         if (i >= 1 && i <= MaxClients && IsClientConnected(i) && IsClientInGame(i) && IsPlayerAlive(i))         {             SlapPlayer(i, 20, true);             CPrintToChat(i, "{green}You are getting slapped");         }     } }

did you check to see if there are any errors in your log?

[Dragokas]

TheFlyingApple,

Minimal sample "How to stop (delete) global repeatable timer on round end"

[TheFlyingApple]

I have updated the code a bit... It looks like this now:

PHP Code:

#pragma semicolon 1
#pragma newdecls required 
#include <sourcemod>
#include <sdktools>
#include <multicolors>

Handle g_timerAntiCamp1;
Handle g_timerAntiCamp2;

public void OnPluginStart()
{
    HookEvent("round_start", Round_Start_Hook);
}

public void OnMapEnd()
{
    delete g_timerAntiCamp1;
    delete g_timerAntiCamp2;
}

public Action Round_Start_Hook(Handle event, const char[] name, bool dontBroadcast)
{
    delete g_timerAntiCamp1;
    g_timerAntiCamp1 = CreateTimer(30.0, CheckRoundTime);
}

public Action CheckRoundTime(Handle timer)
{
    delete g_timerAntiCamp2;
    g_timerAntiCamp2 = CreateTimer(2.0, CheckPlayerZone, _, TIMER_REPEAT);
}

public Action CheckPlayerZone(Handle:timer) 
{
    for (new i = 1; i <= MaxClients; i++)
    {
        if (IsClientConnected(i) && IsClientInGame(i) && IsPlayerAlive(i))
        {
            SlapPlayer(i, 20, true);
            CPrintToChat(i, "{green}You are being slapped!");
        }
    }
} 


Originally Posted by 8guawong did you check to see if there are any errors in your log?

I get the following message in console:

PHP Code:

[SM] Exception reported: Handle a9a07e3 is invalid (error 1)
[SM] Blaming: slap.smx
[SM] Call stack trace:
[SM]   [0] CloseHandle
[SM]   [1] Line 34, slap.sp::Round_Start_Hook 


Which is pointing to the line

PHP Code:

delete g_timerAntiCamp1; 


Originally Posted by Dragokas TheFlyingApple, Minimal sample "How to stop (delete) global repeatable timer on round end"

I tried that with my code. It did not solve the problem. The timer is still running after round end.

[Dragokas]

Because you didn't zeroed single timer's handle when it is no more valid (in callback).

PHP Code:

#pragma semicolon 1 
#pragma newdecls required

#include <sourcemod> 
#include <sdktools> 
#include <multicolors> 

Handle g_timerAntiCamp1;
Handle g_timerAntiCamp2;

public void OnPluginStart()
{
    HookEvent("round_start", Round_Start_Hook);
    HookEvent("round_end", Round_End_Hook);
}

public void OnMapEnd()
{
    delete g_timerAntiCamp1; 
    delete g_timerAntiCamp2; 
}

public Action Round_End_Hook(Handle event, const char[] name, bool dontBroadcast) 
{
    delete g_timerAntiCamp1; 
    delete g_timerAntiCamp2; 
}

public Action Round_Start_Hook(Handle event, const char[] name, bool dontBroadcast) 
{ 
    delete g_timerAntiCamp1; 
    g_timerAntiCamp1 = CreateTimer(30.0, CheckRoundTime); 
} 

public Action CheckRoundTime(Handle timer) 
{ 
    delete g_timerAntiCamp2;
    g_timerAntiCamp2 = CreateTimer(2.0, CheckPlayerZone, _, TIMER_REPEAT); 
    g_timerAntiCamp1 = INVALID_HANDLE;
}

public Action CheckPlayerZone(Handle timer)
{
    for (int i = 1; i <= MaxClients; i++)
    {
        if (IsClientInGame(i) && IsPlayerAlive(i)) 
        {
            SlapPlayer(i, 20, true); 
            CPrintToChat(i, "{green}You are being slapped!"); 
        }
    }
    return Plugin_Continue;
} 


[Marttt]

I don't think you need control the handles for this.
Also, usually is good to use TIMER_FLAG_NO_MAPCHANGE flag with TIMER_REPEAT

Try this modifications:

Spoiler

PHP Code:

#pragma semicolon 1
#pragma newdecls required
#include <sourcemod>
#include <sdktools>
#include <multicolors>

static bool g_Stop;

public void OnPluginStart()
{
    HookEvent("round_start", Round_Start_Hook);
}

public void OnMapEnd()
{
    g_Stop = true;
}

public Action Round_Start_Hook(Handle event, const char[] name, bool dontBroadcast)
{
    CreateTimer(30.0, CheckRoundTime);
}

public Action CheckRoundTime(Handle timer)
{
    CreateTimer(2.0, CheckPlayerZone, _, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
}

public Action CheckPlayerZone(Handle timer)
{
    if (!g_Stop)
        return Plugin_Stop;

    for (int i = 1; i <= MaxClients; i++)
    {
        if (IsClientConnected(i) && IsClientInGame(i) && IsPlayerAlive(i))
        {
            SlapPlayer(i, 20, true);
            CPrintToChat(i, "{green}You are being slapped!");
        }
    }

    return Plugin_Continue;
} 


[TheFlyingApple]

Originally Posted by Dragokas Because you didn't zeroed single timer's handle when it is no more valid (in callback). PHP Code: #pragma semicolon 1  #pragma newdecls required #include <sourcemod>  #include <sdktools>  #include <multicolors>  Handle g_timerAntiCamp1; Handle g_timerAntiCamp2; public void OnPluginStart() {     HookEvent("round_start", Round_Start_Hook);     HookEvent("round_end", Round_End_Hook); } public void OnMapEnd() {     delete g_timerAntiCamp1;      delete g_timerAntiCamp2;  } public Action Round_End_Hook(Handle event, const char[] name, bool dontBroadcast)  {     delete g_timerAntiCamp1;      delete g_timerAntiCamp2;  } public Action Round_Start_Hook(Handle event, const char[] name, bool dontBroadcast)  {      delete g_timerAntiCamp1;      g_timerAntiCamp1 = CreateTimer(30.0, CheckRoundTime);  }  public Action CheckRoundTime(Handle timer)  {      delete g_timerAntiCamp2;     g_timerAntiCamp2 = CreateTimer(2.0, CheckPlayerZone, _, TIMER_REPEAT);      g_timerAntiCamp1 = INVALID_HANDLE; } public Action CheckPlayerZone(Handle timer) {     for (int i = 1; i <= MaxClients; i++)     {         if (IsClientInGame(i) && IsPlayerAlive(i))          {             SlapPlayer(i, 20, true);              CPrintToChat(i, "{green}You are being slapped!");          }     }     return Plugin_Continue; }

I tried that code... Just gave me a new warning:

[SM] Plugin "devzones_anticampslap.smx" encountered error 23: Native detected error
[SM] Invalid timer handle 117b07ed (error 3) during timer end, displayed function is timer callback, not the stack trace
[SM] Unable to call function "CheckPlayerZone" due to above error(s).

[TheFlyingApple]

Originally Posted by Marttt I don't think you need control the handles for this. Also, usually is good to use TIMER_FLAG_NO_MAPCHANGE flag with TIMER_REPEAT Try this modifications: Spoiler PHP Code: #pragma semicolon 1 #pragma newdecls required #include <sourcemod> #include <sdktools> #include <multicolors> static bool g_Stop; public void OnPluginStart() {     HookEvent("round_start", Round_Start_Hook); } public void OnMapEnd() {     g_Stop = true; } public Action Round_Start_Hook(Handle event, const char[] name, bool dontBroadcast) {     CreateTimer(30.0, CheckRoundTime); } public Action CheckRoundTime(Handle timer) {     CreateTimer(2.0, CheckPlayerZone, _, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE); } public Action CheckPlayerZone(Handle timer) {     if (!g_Stop)         return Plugin_Stop;     for (int i = 1; i <= MaxClients; i++)     {         if (IsClientConnected(i) && IsClientInGame(i) && IsPlayerAlive(i))         {             SlapPlayer(i, 20, true);             CPrintToChat(i, "{green}You are being slapped!");         }     }     return Plugin_Continue; }

I now tried this. The problem is still the same.. When a new round starts slapping begins immediately.. No errors in console, though!

[Dragokas]

TheFlyingApple, you have the problem somewhere else, not in the part of my code.

Marttt, he wants to stop timer on round end, not only on map end.