[lake393]

Hello, I am trying to modify the base plugin sm_beacon to act like accept an additional parameter of 0 or 1 instead of acting like a toggle.

For instance, instead of typing sm_beacon #userid, I want to type sm_beacon #userid 1 to turn it on, and sm_beacon #userid 0 to turn it off.

I am looking in beacon.sp at the Action:Command_Beacon() function.

Can I call CreateBeacon() and KillBeacon() directly from the Command_Beacon() function? I have concerns with what will happen if I call CreateBeacon on a target who already has a beacon, or if I call KillBeacon on a target that does not have a beacon.

Sorry, I really don't know what I'm doing in this language. Any assistance would be greatly appreciated.

[Flynn]

Well, whilst I find it mind-boggingly illogical as to why you could possibly want this, I took the liberty of making the simple modifications to the code to enable this. I don't guarantee it will work.

First, open beacon (make a backup copy!), find and replace PerformBeacon with this...

PerformBeacon(client, target, bool:set)
{
	if(set)
	{

		if (g_BeaconSerial[target] == 0)
		{
			CreateBeacon(target);
			LogAction(client, target, "\"%L\" set a beacon on \"%L\"", client, target);
		}
	}
	else
	{
		if(g_BeaconSerial[target] != 0)
		{
			KillBeacon(target);
			LogAction(client, target, "\"%L\" removed a beacon on \"%L\"", client, target);
		}
	}
}

And find and replace Command_Beacon with this:

public Action:Command_Beacon(client, args)
{
	if (args < 2)
	{
		ReplyToCommand(client, "[SM] Usage: sm_beacon <#userid|name> <set>");
		return Plugin_Handled;
	}

	decl String:arg[65];
	decl bool:set;
	
	GetCmdArg(2, arg, sizeof(arg));
	set = StringToInt(arg);

	GetCmdArg(1, arg, sizeof(arg));
	

	decl String:target_name[MAX_TARGET_LENGTH];
	decl target_list[MAXPLAYERS], target_count, bool:tn_is_ml;
	
	if ((target_count = ProcessTargetString(
			arg,
			client,
			target_list,
			MAXPLAYERS,
			COMMAND_FILTER_ALIVE,
			target_name,
			sizeof(target_name),
			tn_is_ml)) <= 0)
	{
		ReplyToTargetError(client, target_count);
		return Plugin_Handled;
	}
	
	for (new i = 0; i < target_count; i++)
	{
		PerformBeacon(client, target_list[i]);
	}
	
	if (tn_is_ml)
	{
		ShowActivity2(client, "[SM] ", "%t", "Toggled beacon on target", target_name);
	}
	else
	{
		ShowActivity2(client, "[SM] ", "%t", "Toggled beacon on target", "_s", target_name);
	}
	
	return Plugin_Handled;
}

Compile funcommands. It will probably produce a warning about the conversion of an int to a bool, however this is a cheap-hack (which I also can't guarantee will work).

It will now require two arguments. The ID and the boolean operator for on and off.

[ilovelamp]

Hehe, I asked him to do it, we're trying to phase out Mani admin on our Jailbreak server, and bonbon's code uses ma_beacon (which has the toggle), and we're trying to port it to SM (which currently doesn't have a boolean toggle).

And it's on a linux box which crashes every time we load ESTools >.>

[lake393]

wow thanks flynn! We will check this out right away!!!

[Flynn]

I hope it works out. If it doesn't, report the fault as best as you can and I'll try to fix it. The more information I have to work with, the better I do something.

[lake393]

Flynn, there was an error error 092: number of arguments does not match the definition. I believe I know what the problem is, but I am confused a bit.

This section:

PHP Code:

public Action:Command_Beacon(client, args)
{
    if (args < 2)
    {
        ReplyToCommand(client, "[SM] Usage: sm_beacon <#userid|name> <set>");
        return Plugin_Handled;
    } 


This is the last time the variable args is used. It is never used again.

I think I need to use it for this somehow:

PHP Code:

    for (new i = 0; i < target_count; i++)
    {
        PerformBeacon(client, target_list[i]);
    } 


Doesn't it need to pass a third parameter, like args[1] ?

Thank you for deciding to help us

Also, would it be advisable to take all the menu functions out of this? We won't need them for this purpose, but I don't want to break anything if they are needed.

[Flynn]

No, the number of arguments is the incorrect number of arguments being passed, not 'args' (which is just a variable called args and isn't actually 'arguments' per se).

Replace Command_Beacon with this and recompile.

public Action:Command_Beacon(client, args)
{
	if (args < 2)
	{
		ReplyToCommand(client, "[SM] Usage: sm_beacon <#userid|name> <set>");
		return Plugin_Handled;
	}

	decl String:arg[65];
	decl bool:set;
	
	GetCmdArg(2, arg, sizeof(arg));
	set = StringToInt(arg);

	GetCmdArg(1, arg, sizeof(arg));
	

	decl String:target_name[MAX_TARGET_LENGTH];
	decl target_list[MAXPLAYERS], target_count, bool:tn_is_ml;
	
	if ((target_count = ProcessTargetString(
			arg,
			client,
			target_list,
			MAXPLAYERS,
			COMMAND_FILTER_ALIVE,
			target_name,
			sizeof(target_name),
			tn_is_ml)) <= 0)
	{
		ReplyToTargetError(client, target_count);
		return Plugin_Handled;
	}
	
	for (new i = 0; i < target_count; i++)
	{
		PerformBeacon(client, target_list[i], set);
	}
	
	if (tn_is_ml)
	{
		ShowActivity2(client, "[SM] ", "%t", "Toggled beacon on target", target_name);
	}
	else
	{
		ShowActivity2(client, "[SM] ", "%t", "Toggled beacon on target", "_s", target_name);
	}
	
	return Plugin_Handled;
}

Helps if I actually make use of the updated function.

[lake393]

Hi Flynn, sorry about the late reply. These are the error's we're getting with the code now. I see some errors relating to the menu. its ok with us if we just get rid of the menu all together if that's possible.

Thanks!

[Flynn]

Originally Posted by lake393 Hi Flynn, sorry about the late reply. These are the error's we're getting with the code now. I see some errors relating to the menu. its ok with us if we just get rid of the menu all together if that's possible.

You're compiling beacon.sp. You need to Compile funcommands.sp (which incorporates beacon.sp into it).

[lake393]

Hello, we just tried compiling funcommands and it complained about this:

Error on line 193 ... number of arguments does not match

PerformBeacon(param1, target);

This is under the MenuHandler_Beacon function



Also, this line (217) has a minor error that says Tag Missmatch

set = StringToInt(arg);