[MeRcyLeZZ]

Any ideas why this won't compile?

#include <amxmodx>

#define flag_unset(%1,%2) (%1 &= ~( 1 << ( %2 & 31 ) ) )

new g_IsAdmin, g_IsZombie

public client_disconnect(id)
{
    flag_unset(g_IsAdmin, id)
    flag_unset(g_IsZombie, id)
}

EDIT: Solved, just add a semicolon at the end of the macro:

#define flag_unset(%1,%2) (%1 &= ~( 1 << ( %2 & 31 ) ) ); 

[Exolent[jNr]]

Just remove the parenthesis from around the whole expression and it will work.

[vitorrossi]

PHP Code:

new g_bfAlive;

#define UserAlive(%1)                g_bfAlive |= (1 << (%1 & 31))
#define NotAlive(%1)                g_bfAlive &= ~(1 << (%1 & 31))
#define isAlive(%1)                    g_bfAlive & (1 << (%1 & 31)) 


PHP Code:

if(!isAlive(id))
{ ... 


The if statement gives me tag mismatch. But if I use

PHP Code:

if(isAlive(id) == 0)
{ ... 


Then it works. Why?

[Arkshine]

Add () in the macro.

#define UserAlive(%1) (g_bfAlive |= (1 << (%1 & 31)))
#define NotAlive(%1) (g_bfAlive &= ~(1 << (%1 & 31)))
#define isAlive(%1) (g_bfAlive & (1 << (%1 & 31)))

[vitorrossi]

Wow, that was simple. Thank you

[Backstabnoob]

If I have this:

#define SetKnife(%1,%2)         (g_iKnifeBit[ %1 ] |= (1<<%2))
#define RemoveKnife(%1,%2)      (g_iKnifeBit[ %1 ] &= ~(1<<%2))
#define HasKnife(%1,%2)     (g_iKnifeBit[ %1 ] & (1<<%2)) 

Can anyone write me a macro that will give me the next set bit value and start again from the beginning if it reaches the end?

Examples (red is the one I start from, green is the one I want to get)

0110 0101 0000 0101 0010 1000 0100 0000
0110 0101 0000 0101 0010 1000 0100 0000

[Bugsy]

I'm rusty but I think this will work, there are probably better ways to do it maybe using bit masks, but this is a basic way of accomplishing it. I don't have anything on this machine to test it with.

iBitField is the variable holding your bits ... %1 in macros
iCurrentBit is the starting bit (red) ... %2 in macros

returns -1 on no found bits or 0-31 (green) if one is found.

Edit: Just to make sure we are on the same page, I am going in the order of 1<<0 to 1<<31, which is (in single byte form):
8765 4321 in that order.

PHP Code:

GetNextBit( iBitField , iCurrentBit )
{
    //iCurrentBit is 13 or 1 << 13

    new i , iFoundBit = -1;

    if ( 0 < iCurrentBit < 31 )  
    {
        //check bits 1 << [14-31]
        for ( i = ( iCurrentBit + 1 ) ; i < 32 ; i++ )
        {
            if ( iBitField & ( 1 << i ) )
            {
                iFoundBit = i;
                break;
            }
        }

        if ( iFoundBit == -1 )
        {
            //check bits 1 << [0-12]
            for ( i = 0 ; i < iCurrentBit ; i++ )
            {
                if ( iBitField & ( 1 << i ) )
                {
                    iFoundBit = i;
                    break;
                }
            }
        }
    }
    else if ( iCurrentBit == 0 )
    {
        //check bits 1 << [1-31]
        for ( i = 1 ; i < 32 ; i++ )
        {
            if ( iBitField & ( 1 << i ) )
            {
                iFoundBit = i;
                break;
            }
        }
    } 

    return iFoundBit;
} 


[Backstabnoob]

Thanks, although I figured if the first cycle's done it should always be the first knife because that's the default one which the user always has:

PHP Code:

new iNew
for( new i = g_iCurrentKnife[ iPlayer ] + 1; i < MAX_KNIVES; i ++ )
{
    if( HasKnife( iPlayer, i ) )
    {
        iNew = i
    }
}
// just a little check to make sure the user doesn't keep switching through knives if he only has one
if( iNew != g_iCurrentKnife[ iPlayer ] )
{
    g_iCurrentKnife[ iPlayer ] = iNew
} 


Still good to see you, where have you been? o.O

[Bugsy]

Originally Posted by Backstabnoob Still good to see you, where have you been? o.O

I just don't spend much time behind a computer anymore. I live with my gf now so my time is spent elsewhere. I try to stop in occasionally but I don't have the time to write plugins. I do miss these boards though.

[claudiuhks]

Originally Posted by RemaKe` Great tutorial! Just a question: PHP Code: new g_IsAdmin; //Only need a single cell of memory public client_putinserver( id ) {     if ( is_user_admin( id ) )              g_IsAdmin |= ( 1 << ( id & 31 ) ); }  Why is "id & 31" required if the result is "id" anyways?

For example, if you want an integral value to never exceed 255, you can do the next thing:

PHP Code:

write_byte(Value & 255); 


So, if Value is 256 then Value equals to 0.
If value is 1000 then Value equals to 232.