Misunderstandings with strings

Electr000999 · **Author**

Hi, i have a dumb question, here my easy example for explane my problem:

Code:

#include <sourcemod>

public OnPluginStart()
{
	RegConsoleCmd ( "sm_test", CmdTest);
}

public Action CmdTest(int client, int args)
{
	Test1("FOOBAR", "FOOBAR");
	
	return Plugin_Handled;
}

void Test1(char[] sTemp1, char[] sTemp2)
{
	PrintToServer("Temp1: %s, sTemp2: %s", sTemp1, sTemp2);
	
	FormatEx(sTemp1, 32, "MOOBAR");
	FormatEx(sTemp2, 32, "MOOBAR");
}

after first run sm_test:
Temp1: FOOBAR, sTemp2: FOOBAR

after second run sm_test:
Temp1: MOOBAR, sTemp2: MOOBAR

after third and other and other runs sm_test:
Temp1: MOOBAR, sTemp2: MOOBAR

in my logic if i am call function Test1 with args FOOBAR it should be they must be passed inside the function, but it only happens once, why?

Electr000999 · 01-07-2022 , 16:45 Re: Misunderstandings with strings

Quote:

Originally Posted by Electr000999

Hi, i have a dumb question, here my easy example for explane my problem:

Code:

#include <sourcemod>

public OnPluginStart()
{
	RegConsoleCmd ( "sm_test", CmdTest);
}

public Action CmdTest(int client, int args)
{
	Test1("FOOBAR", "FOOBAR");
	
	return Plugin_Handled;
}

void Test1(char[] sTemp1, char[] sTemp2)
{
	PrintToServer("Temp1: %s, sTemp2: %s", sTemp1, sTemp2);
	
	FormatEx(sTemp1, 32, "MOOBAR");
	FormatEx(sTemp2, 32, "MOOBAR");
}

after first run sm_test:
Temp1: FOOBAR, sTemp2: FOOBAR

after second run sm_test:
Temp1: MOOBAR, sTemp2: MOOBAR

after third and other and other runs sm_test:
Temp1: MOOBAR, sTemp2: MOOBAR

in my logic if i am call function Test1 with args FOOBAR it should be they must be passed inside the function, but it only happens once, why?

resolved, i am not change string args sTemp1 and sTemp2 inside function Test1, just copy values from them in other vars and wotk with them, like in example:

Code:

#include <sourcemod>

public OnPluginStart()
{
	RegConsoleCmd ( "sm_test", CmdTest);
}

public Action CmdTest(int client, int args)
{
	Test1("FOOBAR", "FOOBAR");
	
	return Plugin_Handled;
}

void Test1(char[] sTemp1, char[] sTemp2)
{
	PrintToServer("Temp1: %s, sTemp2: %s", sTemp1, sTemp2);
	
	char sTemp3[65], sTemp4[65];
	strcopy(sTemp3, 65, sTemp1);
	strcopy(sTemp4, 65, sTemp2);
	
	FormatEx(sTemp3, 32, "MOOBAR");
	FormatEx(sTemp4, 32, "MOOBAR");
}

Bacardi · 01-07-2022 , 21:44 Re: Misunderstandings with strings

I have no good knowledge of coding, what happens here.

My wild guess is, in that function Test1,
you set text into parameter, after compiling and loading plugin into server it reserve that text in memory.
Then you need keep in mind, this memory location could turn to garbage in some point (I'm not 100%).

If you want string to be same in every call, you need... allocate that ? I'm not sure what I'm saying.
For example: Do char buffer and pass that into function.

PHP Code:


			
public void OnPluginStart()

{

    RegConsoleCmd ( "sm_test", CmdTest);

}



public Action CmdTest(int client, int args)

{

    char buffer[] = "FOOBAR1";



    PrintToServer("PRE buffer %s", buffer);



    Test1(buffer, "FOOBAR2");



    PrintToServer("POST buffer %s", buffer);



    return Plugin_Handled;

}



void Test1(char[] string1, char[] string2)

{

    PrintToServer("PRE Test1 %s %s", string1, string2);



    Format(string1, 8, "BARFOO1");

    Format(string2, 8, "BARFOO2");



    PrintToServer("POST Test1 %s %s", string1, string2);

}

output

Code:

sm plugins reload test
[SM] Plugin test.smx reloaded successfully.






sm_test
PRE buffer FOOBAR1
PRE Test1 FOOBAR1 FOOBAR2
POST Test1 BARFOO1 BARFOO2
POST buffer BARFOO1


sm_test
PRE buffer FOOBAR1
PRE Test1 FOOBAR1 BARFOO2
POST Test1 BARFOO1 BARFOO2
POST buffer BARFOO1


sm_test
PRE buffer FOOBAR1
PRE Test1 FOOBAR1 BARFOO2
POST Test1 BARFOO1 BARFOO2
POST buffer BARFOO1

azalty · 01-15-2022 , 15:50 Re: Misunderstandings with strings

Quote:

Originally Posted by Bacardi

My wild guess is, in that function Test1,
you set text into parameter, after compiling and loading plugin into server it reserve that text in memory.

Thanks!

This thread and this answer are very useful

Bacardi · 01-15-2022 , 15:55 Re: Misunderstandings with strings

Hope devs can explain this right and in detail.

**Silvers** · 01-15-2022 , 17:55 Re: Misunderstandings with strings

Which version of SM? This seems strange behavior and unexpected from what should happen. I haven't tested but at some point hopefully I will edit with a test case in SM 1.10.

Since it's printing before modification I would assume the string to be "FOOBAR" always, but as Bacardi said this is maybe something with buffers. Maybe fixed in latest and broken with others, or broken broken in latest but working correctly with others. SM 1.11 is still in development so that could be the reason if you use 1.11.

Bacardi · *Last edited by Bacardi; 01-16-2022 at 04:29.*

Quick one

Spoiler

*edit
here is example of function, which have default value in parameter

PHP Code:


			
public void OnPluginStart()

{

    RegConsoleCmd ( "sm_test", CmdTest);

}



public Action CmdTest(int client, int args)

{

    char buffer[] = "FOOBAR1";



    PrintToServer("PRE buffer %s", buffer);



    Test1(buffer, "FOOBAR2");



    PrintToServer("POST buffer %s", buffer);



    return Plugin_Handled;

}



void Test1(char[] string1, char[] string2, char[] string3 = "FOOBAR3")

{

    PrintToServer("PRE Test1 %s %s %s", string1, string2, string3);



    Format(string1, 8, "BARFOO1");

    Format(string2, 8, "BARFOO2");

    Format(string3, 8, "BARFOO3");



    PrintToServer("POST Test1 %s %s %s", string1, string2, string3);

}

Code:

sm_test
PRE buffer FOOBAR1
PRE Test1 FOOBAR1 FOOBAR2 FOOBAR3
POST Test1 BARFOO1 BARFOO2 BARFOO3
POST buffer BARFOO1


sm_test
PRE buffer FOOBAR1
PRE Test1 FOOBAR1 BARFOO2 FOOBAR3
POST Test1 BARFOO1 BARFOO2 BARFOO3
POST buffer BARFOO1


sm_test
PRE buffer FOOBAR1
PRE Test1 FOOBAR1 BARFOO2 FOOBAR3
POST Test1 BARFOO1 BARFOO2 BARFOO3
POST buffer BARFOO1