[crazyeffect]

What about MultiLangual?

[Fry!]

Originally Posted by crazyeffect What about MultiLangual?

yea, probably i could add ML.

[01101101]

This plugin has a lot of retardness in it, for example:

PHP Code:

if (zp_get_user_zombie(id))
            {
                teleport_player(id)
                client_print(id, print_chat, "[ZP] You are now teleported away as zombie.")
                client_print(id, print_chat, "[ZP] You have teleported %d of %d times", get_pcvar_num(g_ztele_max))
            }
            
            else if (zp_get_user_nemesis(id))
            {
                g_used[id] = 0
                g_canztele[id] = false
                
                client_print(id, print_chat, "[ZP] Sorry but nemesis can't teleport")
                
                return PLUGIN_HANDLED
            } 


Dude, a nemesis is still zombie.

PHP Code:

public client_connect(id)
{
    g_used[id] = 0
    g_canztele[id] = false
}

public client_disconnect(id)
{
    g_used[id] = 0
    g_canztele[id] = false
} 


Why reseting twice?

PHP Code:

client_print(id, print_chat, "[ZP] You have teleported %d of %d times", get_pcvar_num(g_ztele_max)) 


You forgot about one argument.

PHP Code:

g_canztele[id] = false 


You always set it to false, and you never use it (you never block teleporting)

PHP Code:

{
    if (!is_user_alive(id))
    {
        g_used[id] = 0
        g_canztele[id] = false
        
        client_print(id, print_chat, "[ZP] You must be alive to use ztele!")
        
        return PLUGIN_HANDLED
    }
    
    switch (get_pcvar_num(g_ztele_mode))
    {
        case 0:
        {
            teleport_player(id)
            client_print(id, print_chat, "[ZP] You are now teleported to your spawn point.")
            client_print(id, print_chat, "[ZP] You have teleported %d of %d times", get_pcvar_num(g_ztele_max))
        }
        
        case 1:
        {
            if (zp_get_user_zombie(id))
            {
                teleport_player(id)
                client_print(id, print_chat, "[ZP] You are now teleported away as zombie.")
                client_print(id, print_chat, "[ZP] You have teleported %d of %d times", get_pcvar_num(g_ztele_max))
            }
            
            else if (zp_get_user_nemesis(id))
            {
                g_used[id] = 0
                g_canztele[id] = false
                
                client_print(id, print_chat, "[ZP] Sorry but nemesis can't teleport")
                
                return PLUGIN_HANDLED
            }
        }
            
        case 2:
        {
            if (!zp_get_user_zombie(id))
            {
                teleport_player(id)
                client_print(id, print_chat, "[ZP] You are now teleported away as survivor, to your spawn point.")
                client_print(id, print_chat, "[ZP] You have teleported %d of %d times", get_pcvar_num(g_ztele_max))
            }
        }
    }
    
    if (get_pcvar_num(g_ztele_max) == g_used[id])
    {
        g_canztele[id] = false
        client_print(id, print_chat, "[ZP] Sorry but you can't ztele anymore you already did %d of %d times", get_pcvar_num(g_ztele_max))
        
        return PLUGIN_HANDLED
    }
    
    return PLUGIN_CONTINUE
} 


Sooo bad coded...


This should be trashed.

[aaarnas]

1. Removed bug - reseting uses being dead.
2. Fixed zp_extra_ztele_mode.
3. Added multilingual.
4. Removed unneeded pcvar "g_canztele".
5. Removed lost of bugs.
6. Added command /tele
6. Added new cvar zp_extra_ztele_players

zp_extra_ztele_mode 0
1 - botch teams can use it
2 - only humans
3 - only zombies
zp_extra_ztele_players 0
0 - survivors and nemesies can use ztele
1 - only survivors
2 - only nemesies
3 - nemesis/survivors can't use it
zp_extra_ztele_max 3

Known things: Player can reconnect, and his used times will be
reseted.
Tested, and working 100%

[Fry!]

Originally Posted by 01101101 This plugin has a lot of retardness in it, for example: PHP Code: if (zp_get_user_zombie(id))             {                 teleport_player(id)                 client_print(id, print_chat, "[ZP] You are now teleported away as zombie.")                 client_print(id, print_chat, "[ZP] You have teleported %d of %d times", get_pcvar_num(g_ztele_max))             }                          else if (zp_get_user_nemesis(id))             {                 g_used[id] = 0                 g_canztele[id] = false                                  client_print(id, print_chat, "[ZP] Sorry but nemesis can't teleport")                                  return PLUGIN_HANDLED             }  Dude, a nemesis is still zombie. PHP Code: public client_connect(id) {     g_used[id] = 0     g_canztele[id] = false } public client_disconnect(id) {     g_used[id] = 0     g_canztele[id] = false }  Why reseting twice? PHP Code: client_print(id, print_chat, "[ZP] You have teleported %d of %d times", get_pcvar_num(g_ztele_max))  You forgot about one argument. PHP Code: g_canztele[id] = false  You always set it to false, and you never use it (you never block teleporting) PHP Code: {     if (!is_user_alive(id))     {         g_used[id] = 0         g_canztele[id] = false                  client_print(id, print_chat, "[ZP] You must be alive to use ztele!")                  return PLUGIN_HANDLED     }          switch (get_pcvar_num(g_ztele_mode))     {         case 0:         {             teleport_player(id)             client_print(id, print_chat, "[ZP] You are now teleported to your spawn point.")             client_print(id, print_chat, "[ZP] You have teleported %d of %d times", get_pcvar_num(g_ztele_max))         }                  case 1:         {             if (zp_get_user_zombie(id))             {                 teleport_player(id)                 client_print(id, print_chat, "[ZP] You are now teleported away as zombie.")                 client_print(id, print_chat, "[ZP] You have teleported %d of %d times", get_pcvar_num(g_ztele_max))             }                          else if (zp_get_user_nemesis(id))             {                 g_used[id] = 0                 g_canztele[id] = false                                  client_print(id, print_chat, "[ZP] Sorry but nemesis can't teleport")                                  return PLUGIN_HANDLED             }         }                      case 2:         {             if (!zp_get_user_zombie(id))             {                 teleport_player(id)                 client_print(id, print_chat, "[ZP] You are now teleported away as survivor, to your spawn point.")                 client_print(id, print_chat, "[ZP] You have teleported %d of %d times", get_pcvar_num(g_ztele_max))             }         }     }          if (get_pcvar_num(g_ztele_max) == g_used[id])     {         g_canztele[id] = false         client_print(id, print_chat, "[ZP] Sorry but you can't ztele anymore you already did %d of %d times", get_pcvar_num(g_ztele_max))                  return PLUGIN_HANDLED     }          return PLUGIN_CONTINUE }  Sooo bad coded... This should be trashed.

SHUT UP! ><

There is nothing wrong with that... Damn.

[Stixsmaster]

Question?

When you compile locally the original coding...does it give any errors?

If not...why try correcting that which is not needed?

---Stixsmaster

P.S. yes I am helping my good ole pal Fry!...reason being is we have a mutual respect for eachother + I know he enjoys me butting in...

[Fry!]

Originally Posted by Stixsmaster Question? When you compile locally the original coding...does it give any errors? If not...why try correcting that which is not needed? ---Stixsmaster P.S. yes I am helping my good ole pal Fry!...reason being is we have a mutual respect for eachother + I know he enjoys me butting in...

Thanks! Stixs.. Yea, I had same question. It doesn't give any errors or either crushing server so it's not needed to change anything only add something new and optimize plugin.

[01101101]

Originally Posted by Stixsmaster Question? When you compile locally the original coding...does it give any errors? If not...why try correcting that which is not needed? ---Stixsmaster P.S. yes I am helping my good ole pal Fry!...reason being is we have a mutual respect for eachother + I know he enjoys me butting in...

Originally Posted by Fry! Thanks! Stixs.. Yea, I had same question. It doesn't give any errors or either crushing server so it's not needed to change anything only add something new and optimize plugin.

Are you both retard? That code will bug like hell, and can be done in a much better way.
Why the fuck do you think there is an approval system? To discrimine beetwen shit plugins (like this one) and good plugins.

Anyway, in case you have the old code (which I don't know if you already changed it) it will get unapproved, so I'm wasting my precious time in here.

[Arkshine]

Originally Posted by Stixsmaster Question? When you compile locally the original coding...does it give any errors? If not...why try correcting that which is not needed? ---Stixsmaster P.S. yes I am helping my good ole pal Fry!...reason being is we have a mutual respect for eachother + I know he enjoys me butting in...

Originally Posted by Fry! Thanks! Stixs.. Yea, I had same question. It doesn't give any errors or either crushing server so it's not needed to change anything only add something new and optimize plugin.

Really idiot to think like that. It's like you say "My code is badly coded but it works so I don't care what you say".

The problem is :

- You have to provide quality plugin ; if user puts numerous "badly coded" plugin it could have an unwanted effect. So, when you can optimize your plugin, do it. (at least the major optimisation ). A well coded plugin has more chance to generate less issues. Also it's in the rules. You are not there to do quantity.
- You are there to improve your coding skill ; if someone try to help you, don't push him because you "think" it's enough well coded. Take few seconds to review your code. It doesn't hurt and your plugin will be more readable/efficient.

Anyway, in your code there is no major optimization to do.

About the changes you could do, minor things :

- You see you repeat 3 times teleport_player(id) + 2 client_print() ; Create a function with that. Your code will be more neat and you will generate less code.
- Use MSG_PVS instead of MSG_BROADCAST ; no need to show something to player who doesn't look to the origin provided.
- Remove client_connect or client_disconnect ; using both at the same time is pointless.
- Use precache_sound, engfunc() uses a lot more code when precache_sound() does directly the job ; use always this one unless you know what you are doing. ( like wanting to precache in plugin_init for example )

Now about the respawn, you should try instead to let the engine spawning the player, because it will choose a free spawn point among all ; your code will be more safe.

[Fry!]

Originally Posted by Arkshine Really idiot to think like that. It's like you say "My code is badly coded but it works so I don't care what you say". The problem is : - You have to provide quality plugin ; if user puts numerous "badly coded" plugin it could have an unwanted effect. So, when you can optimize your plugin, do it. (at least the major optimisation ). A well coded plugin has more chance to generate less issues. Also it's in the rules. You are not there to do quantity. - You are there to improve your coding skill ; if someone try to help you, don't push him because you "think" it's enough well coded. Take few seconds to review your code. It doesn't hurt and your plugin will be more readable/efficient. Anyway, in your code there is no major optimization to do. About the changes you could do, minor things : - You see you repeat 3 times teleport_player(id) + 2 client_print() ; Create a function with that. Your code will be more neat and you will generate less code. - Use MSG_PVS instead of MSG_BROADCAST ; no need to show something to player who doesn't look to the origin provided. - Remove client_connect or client_disconnect ; using both at the same time is pointless. - Use precache_sound, engfunc() uses a lot more code when precache_sound() does directly the job ; use always this one unless you know what you are doing. ( like wanting to precache in plugin_init for example ) Now about the respawn, you should try instead to let the engine spawning the player, because it will choose a free spawn point among all ; your code will be more safe.

Thanks Arkshine, at least someone can explain more than him, I appreciate that. I will try to do it ASAP.