[exvel]

A few suggestions about using colors.inc.
You don't need to make so complicated translations when colorizing player's name. Just use CPrintToChatAllEx function (author is a client index you want to use as team color). It supports {teamcolor} tag that is based on player's team color.
For example:

"Red Stomp Blue"
{
	"#format"		"{1:s},{2:s}"
	"fr"			"{olive}>> {teamcolor}{1} {default}a stompé {olive}{2} {default}!"
	"en"			"{olive}>> {teamcolor}{1} {default}goomba stomped {olive}{2} {default}!"
}

[psychonic]

Flyfo:
A couple minor things I noticed.

You might want to move

PHP Code:

if(GetConVarFloat(g_Cvar_PluginOnOff) > 0.0) 


from FrameAction to OnGameFrame before FrameAction is called. That way you only check once that the plugin is enabled each from instead of checking MaxClients times. Also, is there a reason you used GetConVarFloat instead of GetConVarBool for that check?

Also, many of your condition checks are redundant.
Ex.

PHP Code:

return pcond >= 0 ? ((pcond & TF2_PLAYER_INVULN) != 0) : false; 


You don't need the ">= 0" check.

[Flyflo]

Originally Posted by exvel Just use CPrintToChatAllEx function (author is a client index you want to use as team color)

I just didn't notice this function ^^ it's really useful.

Originally Posted by psychonic You might want to move PHP Code: if(GetConVarFloat(g_Cvar_PluginOnOff) > 0.0)  from FrameAction to OnGameFrame before FrameAction is called. That way you only check once that the plugin is enabled each from instead of checking MaxClients times.

You're right, it's more logical and efficient this way.

Originally Posted by psychonic Also, is there a reason you used GetConVarFloat instead of GetConVarBool for that check?

No


First post and plugin updated !

[bouncer]

without...

sm_goomba_ff 1/0 (default 0) : Enable the friendly fire for the stomp (require mp_friendlyfire = 1)

will the plugin be useless then? Cause i dont want friendly fire on my server, or can the players still kill the other players?

[Flyflo]

I don't understand, you want to enable the friendly fire only for the stomp ?

[bouncer]

No, I don't really understand what that command means...

if that is set to 0 will the plugin still work? What is that command for?

[Flyflo]

Yes it'll work, sm_goomba_ff enables stomp between players of the same team when mp_friendlyfire is set to 1. By default you can just stomp players of the other team.

[bouncer]

k thanks.
installed

[WGSXFrank]

It seems that this is causing my server to crash with the latest update whenever anyone actually performs a stomp.

It was working great for months before the update.

Dumb Valve...

[Flyflo]

Ok, I'll look at it as soon as possible.