[bLacK-bLooD]

The RegisterSystem plugin still fails with the same error like in the first post.

It happens 1-2 times a day out of nowhere. It only started when upgraded from amxx 1.8.2 to 1.8.3 dev

[Arkshine]

A stack error in this context is likely caused by an infinite loop.

I can reproduce it with this code:

#include <amxmodx>

public plugin_init()
{
     register_message(get_user_msgid("ShowMenu"), "OnShowMenu")
     register_menucmd(register_menuid("Register System Main Menu"), 1023, "HandlerMainMenu")
}

public OnShowMenu(msgid, dest, id)
{
    static menu_text[64];
    get_msg_arg_string(4, menu_text, charsmax(menu_text))

    if (contain(menu_text, "#Team_Select") >= 0)
    {
        MainMenu(id)
        return PLUGIN_HANDLED;
    }

    return PLUGIN_CONTINUE;
}

public MainMenu(id)
{
    show_menu(id, MENU_KEY_1|MENU_KEY_0, "1. My Item", -1, "Register System Main Menu");
}

public HandlerMainMenu(id, key)
{
    if (++key == 1)
    {
        MainMenu(id);
    }

    return PLUGIN_HANDLED;
}

It's a side-effect of https://bugs.alliedmods.net/show_bug.cgi?id=3199. "show_menu" and "menu_display" closes the currently viewed menu by sending "menuselect 10" on the client. But in CS, at this point (when a player is not yet fully joined), it will ignore this command, and the game will resend a "#Team_Select" message, then the plugin will hook ShowMenu again, sends "show_menu" native, then "menuselect 10", etc. Infinite loop.

[bLacK-bLooD]

Originally Posted by Arkshine A stack error in this context is likely caused by an infinite loop. I can reproduce it with this code: #include <amxmodx> public plugin_init() {      register_message(get_user_msgid("ShowMenu"), "OnShowMenu")      register_menucmd(register_menuid("Register System Main Menu"), 1023, "HandlerMainMenu") } public OnShowMenu(msgid, dest, id) {     static menu_text[64];     get_msg_arg_string(4, menu_text, charsmax(menu_text))     if (contain(menu_text, "#Team_Select") >= 0)     {         MainMenu(id)         return PLUGIN_HANDLED;     }     return PLUGIN_CONTINUE; } public MainMenu(id) {     show_menu(id, MENU_KEY_1|MENU_KEY_0, "1. My Item", -1, "Register System Main Menu"); } public HandlerMainMenu(id, key) {     if (++key == 1)     {         MainMenu(id);     }     return PLUGIN_HANDLED; } It's a side-effect of https://bugs.alliedmods.net/show_bug.cgi?id=3199. "show_menu" and "menu_display" closes the currently viewed menu by sending "menuselect 10" on the client. But in CS, at this point (when a player is not yet fully joined), it will ignore this command, and the game will resend a "#Team_Select" message, then the plugin will hook ShowMenu again, sends "show_menu" native, then "menuselect 10", etc. Infinite loop.

Can we make a fix for it?

[Arkshine]

An immediate solution for this context (when a player is not yet fully joined) is to set "m_iMenu" offset to 0 before calling show_menu().

For AMXX, we need a more generic solution.

[bLacK-bLooD]

Originally Posted by Arkshine An immediate solution for this context (when a player is not yet fully joined) is to set "m_iMenu" offset to 0 before calling show_menu(). For AMXX, we need a more generic solution.

I see you created a pull request on github:

https://github.com/alliedmodders/amxmodx/pull/471

If this is merged, the next build basically will have the problem solved?

[Depresie]

Yep, usually after reporting a bug, in a span of few days, we get a new build where the problem is fixed

[Arkshine]

Unless no one reviews the patch.

[bLacK-bLooD]

Originally Posted by Arkshine Unless no one reviews the patch.

Yeah, I saw nobody reviewed it. Why so?