Raised This Month: $51 Target: $400
 12% 

Connect Message


Post New Thread Reply   
 
Thread Tools Display Modes
Benjamin1995
SourceMod Donor
Join Date: May 2009
Location: Germany
Old 09-13-2009 , 06:02   Re: Connect Message
Reply With Quote #11

Ok.... Download it again and compile it now there are 0 Errors and 0 Warnings...

Ehm and Berni add me Please i wont annoy you.
__________________
Benjamin1995 is offline
Send a message via Skype™ to Benjamin1995
tcviper
Veteran Member
Join Date: Oct 2005
Location: Netherlands
Old 09-14-2009 , 09:22   Re: Connect Message
Reply With Quote #12

Question what is the difference with this and the 4 other plugins that already do this?
__________________
tcviper is offline
Send a message via MSN to tcviper
Benjamin1995
SourceMod Donor
Join Date: May 2009
Location: Germany
Old 09-20-2009 , 09:41   Re: Connect Message
Reply With Quote #13

lol mhhh i think you can add a join sound with different types
__________________
Benjamin1995 is offline
Send a message via Skype™ to Benjamin1995
Benjamin1995
SourceMod Donor
Join Date: May 2009
Location: Germany
Old 10-09-2009 , 18:38   Re: Connect Message
Reply With Quote #14

Ehm Berni i already fixed the bugs.....
and i know why did you do that because of.........
__________________
Benjamin1995 is offline
Send a message via Skype™ to Benjamin1995
thetwistedpanda
Good Little Panda
Join Date: Sep 2008
Old 10-09-2009 , 18:45   Re: Connect Message
Reply With Quote #15

Since when is a plug-in doing similar things a reason for disapproval? That's just a slap in the face to being original or having ingenuity. If he fixed the bugs it shouldn't be disapproved for that reason.
thetwistedpanda is offline
berni
SourceMod Plugin Approver
Join Date: May 2007
Location: Austria
Old 10-10-2009 , 09:58   Re: Connect Message
Reply With Quote #16

The plugin still doesn't let the user download the sound files.
In the description is nowhere mentioned that this plugin also displays a center message and a chatmessage when the user connects.
The code is a mess, doesn't use functions to encapsulate the code which is copy and pasted again and again like I asked Benni todo. ~300 code lines of this plugin are not needed.
I also asked to use the dyn var MaxClients instead of GetMaxClients(), but that's not a requirement for approval.
The code is hardly readable, has 10 linebreaks in the middle of the code for no reason a few times (copy and paste).
The cvars have all this descripton: "Point and go" wtf ?
He is talking about roleplay, but not saying which game/roleplay plugin this is for.
And the plugin also doesn't provide any cvars for customizing...

@thetwistedpanda

Since 2007, it's indeed a requirement according to Bailopan, and this plugin doesn't really add or fix something new to the collective functionality.

And besides that, this Benni kid has already added me like 10 times on Steam, which I find annoying as he knows I'm not going to accept him.
And you should also know that he crashed my own gameserver a few times out of fun but those things are unrelated to the approval of this plugin.


Greetings ~Berni
__________________
Why reinvent the wheel ? Download smlib with over 350 useful functions.

When people ask me "Plz" just because it's shorter than "Please" I feel perfectly justified to answer "No" because it's shorter than "Yes"
powered by Core i7 3770k | 32GB DDR3 1886Mhz | 2x Vertex4 SSD Raid0

Last edited by berni; 10-10-2009 at 10:04.
berni is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 10:46.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode